On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*).
> NetLibGetMacAddress() only uses the return value ("SnpHandle") for a
> NULL-check. Fix the type of "SnpHandle".
>
> This patch is a no-op.
>
> Cc: Jiaxin Wu <jiaxin...@intel.com>
> Cc: Siyuan Fu <siyuan...@intel.com>
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> ---
>
> Notes:
> lightly tested: MAC strings are displayed in UiApp
>
> NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 8e2f720666ea..a39c20be3d34 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -2182,7 +2182,7 @@ NetLibGetMacAddress (
> EFI_SIMPLE_NETWORK_MODE SnpModeData;
> EFI_MANAGED_NETWORK_PROTOCOL *Mnp;
> EFI_SERVICE_BINDING_PROTOCOL *MnpSb;
> - EFI_HANDLE *SnpHandle;
> + EFI_HANDLE SnpHandle;
> EFI_HANDLE MnpChildHandle;
>
> ASSERT (MacAddress != NULL);
>
Since SnpHandle is only checked for being non-null, this change is
indeed a no-op, else it would probably fixed some bug.
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47922): https://edk2.groups.io/g/devel/message/47922
Mute This Topic: https://groups.io/mt/34180219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
