On 9/20/19 12:24 PM, Leif Lindholm wrote: > > On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: >> On 09/19/19 20:06, Leif Lindholm wrote: >>> Cc: Jordan Justen <jordan.l.jus...@intel.com> >>> Cc: Laszlo Ersek <ler...@redhat.com> >>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >>> Cc: Anthony Perard <anthony.per...@citrix.com> >>> Cc: Julien Grall <julien.gr...@arm.com> >>> Cc: David Woodhouse <dw...@infradead.org> >>> Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org> >>> --- >>> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- >>> OvmfPkg/AcpiPlatformDxe/Xen.c | 8 ++++---- >>> OvmfPkg/AcpiTables/Facs.aslc | 6 +++--- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 >>> +++++++++--------- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 >>> +++++++++++++++++----------------- >>> OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +++++----- >>> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +- >>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 >>> ++++++------ >>> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +- >>> OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 ++-- >>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- >>> OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +- >>> OvmfPkg/PlatformPei/Xen.c | 2 +- >>> OvmfPkg/SataControllerDxe/ComponentName.c | 6 +++--- >>> OvmfPkg/SataControllerDxe/SataController.c | 214 >>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- >>> OvmfPkg/SataControllerDxe/SataController.h | 208 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------- >> >> (did you forget --stat-graph-width=20?) > > Hmm... > *scratches head* > First of all, I saw that before sending out and didn't even reflect on > it. Clearly past git-send-email-o-clock. > > Secondly, I have > [diff] > statGraphWidth = 20 > in .git/config from running SetupGit.py. > > Oh, rubbish. From git-diff manpage: > --- > The width of the graph part can be limited by using > --stat-graph-width=<width> (affects all commands generating a stat > graph) or by setting diff.statGraphWidth=<width> (does not affect git > format-patch).
TIL this doesn't affect git-format-patch... Odd. > --- > I had missed that bit. So yeah, that setting in SetupGit.py is > completely meaningless. > (Why would you give those two different code paths?!?) > > Which given we already can't set --stat ... > Do you think it might be a good idea to set up a few standard aliases? > >>> OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +++--- >>> OvmfPkg/Sec/SecMain.c | 34 >>> +++++++++++++++++----------------- >>> 27 files changed, 301 insertions(+), 301 deletions(-) >> >> I've checked this patch with "git show -b" (--> nothing) and "git show >> --word-diff" (--> output consists purely of context). >> >> Reviewed-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47840): https://edk2.groups.io/g/devel/message/47840 Mute This Topic: https://groups.io/mt/34202575/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
