Hi Gerd
Sorry for responding late.
Using 5level paging when the below two conditions are both true:
1. CPU support 5level paging
2. Platform choose to use 5level paging. (by specifing macro
USE_5_LEVEL_PAGE_TABLE)
There is an assumption that if platform choose to use 5level paging, then
5lev
On 4/14/23 00:04, Rebecca Cran wrote:
On 4/13/23 07:14, PierreGondois wrote:
diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
index 0755dc155616..583efd0efb16 100644
--- a/Platform/ARM/JunoPkg/Libr
From: Pierre Gondois
Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code
as Juno-r0 doesn't support PCIe.
Check Juno's revisi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4413
Make the DXE_CORE module able to call the crypto protocol,
which can reduce FV size on platforms using the Crypto Binaries.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Library/BaseC
Setting visibility to hidden can cause linker errors when BaseTools are
linked against standard libraries.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/X64/ProcessorBind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/X64/ProcessorBind.h
b/MdePkg/Include/
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over to use the include files in
MdePkg instead. It also cleans up some (apparently) obsolete code and
adapts BaseT
Allows for BaseTools-specific tweaks in include files.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Makefiles/header.makefile | 3 +++
BaseTools/Source/C/Makefiles/ms.common | 4 ++--
BaseTools/Source/C/VfrCompile/GNUmakefile| 1 +
3 files changed, 6 insertions(+), 2 deletions(-
Appears to be a relic for ancient windows / compiler versions,
windows builds in CI work just fine without it.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/WinNtInclude.h| 66 -
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 1 -
BaseTools/Source/C/GenFw/Elf
The BaseTools and MdePkg versions of PeImage.h diverged over time,
add some missing bits to the MdePkg header file in preparation for
removing the BaseTools version.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/IndustryStandard/PeImage.h | 31 +++
1 file changed, 31 insert
The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg,
this looks like a relic not used any more. Remove.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/BasePeCoff.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/BaseTools/Sour
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../Source/C/Include/AArch64/ProcessorBind.h | 148 --
.../Source/C/Include/Arm/ProcessorBind.h | 147 --
.../Source/C/Include/Ia32/ProcessorBin
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Acked-by: Sunil V L
---
.../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
.../C/Include/IndustryStandard/Acpi1_0.h | 285
.../C/Include/IndustryStandard/Acpi2_0.h | 520
Use the newer versions of the machine #defines.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++---
.../C/Include/IndustryStandard/PeImage.h | 1 +
BaseTools/Source/C/Common/BasePeCoff.c| 28 ++---
BaseTools/Sourc
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../C/Include/IndustryStandard/PeImage.h | 790 --
1 file changed, 790 deletions(-)
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeIma
Use the MdePkg versions instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/EfiRom/EfiRom.h| 4 +-
.../C/Include/IndustryStandard/Bluetooth.h| 56 --
.../C/Include/IndustryStandard/EfiPci.h | 51 --
...emoryMappedConfiguration
After shrinking the FSP (FV) component using FMMT, Image size
in FSP info header is not in sync with the FV length in FV header.
This enhancement helps to patch the FSP image size offset with
correct length & can be used to patch any offset directly on
the FSP Component Fd .
Signed-off-by: Duggapu
ArmVirtXen.dsc allows setting the firmware version
string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
via FIRMWARE_VER variable conveniently on the build command line.
These two patches add this behavior to all .dsc files in ArmVirtPkg
and OvmfPkg.
PR: https://github.com/tianocore/
ArmVirtXen.dsc initializes
gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with with the
value of the variable "FIRMWARE_VER".
Move that functionality to ArmVirt.dsc.inc to make it available to all
ArmVirt packages, and make it conditional: only set the PCD string if
FIRMWARE_VER is actual
Initialize gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with
with the value of the variable "FIRMWARE_VER", if is is defined. Applies
to all flavors of OvmfPkg.
This behavior is already implemented in ArmVirtXen.dsc. It allows
specifying the firmware version string on the build command
After shrinking the FSP (FV) component using FMMT, Image size
in FSP info header is not in sync with the FV length in FV header.
This enhancement helps to patch the FSP image size offset with
correct length & can be used to patch any offset directly on
the FSP Component Fd .
Cc: Chasel Chiu
Cc: N
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Minh Nguyen
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang
> ; ig...@ami.com; n...@os.amperecomputing.com;
> tinhngu...@os.amperec
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Minh Nguyen
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang
> ; ig...@ami.com; n...@os.amperecomputing.com;
> tinhngu...@os.amperec
MdeModulePkg has never depended on UefiCpuPkg before. Please double
check if there's any side effect introduced by this mutual dependency.
Acked-by: Jian J Wang
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 31, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; N
Hi Minh,
> Prevent assertion of allocate zero length region
May I know where does zero length allocation happen? According to my
understanding, setting the "SubnetAddrInfoIPv6Number" to zero here and it will
be handled by below condition check:
https://github.com/tianocore/edk2/blob/55b67b6950
Reviewed-by: Ted Kuo
Thanks,
Ted
-Original Message-
From: Duggapu, Chinni B
Sent: Friday, April 14, 2023 4:34 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; Kuo, Ted
; Duggapu, Chinni B
Subject: [PATCH v2] IntelFsp2Pkg/Tools: Enhance PathFv.py to
This will cause that MdeModulePkg depends on UefiCpuPkg. Please double
check if there's any side effect introduced by breaking unidirectional
dependency.
Acked-by: Jian J Wang
> -Original Message-
> From: Tan, Dun
> Sent: Friday, March 31, 2023 5:34 PM
> To: devel@edk2.groups.io
> Cc:
Thanks for your quick response.
> but the second change is necessary. How do you think about that?
Yes, second change is necessary. Please keep second change in v2 patches.
Thanks,
Nickle
> -Original Message-
> From: Minh Nguyen
> Sent: Friday, April 14, 2023 5:18 PM
> To: Nickle Wang
> Using 5level paging when the below two conditions are both true:
> 1. CPU support 5level paging
> 2. Platform choose to use 5level paging. (by specifing macro
> USE_5_LEVEL_PAGE_TABLE)
>
> There is an assumption that if platform choose to use 5level paging,
> then 5level paging should be su
Hi,
>-drive
> if=pflash,format=raw,unit=0,file=/root/kernels/qemu-install/OVMF_CODE.fd,readonly=on
>-drive if=pflash,format=raw,unit=1,file=./fedora.fd
> In this case, only OVMF_CODE.fd will be encrypted.
> The fedora.fd (OVMF_VARS.fd) will be unencrypted.
>-drive
> if=pflash,f
Reviewed-by: JIewen Yao
> -Original Message-
> From: Li, Yi1
> Sent: Friday, April 14, 2023 3:33 PM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Wang, Jian J ; Yao,
> Jiewen ; Lu, Xiaoyu1 ; Jiang,
> Guomin
> Subject: [PATCH] CryptoPkg: Enable DXE_CORE support in DxeCryptLib.inf
>
> REF:
Sorry for not commenting on this earlier.
Would it be better to have people use the build `--pcd` option instead?
e.g. build
--pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".
--
Rebecca Cran
On 4/14/23 02:33, Oliver Steffen wrote:
ArmVirtXen.dsc allows se
On 4/14/23 02:02, Gerd Hoffmann wrote:
diff --git a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
index 22161edf443d..fb867b5660a9 100644
--- a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
+++ b/BaseTools/Source/C/Include/
If it passes CI, then for the series:
Reviewed-by: Rebecca Cran
On 4/14/23 02:02, Gerd Hoffmann wrote:
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over t
Hello Ard,
KvmTool, Qemu, Xen and CloudHv use the following implementation:
PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
Testing:
- using kvmtool
- not pressing any key during the process
I end-up in the boot menu (so not the UEFI shell).
When trying wit
Hi Gerd,
Thanks for your effort!
Sorry, but I *really* dislike this “BASETOOLS” notion. There might be external
tools that also want to use the header (like we do with AUDK) and also edk2
supports host-based unit tests. Imo the macro name should be generic, like
“HOST_OS” or “USERLAND” or some
Hello Ard,
On 2/9/23 17:57, Ard Biesheuvel wrote:
On Tue, 7 Feb 2023 at 10:07, wrote:
From: Pierre Gondois
The UEFI Shell is a non-active boot option, at the opposite of UiApp.
If no valid boot option is found, UiApp is selected. UiApp requires a
human interaction. When installing a new EDK
Hi, Pedro,
Sorry. I will update copyright in Patch v3.
In my opinion for edk2 style, a implementation of library is required a header
file and LibraryClass name for reference by others externally. Since libfdt is
a third-party and we cannot include header files under the library immediately,
w
On 4/14/23 00:07, Ni, Ray wrote:
-Original Message-
From: Tom Lendacky
Sent: Friday, April 14, 2023 12:19 AM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Ni, Ray
Subject: Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and
update smm page table
On 4/13/23 04:14, Tan, Dun wr
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Minh Nguyen
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; Chang, Abner
> ; nick...@nvidia.com; ig...@ami.com;
> n...@os.amperecomputing.com; tin
On Fri, Apr 14, 2023 at 12:29:21PM +, Marvin Häuser wrote:
> Hi Gerd,
>
> Thanks for your effort!
>
> Sorry, but I *really* dislike this “BASETOOLS” notion. There might be
> external tools that also want to use the header (like we do with AUDK)
> and also edk2 supports host-based unit tests.
On Fri, Apr 14, 2023 at 06:16:52AM -0600, Rebecca Cran wrote:
> On 4/14/23 02:02, Gerd Hoffmann wrote:
>
> > diff --git a/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
> > b/BaseTools/Source/C/Include/IndustryStandard/PeImage.h
> > index 22161edf443d..fb867b5660a9 100644
> > --- a/BaseToo
> On 14. Apr 2023, at 16:37, Gerd Hoffmann wrote:
>
> On Fri, Apr 14, 2023 at 12:29:21PM +, Marvin Häuser wrote:
>> Hi Gerd,
>>
>> Thanks for your effort!
>>
>> Sorry, but I *really* dislike this “BASETOOLS” notion. There might be
>> external tools that also want to use the header (like
On Fri, 14 Apr 2023 at 16:37, Gerd Hoffmann wrote:
>
> On Fri, Apr 14, 2023 at 12:29:21PM +, Marvin Häuser wrote:
> > Hi Gerd,
> >
> > Thanks for your effort!
> >
> > Sorry, but I *really* dislike this “BASETOOLS” notion. There might be
> > external tools that also want to use the header (like
> On 14. Apr 2023, at 16:57, Ard Biesheuvel wrote:
>
> On Fri, 14 Apr 2023 at 16:37, Gerd Hoffmann wrote:
>>
>>> On Fri, Apr 14, 2023 at 12:29:21PM +, Marvin Häuser wrote:
>>> Hi Gerd,
>>>
>>> Thanks for your effort!
>>>
>>> Sorry, but I *really* dislike this “BASETOOLS” notion. There
If components outside the UefiCpuPkg need access to the CpuPageTableLib, should
we
consider moving CpuPageTableLib to MdePkg or MdeModulePkg? There are many
different
boot phases that need to crate/manage page tables, so we need to find the right
common location. Perhaps the only part that need
Hi Chinni,
Please help to correct patch format and make sure it can pass verification by
BaseTools/Scripts/PatchCheck.py
Thanks,
Chasel
> -Original Message-
> From: Duggapu, Chinni B
> Sent: Friday, April 14, 2023 1:34 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nat
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/3b7f82b61b552f5bdd415f1bf4ba2866a09ceac0
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathani
Mike,
What's the rule regarding content in mdepkg and cpupkg?
thanks,
ray
From: Kinney, Michael D
Sent: Friday, April 14, 2023 11:16:45 PM
To: devel@edk2.groups.io ; Wang, Jian J
; Tan, Dun
Cc: Gao, Liming ; Ni, Ray ; Kinney,
Michael D
Subject: RE: [edk2-devel
tom,
if the c bit is not required for non leaf page table entries, why the trunk
code sets the c bit for all entities including nonleaf ones?
i went back to read again the smm issue you met. you said the c bit is set for
non leaf entries that caused a deference issue. But the pagetablelib code
RISC-V: Add MMU support
This series adds MMU support for RISC-V. Only SV39/48/57 modes
are supported and tested. The MMU is required to support setting
page attribute which is the first basic step to support security
booting on RISC-V.
There are three parts:
1. Add MMU base library. MMU will be e
Add an API to retrieve satp register value.
Signed-off-by: Tuan Phan
---
MdePkg/Include/Library/BaseLib.h | 5 +
MdePkg/Library/BaseLib/RiscV64/RiscVMmu.S | 8
2 files changed, 13 insertions(+)
diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.
The satp mode bits shift is used cross modules. It should be defined
in one place.
Signed-off-by: Tuan Phan
---
MdePkg/Include/Register/RiscV64/RiscVEncoding.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/Register/RiscV64/RiscVEncoding.h
b/MdePkg/Inc
The size should be for single region, not the whole firmware FD.
Signed-off-by: Tuan Phan
---
.../Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStatic
During CpuDxe initialization, MMU will be setup with the highest
mode that HW supports.
Signed-off-by: Tuan Phan
---
MdePkg/Include/Library/BaseRiscVMmuLib.h | 39 ++
.../Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 569 ++
.../BaseRiscVMmuLib/BaseRiscVMmuLib.inf | 25
Normally, DXE driver would add device resource to GCD before start using.
But some key resources such as uart, flash base address are being accessing
directly in some core modules.
Those resources should be populated to HOB in SEC phase so they are
added to GCD before anyone can access them.
Sign
The flash base address can be added to GCD before this driver run.
So only add it if it has not been done.
Signed-off-by: Tuan Phan
---
OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c | 25 +++
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/OvmfPkg/VirtNorFlashDxe/V
On 4/14/23 12:19, Ni, Ray via groups.io wrote:
tom,
if the c bit is not required for non leaf page table entries, why the trunk
code sets the c bit for all entities including nonleaf ones?
Because it's effectively the correct thing to do, even though it doesn't
matter.
i went back to read
I've been trying to debug a problem I'm seeing when I moved to the GCC 12
compiler. Under SEV it results in the guest crashing.
I narrowed the issue down to the call to TemporaryRamMigration() in
PeiCheckAndSwitchStack() of MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c.
I get this output on GCC1
On 4/14/23 15:23, Tom Lendacky wrote:
I've been trying to debug a problem I'm seeing when I moved to the GCC 12
compiler. Under SEV it results in the guest crashing.
False alarm, I was on the wrong branch that does not have ff36b2550f94
("OvmfPkg/Sec: fix stack switch")... disregard.
Thanks,
On Fri, 14 Apr 2023 at 22:23, Tom Lendacky wrote:
>
> I've been trying to debug a problem I'm seeing when I moved to the GCC 12
> compiler. Under SEV it results in the guest crashing.
>
> I narrowed the issue down to the call to TemporaryRamMigration() in
> PeiCheckAndSwitchStack() of MdeModulePkg
On 4/14/23 16:39, Ard Biesheuvel wrote:
On Fri, 14 Apr 2023 at 22:23, Tom Lendacky wrote:
I've been trying to debug a problem I'm seeing when I moved to the GCC 12
compiler. Under SEV it results in the guest crashing.
I narrowed the issue down to the call to TemporaryRamMigration() in
PeiChec
Why does OVMF choose to migrate the content from NEM to MEM itself?
PEI core can do the migration well.
thanks,
ray
From: devel@edk2.groups.io on behalf of Lendacky, Thomas
via groups.io
Sent: Saturday, April 15, 2023 5:50:25 AM
To: Ard Biesheuvel
Cc: devel@edk
[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, April 13, 2023 2:21 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 1/5] RedfishPkg: introduce
> EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL
>
[AMD Official Use Only - General]
Hi Tinh,
Apparently I missed some of your feedback, it was moved to other email folder
that I don’t expect it should be.
I will add those modules for AARCH64.
Thanks
Abner
> -Original Message-
> From: Tinh Nguyen
> Sent: Tuesday, March 28, 2023 8:23 PM
>
> But with 5-level paging enabled the reset vector should be able to
> fallback to 4-level paging in case the CPU does not support 5-level
> paging.
The fallback makes sense. Otherwise, forcing to use 5L in an incapable CPU
would be a silent failure because IDT and debug log are not enabled at
I did a quick check on what TemporaryRamMigration does for OVMF.
No magic there. I think you could try to remove the code in
OvmfPkg/Sec/SecMain.c
that does the TemporaryRamSupportPpi installation.
If no such PPI, the migration will be done by PEI core.
Thanks,
Ray
From: devel@edk2.groups.io On
[AMD Official Use Only - General]
> -Original Message-
> From: Tinh Nguyen
> Sent: Friday, March 24, 2023 2:31 AM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone
> ; Nickle Wang ;
> Igor Kulchytskyy ; Attar, AbdulLateef (Abdul Lateef)
>
> Subje
67 matches
Mail list logo
