Sorry for not commenting on this earlier.
Would it be better to have people use the build `--pcd` option instead?
e.g. build
--pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302".
--
Rebecca Cran
On 4/14/23 02:33, Oliver Steffen wrote:
ArmVirtXen.dsc allows setting the firmware version
string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
via FIRMWARE_VER variable conveniently on the build command line.
These two patches add this behavior to all .dsc files in ArmVirtPkg
and OvmfPkg.
PR: https://github.com/tianocore/edk2/pull/4268
v4:
- Actually use the include file
v3:
- Introduce common include file for OVMF .dsc files
https://edk2.groups.io/g/devel/message/102952
v2:
Address comments by Sami and Gerd:
- Only set PCD if FIRMWARE_VER is defined
- ArmVirt: move logic to ArmVirt.dsc.inc
https://edk2.groups.io/g/devel/message/95208
v1:
https://edk2.groups.io/g/devel/message/95057
Oliver Steffen (2):
OvmfPkg: allow setting Firmware Version from build command line
ArmVirtPkg: allow setting Firmware Version from build command line
ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++
OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++
ArmVirtPkg/ArmVirtXen.dsc | 1 -
OvmfPkg/OvmfPkgIa32.dsc | 2 ++
OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++
OvmfPkg/OvmfPkgX64.dsc | 3 +++
OvmfPkg/OvmfXen.dsc | 2 ++
7 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102996): https://edk2.groups.io/g/devel/message/102996
Mute This Topic: https://groups.io/mt/98258183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
