Thanks for your quick response. > but the second change is necessary. How do you think about that?
Yes, second change is necessary. Please keep second change in v2 patches. Thanks, Nickle > -----Original Message----- > From: Minh Nguyen <mi...@amperecomputing.com> > Sent: Friday, April 14, 2023 5:18 PM > To: Nickle Wang <nick...@nvidia.com>; Minh Nguyen OS > <minhngu...@os.amperecomputing.com>; devel@edk2.groups.io > Cc: Open Source Submission <patc...@amperecomputing.com>; > abner.ch...@amd.com; ig...@ami.com; Nhi Pham OS > <n...@os.amperecomputing.com>; Tinh Nguyen OS > <tinhngu...@os.amperecomputing.com>; Vu Nguyen OS > <vungu...@os.amperecomputing.com> > Subject: RE: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length > region > > External email: Use caution opening links or attachments > > > Hi Wang, > > Thanks for this point, you're right. It's a redundant change and I will > update in v2 > patches, but the second change is necessary. How do you think about that? > > Thanks, > Minh Nguyen > > -----Original Message----- > From: Nickle Wang <nick...@nvidia.com> > Sent: Friday, April 14, 2023 4:04 PM > To: Minh Nguyen OS <minhngu...@os.amperecomputing.com>; > devel@edk2.groups.io > Cc: Open Source Submission <patc...@amperecomputing.com>; > abner.ch...@amd.com; ig...@ami.com; Nhi Pham OS > <n...@os.amperecomputing.com>; Tinh Nguyen OS > <tinhngu...@os.amperecomputing.com>; Vu Nguyen OS > <vungu...@os.amperecomputing.com> > Subject: RE: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length > region > > [EXTERNAL EMAIL NOTICE: This email originated from an external sender. > Please be mindful of safe email handling and proprietary information > protection > practices.] > > > Hi Minh, > > > Prevent assertion of allocate zero length region > > May I know where does zero length allocation happen? According to my > understanding, setting the "SubnetAddrInfoIPv6Number" to zero here and it will > be handled by below condition check: > > https://github.c/ > om%2Ftianocore%2Fedk2%2Fblob%2F55b67b6950e648338adfe8ec54aeb26ed8 > 9d2c97%2FRedfishPkg%2FRedfishDiscoverDxe%2FRedfishDiscoverDxe.c%23L10 > 05&data=05%7C01%7Cnicklew%40nvidia.com%7Cca169d4eb55a4b11fb8a08db > 3cc925aa%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6381706068 > 44107782%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4MAT% > 2FDmrUBy%2BVF1%2F%2BNVTxg0iNOQtJJ%2BdlzXrNiluFA8%3D&reserved=0 > > Then the code leaves function with EFI_NOT_FOUND error. > > Thanks, > Nickle > > > -----Original Message----- > > From: Minh Nguyen <minhngu...@os.amperecomputing.com> > > Sent: Friday, April 14, 2023 4:19 PM > > To: devel@edk2.groups.io > > Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang > > <nick...@nvidia.com>; ig...@ami.com; n...@os.amperecomputing.com; > > tinhngu...@os.amperecomputing.com; Vu Nguyen > > <vungu...@os.amperecomputing.com>; Minh Nguyen > > <minhngu...@os.amperecomputing.com> > > Subject: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero > > length region > > > > External email: Use caution opening links or attachments > > > > > > From: Vu Nguyen <vungu...@os.amperecomputing.com> > > > > This change also fix miscellaneous errors on condition checking and > > debug argument missing. > > > > Signed-off-by: Minh Nguyen <minhngu...@os.amperecomputing.com> > > --- > > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > index 583c6f78e19c..29e7b0624ebf 100644 > > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > > @@ -5,6 +5,7 @@ > > (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR> > > Copyright (c) 2022, AMD Incorporated. All rights reserved. > > Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. > > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -272,7 +273,7 @@ Tcp6GetSubnetInfo ( > > if (IpModedata.AddressCount == 0) { > > DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__)); > > Instance->SubnetAddrInfoIPv6Number = 0; > > - return EFI_SUCCESS; > > + return EFI_NOT_FOUND; > > } > > > > if (Instance->SubnetAddrInfoIPv6 != NULL) { @@ -926,7 +927,7 @@ > > AddAndSignalNewRedfishService ( > > } > > > > Status = gBS->SignalEvent (Instance->DiscoverToken->Event); > > - if (!EFI_ERROR (Status)) { > > + if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); > > } > > } > > -- > > 2.39.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102992): https://edk2.groups.io/g/devel/message/102992 Mute This Topic: https://groups.io/mt/98258415/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
