Hi, Pedro, Sorry. I will update copyright in Patch v3.
In my opinion for edk2 style, a implementation of library is required a header file and LibraryClass name for reference by others externally. Since libfdt is a third-party and we cannot include header files under the library immediately, we have to implement a header file for that. Also, we follow up edk2 style to make wrappers. Thanks a lot, Pedro. QQQ Benny -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato Sent: Friday, April 14, 2023 2:32 AM To: Kinney, Michael D <michael.d.kin...@intel.com> Cc: edk2-devel-groups-io <devel@edk2.groups.io> Subject: Re: [edk2-devel] FW: [PATCH v2 2/3] MdePkg: Support FDT library. +CC edk2-devel, It seems that you dropped it accidentally. On Thu, Apr 13, 2023 at 7:30 PM Pedro Falcato <pedro.falc...@gmail.com> wrote: > > On Thu, Apr 13, 2023 at 5:53 PM Kinney, Michael D > <michael.d.kin...@intel.com> wrote: > > > > Hi Pedro, > > > > Any comments in this new version? Have your concerns been addressed, > > especially libc conformance. > > > > Mike > > Mike, > > I'm really sorry but I'm dealing with serious personal issues so I > can't give you much feedback > > However I skimmed through the patch and it looks okay to me, if you > add my copyright to the file with the libc implementations (as those > were taken from LibcLib's patch). And possibly my signed-off-by but > I'll leave that to your criteria. > > I still don't see much point in the libfdt wrapping code. Benny says > it's due to EDK2 style, you say it's for stability/modularity reasons. > I personally don't see much point in writing whole wrappers due to > style, and libfdt is AIUI very much something that has been mostly > stable over time. In any case, do what you think is best. I'll trust > your judgement and I won't block this patch for it. > > So with all that addressed, Acked-by: Pedro Falcato > <pedro.falc...@gmail.com> > > Thank you, > Pedro -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103002): https://edk2.groups.io/g/devel/message/103002 Mute This Topic: https://groups.io/mt/98246918/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
