Re: [edk2-devel] [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Thanks for the cleanup: 166(+) 679(-). 2 minor comments: > UINTN > CreateIdentityMappingPageTables ( > + IN BOOLEAN Is32BitPageTable, [Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit is the trend, I don't like to say future is "FALSE". > + MapAttribute

Re: [edk2-devel] [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Tuesday, March 28, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Ni, Ray ; Wang, Jian > J > Subject: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX > > In IA32 code, r

Re: [edk2-devel] [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

> + MapAttribute.Uint64= 0; [Ray] Can you add "MapAttribute.Bits.ReadWrite = 0"? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102238): https://edk2.groups.io/g/devel/message/102238 Mute This Topic: https://groups.io/mt/97897987/216

Re: [edk2-devel] [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Ray, Thanks for the comments. I'll modify the code in next version patch set. Thanks, Dun -Original Message- From: Ni, Ray Sent: Friday, March 31, 2023 3:01 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Wang, Jian J Subject: RE: [PATCH 7/9] MdeModulePkg/DxeIpl:

Re: [edk2-devel] [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

Mike, What's your comment for this patch? PageTableLib is in UefiCpuPkg. DxeIpl requires PageTableLib for Ia32 and X64 versions. I prefer that we can move the pkg dependency rule discussion as a separate topic and only review the code logic in this patch series. Do you think that we can loosen

Re: [edk2-devel] [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

Sure, I'll add this line in next version patch. Thanks, Dun -Original Message- From: Ni, Ray Sent: Friday, March 31, 2023 3:05 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Wang, Jian J Subject: RE: [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

@Xu, Min M, can you check if Gerd's comment is valid? Gerd, This Bugzilla captures the same idea: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Originally from Laszlo. +@Liu, Zhiguang who will work on patch submission later. Thanks, Ray > -Original Message- > From: kra...@redhat.c

Re: [edk2-devel] [PATCH v2 0/2] SEV-SNP guest support fixes

Acked-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, March 30, 2023 3:36 PM > To: devel@edk2.groups.io; thomas.lenda...@amd.com > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Michael > Roth ; Ashish Kalra > Subject: Re: [edk2-devel] [PATCH v2 0/2] SEV-SNP gues

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

Hi Marvin, Thanks for the context. On Thu, 30 Mar 2023 at 23:54, Marvin Häuser wrote: > > Hi Ard, > > Sorry, I cannot preserve the CC list as the groups.io interface doesn't seem > to allow it. Can you please CC me on future revisions? > > This patch will badly corrupt binaries. I cannot cite

Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

On Fri, 31 Mar 2023 at 06:24, Ni, Ray wrote: > > Thanks for the change. > > But it doesn't highlight another impact due to this change: CET logic is > removed from the SEC/PEI version. No the ordinary SEC/PEI version does not have the CET logic - only the XCODE version does. > It's not an issue

Re: [edk2-devel] [PATCH v6 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

It's a bit wired that AMD version of SmmCpuFeaturesLib calls AMD version of SmmSmramSaveStateLib. The question naturally becomes: why not integrate the two lib implementations together to avoid creating the SmmSmramSaveStateLib library class? Because I cannot imagine AmdSmmCpuFeaturesLib calls t

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

Hi Gerd, On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > > From: Min M Xu > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4379 > > > > PlatformInitEmuVariableNvStore is called to initialize the > > EmuVariable

Re: [edk2-devel] [RFT PATCH v2 3/6] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

Thanks! Overall, the patch greatly simplifies the CpuExceptionHandlerLib. Even I sometimes am lost of which C/NASM contributes to which instance. With the enhanced commit log, Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Fri

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Gerd, Can you give a Reviewed-by/Acked-by for the patch series? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, March 31, 2023 3:25 PM > To: kra...@redhat.com; Xu, Min M ; Liu, Zhiguang > > Cc: devel@edk2.groups.io; Tom Lendacky > Subject: Re: [edk

Re: [edk2-devel] [RFT PATCH v2 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Remove needless runtime fixups

Hi Ray, Definitely - this is just an optimisation “while we’re at it“, nothing urgent. Best regards, Marvin > On 31. Mar 2023, at 07:09, Ni, Ray wrote: > >  > > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/Xcode5ExceptionH= > andlerAsm.nasm b/UefiCpuPkg/Library/CpuExceptionHand

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > Hi Gerd, > > On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > > On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > > > From: Min M Xu > > > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4379 > > > > > >

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

> On 31. Mar 2023, at 09:39, Ard Biesheuvel wrote: > Hi Marvin, > > Thanks for the context. > > > On Thu, 30 Mar 2023 at 23:54, Marvin Häuser wrote: >> >> Hi Ard, >> >> Sorry, I cannot preserve the CC list as the groups.io interface doesn't seem >> to allow it. Can you please CC me on fu

Re: [edk2-devel] [PATCH 1/1] ArmPkg/PlatformBootManagerLib: Add path to boot UEFI Shell over UiApp

Hello Ard, On 2/13/23 09:39, Pierre Gondois wrote: Hello Ard, On 2/9/23 17:57, Ard Biesheuvel wrote: On Tue, 7 Feb 2023 at 10:07, wrote: From: Pierre Gondois The UEFI Shell is a non-active boot option, at the opposite of UiApp. If no valid boot option is found, UiApp is selected. UiApp re

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

On Fri, 31 Mar 2023 at 10:29, Marvin Häuser wrote: > > > > On 31. Mar 2023, at 09:39, Ard Biesheuvel wrote: > > Hi Marvin, > > > > Thanks for the context. > > > > > > On Thu, 30 Mar 2023 at 23:54, Marvin Häuser wrote: > >> > >> Hi Ard, > >> > >> Sorry, I cannot preserve the CC list as the group

[edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

We have a special version of CpuExceptionHandlerLib for XCODE5, whose linker (LLD) does not permit absolute symbol references in read-only sections. Instead of fixing this up at runtime for all toolchains (which is done by writing the fixed up values to the .text section, which we'd prefer to avoi

[edk2-devel] [RFT PATCH v3 1/5] BaseTools/tools_def CLANGDWARF: Permit text relocations

We rely on PIE executables to get the codegen that is suitable for PE/COFF conversion where the resulting executables can be loaded anywhere in the address space. However, ELF linkers may default to disallowing text relocations in PIE executables, as this would require text segments to be updated

[edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

Currently, we use the non-Xcode5 version of ExceptionHandlerAsm.nasm only for the SEC and PEI phases, and this version was not compatible with the XCODE or LLD linkers, which do not permit absolute relocations in read-only sections. Given that SEC and PEI code typically executes in place from flas

[edk2-devel] [RFT PATCH v3 3/5] UefiCpuPkg/CpuExceptionHandlerLib: Make runtime fixups XCODE-only

The CPU exception handler library code was rewritten at some point to populate the vector code templates with absolute references at runtime, given that the XCODE linker does not permit absolute references in executable code when creating PIE executables. This is rather unfortunate, as this preven

[edk2-devel] [RFT PATCH v3 4/5] OvmfPkg: Drop special Xcode5 version of exception handler library

The generic and XCODE5 versions of this library are now identical, so drop the special case. The library will be removed entirely in a subsequent patch. Signed-off-by: Ard Biesheuvel Acked-by: Jiewen Yao --- OvmfPkg/AmdSev/AmdSevX64.dsc | 4 OvmfPkg/CloudHv/CloudHvX64.dsc | 4 O

[edk2-devel] [RFT PATCH v3 5/5] UefiCpuPkg/CpuExceptionHandlerLib: Drop special XCODE5 version

This library is no longer used or needed, so let's remove it. Signed-off-by: Ard Biesheuvel Reviewed-by: Ray Ni --- UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf | 67 UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHa

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

Hi, > > - modify the SecPei version of CpuExceptionHandlerLib to put the > > vector templates in .data, as I proposed before. This works around the > > issue, and given that SEC/PEI is assumed to be read-only anyway (as it > > may execute in place from flash) and does not use page alignment for

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

On Fri, Mar 31, 2023 at 08:02:00AM +, Ni, Ray wrote: > Gerd, > Can you give a Reviewed-by/Acked-by for the patch series? > > This Bugzilla captures the same idea: > > https://bugzilla.tianocore.org/show_bug.cgi?id=3394 Oh, the bug lists even more places which care about the physical address w

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

> On 31. Mar 2023, at 10:59, Ard Biesheuvel wrote: > > On Fri, 31 Mar 2023 at 10:29, Marvin Häuser wrote: >> >> On 31. Mar 2023, at 09:39, Ard Biesheuvel wrote: >>> Hi Marvin, >>> >>> Thanks for the context. >>> >>> >>> On Thu, 30 Mar 2023 at 23:54, Marvin Häuser wrote: >>>

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

On Fri, 31 Mar 2023 at 11:27, Marvin Häuser wrote: > > > > On 31. Mar 2023, at 10:59, Ard Biesheuvel wrote: > > > > On Fri, 31 Mar 2023 at 10:29, Marvin Häuser wrote: > >> > >> > On 31. Mar 2023, at 09:39, Ard Biesheuvel wrote: > >>> Hi Marvin, > >>> > >>> Thanks for the context. > >>> >

[edk2-devel] [Patch V2 1/8] EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in EmulatorPkg.dsc. Signed-off-by: Dun Tan Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index b44435d7e6

[edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl

In this V2 patch set: 1.Remove the unneeded patch for ArmVirtPkg 2.In this patch 'Create page table by CpuPageTableLib', change the input parameter name from Is32BitPageTable to Is64BitPageTable and add a line of "MapAttribute.Bits.Present = 0" before set a range to non-present. 3.In this patch '

[edk2-devel] [Patch V2 2/8] IntelFsp2Pkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in QemuFspPkg.dsc of IntelFsp2Pkg. Signed-off-by: Dun Tan Reviewed-by: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ray Ni --- IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Inte

[edk2-devel] [Patch V2 3/8] MdeModulePkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in MdeModulePkg.dsc. Signed-off-by: Dun Tan Cc: Jian J Wang Cc: Liming Gao Cc: Ray Ni --- MdeModulePkg/MdeModulePkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModuleP

[edk2-devel] [Patch V2 4/8] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file

Add CpuPageTableLib instance required by DxeIpl in corresponding DSC files of OvmfPkg. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Ray Ni --- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/Bhyve/BhyveX64.dsc | 3 ++- OvmfPkg/CloudHv/C

[edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass DependencyCheck since DxeIpl in MdeModulePkg needs to consume CpuPageTableLib in UefiCpuPkg. Signed-off-by: Dun Tan Cc: Liming Gao Cc: Ray Ni Cc: Jian J Wang --- MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++-- 1 file changed, 3 insert

[edk2-devel] [Patch V2 6/8] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Modify CreateIdentityMappingPageTables() to create page table based on CpuPageTableLib in DxeIpl module. This function can be used to create both IA32 PAE paging and long mode 4-level, 5-level paging structure. With the PageTableMap() API in the CpuPageTableLib, we can remove the complicated page t

[edk2-devel] [Patch V2 7/8] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX

In IA32 code, remove the duplicated code to enable NX. In the previous patch, IA32 code also uses the new CreateIdentityMappingPageTables() to create PAE page table. This function calls EnableExecuteDisableBit if needed. Signed-off-by: Dun Tan Cc: Dandan Bi Cc: Liming Gao Reviewed-by: Ray Ni C

[edk2-devel] [Patch V2 8/8] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

Code refinement to the code to set page table as RO in DxeIpl module. Set all page table pools as ReadOnly by calling PageTableMap() in CpuPageTableLib multiple times instead of searching each page table pool address in page table layer by layer. Also, this commit solve the issue that original SetP

Re: [edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl

Hi Tom, Reccentlly I sent this patch set to change DxeIpl code to use CpuPageTableLib to create page table. I have done some test on Intel CPU to make sure that the page table created by DxeIpl before the change is the same as the page table created by DxeIpl after the change. But there was a r

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

Ard, Thanks for the detailed commit messages. That really helps me to understand why XCODE version was needed. However, I feel it would be great if you can "highlight" what are changed by this patch. The following is just an example. You can reword as you like. 1. Change for non-XCODE SecPeiCpu

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

By the way, which ("%" or "#") should be used for def check in NASM? I thought we need to use "%" but your patch uses "#". > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, March 31, 2023 5:56 PM > To: Ard Biesheuvel ; devel@edk2.groups.io > Cc: Andrew

[edk2-devel] [PATCH v2 0/2] WIP: Enable CMO support for RiscV64

Current implementation for cache management (instruction/data flush/invd) depends on fence.i instruction. All RV platforms may not use the same method for cache management. Instead RV defines CMO Cache management operations specification which consits of cbo.x instructions for cache management. How

[edk2-devel] [PATCH v2 1/2] WIP: MdePkg/RiscVCMOCacheMaintenanceLib:Enable RISCV CMO

Adding code to support Cache Management Operations (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs Notes: 1. CMO only supports block based Operations. Meaning complete cache flush/invd/clean Operations are not available 2. Current implementation uses ifence instructions but it maybe pl

[edk2-devel] [PATCH v2 2/2] OvmfPkg/RiscVVirt: Enable CMO support

Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Sunil V L Cc: Andrei Warkentin Signed-off-by: Dhaval Sharma Add support for Cache Management Operations by conditionally adding CMO library. --- Notes: v2: - Updated RiscVCMOCacheManagementLib as a separate C

Re: [edk2-devel] [RFT PATCH v3 3/5] UefiCpuPkg/CpuExceptionHandlerLib: Make runtime fixups XCODE-only

I like this approach that allows "relocation entry guided" fixups done by either GenFv or PE loader. Only concern is which to use between "#" and "%". > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 5:15 PM > To: devel@edk

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

Ard, What does "-read_only_relocs suppress" control? Linker doesn't produce relocation entries that modifies .text section silently so the final .text just cannot run at all? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

On Fri, 31 Mar 2023 at 11:56, Ni, Ray wrote: > > Ard, > Thanks for the detailed commit messages. That really helps me to understand > why XCODE version > was needed. > > However, I feel it would be great if you can "highlight" what are changed by > this patch. > The following is just an example.

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

On Fri, 31 Mar 2023 at 11:58, Ni, Ray wrote: > > By the way, which ("%" or "#") should be used for def check in NASM? > I thought we need to use "%" but your patch uses "#". > The build rule for NASM files is Trim --asm-file -o ${d_path}(+)${s_base}.i -i $(INC_LIST) ${src} "$(PP)

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

On Fri, 31 Mar 2023 at 12:09, Ni, Ray wrote: > > Ard, > What does "-read_only_relocs suppress" control? > Linker doesn't produce relocation entries that modifies .text section silently > so the final .text just cannot run at all? > Yeah, good question. So this is why I dropped this now - it doesn

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

So, for nasm advanced macros (rep), use "%". Otherwise, either is fine. > -Original Message- > From: Ard Biesheuvel > Sent: Friday, March 31, 2023 6:14 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Andrew Fish ; Kinney, > Michael D ; Liu, Zhiguang > ; Rebecca Cran ; Tom > Lendacky ; Marv

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

On Fri, 31 Mar 2023 at 12:16, Ni, Ray wrote: > > So, for nasm advanced macros (rep), use "%". Otherwise, either is fine. > Exactly. These are preprocessor macros, not nasm macros. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102286):

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 6:13 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Andrew Fish ; Kinney, Michael D > ; Liu, Zhiguang ; > Rebecca Cran ; Tom Lendacky > ; Marvin Häuser > Subject: Re: [edk2-deve

Re: [edk2-devel] [RFT PATCH v3 3/5] UefiCpuPkg/CpuExceptionHandlerLib: Make runtime fixups XCODE-only

Ok I see that the macro is added to PP flags. I thought it's added to NASM build flags. Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 5:15 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ;

Re: [edk2-devel] [Patch V2 1/8] EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray > Subject: [Patch V2 1/8] EmulatorPkg: Add CpuPageTableLib required by > DxeIpl in DSC > > Add CpuPageTableLib instance required by Dx

Re: [edk2-devel] [Patch V2 6/8] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Ni, Ray ; Wang, Jian J > > Subject: [Patch V2 6/8] MdeModulePkg/DxeIpl: Create page table by > CpuPageTableLib > > Modify Creat

Re: [edk2-devel] [Patch V2 8/8] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Friday, March 31, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Ni, Ray ; Wang, Jian J > > Subject: [Patch V2 8/8] MdeModulePkg/DxeIpl: Refinement to the code to > set PageTable as RO > > Cod

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

> On 31. Mar 2023, at 11:36, Ard Biesheuvel wrote: > > On Fri, 31 Mar 2023 at 11:27, Marvin Häuser wrote: >> >> On 31. Mar 2023, at 10:59, Ard Biesheuvel wrote: >>> >>> On Fri, 31 Mar 2023 at 10:29, Marvin Häuser wrote: >> On 31. Mar 2023, at 09:39, Ard Biesheuvel w

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

Hi Ray, > On 31. Mar 2023, at 12:09, Ni, Ray wrote: > > Ard, > What does "-read_only_relocs suppress" control? It controls whether relocs that target read-only segments yield a build error or not. I think lld uses “-z notext”. > Linker doesn't produce relocation entries that modifies .text s

Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

On Fri, 31 Mar 2023 at 12:19, Ni, Ray wrote: > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Friday, March 31, 2023 6:13 PM > > To: devel@edk2.groups.io; Ni, Ray > > Cc: Andrew Fish ; Kinney, Michael D > > ; Liu, Zhiguang ; > > Rebecc

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

Hi, > > However, those issues might have been fixed and it’s not impossible > > Vitaly will give it another try eventually. In any case, I think our > > downstream variant of XCODE5 doesn’t require any level of special > > care, so it doesn’t really matter to us. > > > > (Another thing to consid

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Liming, Platform maintainers can decide whether or not they want to combat *binary corruption*? Excuse me, but what the bloody hell? This needs a root cause analysis for which part of the stack silently borks us and not an “oh, if something fails, well, copy and paste this workaround… maybe”. I

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

On Fri, 31 Mar 2023 at 12:53, Gerd Hoffmann wrote: > > Hi, > > > > However, those issues might have been fixed and it’s not impossible > > > Vitaly will give it another try eventually. In any case, I think our > > > downstream variant of XCODE5 doesn’t require any level of special > > > care, so

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

Hi Gerd, > On 31. Mar 2023, at 12:53, Gerd Hoffmann wrote: > >  Hi, > >>> However, those issues might have been fixed and it’s not impossible >>> Vitaly will give it another try eventually. In any case, I think our >>> downstream variant of XCODE5 doesn’t require any level of special >>> care

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

On Fri, 31 Mar 2023 at 12:41, Marvin Häuser wrote: > > Hi Ray, > > > On 31. Mar 2023, at 12:09, Ni, Ray wrote: > > > > Ard, > > What does "-read_only_relocs suppress" control? > > It controls whether relocs that target read-only segments yield a build error > or not. I think lld uses “-z notext

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

> On 31. Mar 2023, at 13:03, Ard Biesheuvel wrote: > > On Fri, 31 Mar 2023 at 12:41, Marvin Häuser wrote: >> >> Hi Ray, >> On 31. Mar 2023, at 12:09, Ni, Ray wrote: >>> >>> Ard, >>> What does "-read_only_relocs suppress" control? >> >> It controls whether relocs that target read-on

Re: [edk2-devel] [RESEND v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

On Thu, Mar 30, 2023 at 3:48 PM Dhaval Sharma wrote: > Hi Oliver, > when is this patch expected to get merged? I need to use CI with GCC12 in > order to get my changes through for this > > https://edk2.groups.io/g/devel/message/101795?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Ccm

Re: [edk2-devel] [RESEND v1 0/1] CI: Use Fedora 37 / GCC 12 for Linux jobs

On Tue, Mar 14, 2023 at 04:21:13PM +0100, Oliver Steffen wrote: > Switch the CI (Linux) to use GCC 12 providied by a new Fedora 37 based > container image. > > New container image: https://github.com/tianocore/containers/pull/60 > > Test PR: https://github.com/tianocore/edk2/pull/4108 PING CI ma

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

Hi, > > Getting down to one libc wrapper would be great. Do you want to provide a > > proposed > > implementation? That could be handled as a separate task. > > I would like it if we could stop contributing to that problem. We very > much *know* there is a problem with both libc fragments an

Re: [edk2-devel] [Patch V2 4/8] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file

On Fri, Mar 31, 2023 at 05:33:40PM +0800, duntan wrote: > Add CpuPageTableLib instance required by DxeIpl in corresponding > DSC files of OvmfPkg. > > Signed-off-by: Dun Tan > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Ray Ni Acked-by: Gerd Hoffmann

Re: [edk2-devel] [RFC PATCH 1/1] MdePkg: Add a libc implementation

Hi, > Work in progress, does not support Windows targets (CLANGPDB and MSVC) > just yet. The header files CryptoPkg has for openssl would be probably a good starting point (instead of starting over from scratch ...). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

On Thu, Mar 30, 2023 at 22:50:18 +0100, Pedro Falcato wrote: > On Thu, Mar 30, 2023 at 6:13 PM Benny Lin wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 > > Add FDT support in EDK2 by submodule 3rd party libfdt > > (https://github.com/devicetree-org/pylibfdt/tree/main/libfd

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

On Fri, Mar 31, 2023 at 00:26:37 +0100, Pedro Falcato wrote: > We also have a whole libc implementation in edk2-libc that seems to be > permanently gathering dust until Intel touches it for Python purposes > from time to time. So between crypto, libfdt, etc, could we try to > unify things here a bi

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

On Fri, Mar 31, 2023 at 12:39 PM Gerd Hoffmann wrote: > > Hi, > > > > Getting down to one libc wrapper would be great. Do you want to provide > > > a proposed > > > implementation? That could be handled as a separate task. > > > > I would like it if we could stop contributing to that problem.

Re: [edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: migration of edk2module from chipsec repo

Reviewed-by: Jayaprakash N Merged the Patch by updating trailing spaces and Tabs. -Original Message- From: Kadapathri, Ajay Sent: Thursday, March 30, 2023 11:27 AM To: devel@edk2.groups.io Cc: Rebecca Cran ; Kinney, Michael D ; Jayaprakash, N Subject: [edk2-libc Patch 1/1] Python/Pyt

[edk2-devel] [PATCH edk2-basetools v2 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

Changes in v2: Generate Makefiles with both BUILD_CFLAGS and CFLAGS for compatibility until everyone's moved to a version of edk2 that expects CFLAGS. Rebecca Cran (1): Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change edk2basetools/Workspace/DscBuildData.py | 6 +- 1 file chan

[edk2-devel] [PATCH edk2-basetools v2 1/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change

In order to support building BaseTools using non-default compilers, a change is being made in the edk2 BaseTools directory to remove the 'BUILD_' prefix to CC, CXX, CFLAGS etc. so developers can for example run 'make CC=clang CXX=clang++' to build using clang. Update DscBuildData.py to generate Ma

Re: [edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl

On 3/31/23 04:41, Tan, Dun wrote: Hi Tom, Reccentlly I sent this patch set to change DxeIpl code to use CpuPageTableLib to create page table. I have done some test on Intel CPU to make sure that the page table created by DxeIpl before the change is the same as the page table created by DxeIpl

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > Häuser > Sent: Friday, March 31, 2023 7:10 PM > To: Ard Biesheuvel > Cc: Ni, Ray ; devel@edk2.groups.io; Andrew Fish > ; Kinney, Michael D ; Liu, > Zhiguang ; Rebecca Cran ; > Tom Lendacky > Subject: Re: [edk2-deve

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Why ELF header overflows into .text section? > -Original Message- > From: Patrick Rudolph > Sent: Friday, March 17, 2023 10:06 PM > Cc: devel@edk2.groups.io; Dong, Guo ; Guo, Gua > ; Lu, James ; Ni, Ray > ; mhaeu...@posteo.de; a...@kernel.org > Subject: [PATCH 2/3] BaseTools/Conf/tools_de

Re: [edk2-devel] [RFT PATCH v3 0/5] UefiCpuPkg, OvmfPkg: Simplify CpuExceptionHandlerLib

> On 31. Mar 2023, at 16:39, Ni, Ray wrote: > > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Marvin >> Häuser >> Sent: Friday, March 31, 2023 7:10 PM >> To: Ard Biesheuvel >> Cc: Ni, Ray ; devel@edk2.groups.io; Andrew Fish >> ; Kinney, Michael D ; Liu, >> Zhigua

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

On Fri, Mar 31, 2023 at 10:25:09AM +0200, Gerd Hoffmann wrote: > On Fri, Mar 31, 2023 at 03:59:56PM +0800, joeyli wrote: > > Hi Gerd, > > > > On Thu, Mar 30, 2023 at 09:50:53AM +0200, Gerd Hoffmann wrote: > > > On Wed, Mar 29, 2023 at 01:23:10PM +0800, Min Xu wrote: > > > > From: Min M Xu > > > >

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

On 3/31/23 2:29 AM, Marvin Häuser wrote: I agree if there’s an actual plan on doing that. We depend on XCODE5 downstream, but I think it would literally be easier for us if the upstream version was dropped than rebasing against hacks that our slightly modded variant does not require. Cc Andre

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

> On 31. Mar 2023, at 16:41, Ni, Ray wrote: > > Why ELF header overflows into .text section? That's a good question, isn't it? :) >From what I can see, these binaries don't pass post-processing like GenFw or >such. GCC (and I think thus CLANGDWARF?) gets an extra objcopy step as part of >lin

[edk2-devel] PR fails due to OVMF time out

Hi, I found several of my PRs cannot pass the CI due to OVMF boot timeout. e.g.: Mktme fix by niruiyu * Pull Request #4072 * tianocore/edk2 (github.com) I also one PR from Ard (X64 text reloc fixes by ardbiesheuvel * Pull Request #4216 * tianocore/edk

Re: [edk2-devel] [RFT PATCH v2 1/6] BaseTools/tools_def XCODE: Link X64 with -read_only_relocs suppress

> On 31. Mar 2023, at 16:58, Rebecca Cran wrote: > > On 3/31/23 2:29 AM, Marvin Häuser wrote: >> I agree if there’s an actual plan on doing that. We depend on XCODE5 >> downstream, but I think it would literally be easier for us if the upstream >> version was dropped than rebasing against hac

[edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

From: Michael Kubacki This is causing excessive boot times in the VS2019 IA32/X64 Full run to shell tasks (> 2 minutes) and blocking all edk2 CI. This patch removes the change so it can be root caused separately without blocking other patches unrelated to OVMF. Reverts f92a9dce10281c103b04d6b38

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

On Fri, 31 Mar 2023 at 18:11, Michael Kubacki wrote: > > From: Michael Kubacki > > This is causing excessive boot times in the VS2019 IA32/X64 Full > run to shell tasks (> 2 minutes) and blocking all edk2 CI. > > This patch removes the change so it can be root caused separately > without blocking

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Friday, March 31, 2023 9:11 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > ; Gerd Hoffmann ; Kinney, > Michael D > Subject: [e

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

Anyone knows why the job status is "queued" for all the CI jobs? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Saturday, April 1, 2023 12:13 AM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Just

[edk2-devel] [PATCH] add ArmCpuInfo EFI application

App goes through ID_AA64*_EL1 system registers and decode their values. First version which does not use much of current AArch64 support code present in EDK2. Written to check what data is there and what can be done with it. --- .../Application/ArmCpuInfo/ArmCpuInfo.c | 2277 +++

[edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni --- .../UnitTest/CpuPageTableLibUnitTestHost.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Saturday, April 1, 2023 2:22 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases > > The random test cases just run for too long that may cause timeout >

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/CI: Revert SMP mode

There were a couple issues that lengthened the execution time of build agents and a number of changes were queued around the same time a few hours ago leading to longer queue times. I know you're trying to reduce the UefiCpuPkg unit test time in your patch, that's currently causing UefiCpuPkg

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

Reviewed-by: Michael Kubacki On 3/31/2023 2:22 PM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni --- .../UnitTest/CpuPageTableLibUnitTestHost.c | 10 +- 1 file changed, 5 inserti

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

Thanks Ray.  Lets discuss this style of testing next week at the tools and CI meeting. Reviewed-by: Sean Brogan On 3/31/2023 11:22 AM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni --- .../UnitTe

Re: [edk2-devel] PR fails due to OVMF time out

On Fri, Mar 31, 2023 at 03:00:37PM +, Ni, Ray wrote: > Hi, > I found several of my PRs cannot pass the CI due to OVMF boot timeout. > e.g.: Mktme fix by niruiyu * Pull Request #4072 * tianocore/edk2 > (github.com) > > I also one PR from Ard (X64 te

Re: [edk2-devel] [PATCH v3 1/3] Platform/AMD: Adds MinBoardPkg to support MinPlatformPkg

Regardless of directory path I would suggest that all "Packages" have a unique and descriptive name.  MinBoardPkg doesn't meet that suggestion.   If/when the edk2 CI tools run I would expect problems/odd behavior if two packages collide in naming. Thanks Sean On 3/22/2023 11:13 PM, Abdul L

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

I've been wondering, is it possible to increase the parallelism or add more resources to the CI runner pool? -- Rebecca Cran On 3/31/23 12:22 PM, Ni, Ray wrote: The random test cases just run for too long that may cause timeout in CI test. Disable them for now. Signed-off-by: Ray Ni ---

[edk2-devel] [PATCH v3] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391 FSP should support the scenario that CPU microcode already loaded before calling LoadMicrocodeDefault(), in this case it should return directly without spending more time. Also the LoadMicrocodeDefault() should only attempt to load one versi

Re: [edk2-devel] [PATCH] UefiCpuPkg/Test: Disable random test cases

I'm not sure about the availability of more resources but something like merge queue might be able to help. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue This presentation has an overview - http

  1   2   >