Thanks! Overall, the patch greatly simplifies the CpuExceptionHandlerLib. Even I sometimes am lost of which C/NASM contributes to which instance.
With the enhanced commit log, Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 3:41 PM > To: devel@edk2.groups.io; Ni, Ray <ray...@intel.com> > Cc: Andrew Fish <af...@apple.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com>; > Rebecca Cran <rebe...@bsdio.com>; Tom Lendacky > <thomas.lenda...@amd.com> > Subject: Re: [edk2-devel] [RFT PATCH v2 3/6] > UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version > > On Fri, 31 Mar 2023 at 06:24, Ni, Ray <ray...@intel.com> wrote: > > > > Thanks for the change. > > > > But it doesn't highlight another impact due to this change: CET logic is > removed from the SEC/PEI version. > > No the ordinary SEC/PEI version does not have the CET logic - only the > XCODE version does. > > > It's not an issue because CET is only enabled in SMM environment today. > > But better to highlight the impact in the commit message, and explicitly say > that limitation in the SecPeiCpuExceptionHandlerLib.inf file. > > > > I am going to have to revisit this anyway, but I will put some more > context about this in the commit log. > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102248): https://edk2.groups.io/g/devel/message/102248 Mute This Topic: https://groups.io/mt/97960765/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
