So, for nasm advanced macros (rep), use "%". Otherwise, either is fine.
> -----Original Message-----
> From: Ard Biesheuvel <a...@kernel.org>
> Sent: Friday, March 31, 2023 6:14 PM
> To: Ni, Ray <ray...@intel.com>
> Cc: devel@edk2.groups.io; Andrew Fish <af...@apple.com>; Kinney,
> Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang
> <zhiguang....@intel.com>; Rebecca Cran <rebe...@bsdio.com>; Tom
> Lendacky <thomas.lenda...@amd.com>; Marvin Häuser
> <mhaeu...@posteo.de>
> Subject: Re: [edk2-devel] [RFT PATCH v3 2/5]
> UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version
>
> On Fri, 31 Mar 2023 at 11:58, Ni, Ray <ray...@intel.com> wrote:
> >
> > By the way, which ("%" or "#") should be used for def check in NASM?
> > I thought we need to use "%" but your patch uses "#".
> >
>
> The build rule for NASM files is
>
> Trim --asm-file -o ${d_path}(+)${s_base}.i -i $(INC_LIST) ${src}
> "$(PP)" $(DEPS_FLAGS) $(PP_FLAGS) $(INC) ${src} >
> ${d_path}(+)${s_base}.ii
> Trim --trim-long --source-code -o ${d_path}(+)${s_base}.iii
> ${d_path}(+)${s_base}.ii
> "$(NASM)" -I${s_path}(+) $(NASM_INC) $(NASM_FLAGS) -o $dst
> ${d_path}(+)${s_base}.iii
>
> So the preprocessor $(PP) is executed first, which takes care of the #ifdefs
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102285): https://edk2.groups.io/g/devel/message/102285
Mute This Topic: https://groups.io/mt/97969650/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
