> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > Biesheuvel > Sent: Friday, March 31, 2023 6:13 PM > To: devel@edk2.groups.io; Ni, Ray <ray...@intel.com> > Cc: Andrew Fish <af...@apple.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com>; > Rebecca Cran <rebe...@bsdio.com>; Tom Lendacky > <thomas.lenda...@amd.com>; Marvin Häuser <mhaeu...@posteo.de> > Subject: Re: [edk2-devel] [RFT PATCH v3 2/5] > UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version > > On Fri, 31 Mar 2023 at 11:56, Ni, Ray <ray...@intel.com> wrote: > > > > Ard, > > Thanks for the detailed commit messages. That really helps me to > understand why XCODE version > > was needed. > > > > However, I feel it would be great if you can "highlight" what are changed by > this patch. > > The following is just an example. You can reword as you like. > > > > 1. Change for non-XCODE SecPeiCpuExceptionHandlerLib: > > * Use SecPeiExceptionHandlerAsm.nasm (renamed from > ExceptionHandlerAsm.nasm) > > * Removed some unnecessary absolute references > > * (32 IDT stubs are still in .text.) > > Indeed > > > 2. Change for XCODE SecPeiCpuExceptionHandlerLib: > > * Use SecPeiExceptionHandlerAsm.nasm instead of > Xcode5ExceptionHandlerAsm.nasm > > * CET logic is not in SecPeiExceptionHandlerAsm.nasm (but aligns to non- > XCODE lib instance) > > No, this does not actually change in this patch. The CET logic does > not exist in the generic SecPei version either before or after this > patch.
Because of this patch, CET logic is removed from XCODE SecPeiCpuExceptionHandlerLib. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102287): https://edk2.groups.io/g/devel/message/102287 Mute This Topic: https://groups.io/mt/97969650/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
