Thanks https://github.com/tianocore/edk2/pull/10760 is updated.
I don't have a strong need for it to make the stable tag. I have a local
solution that can be used in the meantime.
On 2/14/2025 5:48 AM, Leif Lindholm wrote:
On Fri, 14 Feb 2025 at 01:54, Michael Kubacki
wrote:
That w
That worked. Let me know what you'd like to do with
https://github.com/tianocore/edk2/pull/10760.
---
Before (original code)
...ModuleEntryPoint.:58:12: error: immediate must be an integer in
range [0, 65535].
movz x9, (-1) >> 48, lsl #48 ; movk x9, ((-1) >> 32) & 0x, lsl #32 ;
mov
e new names. Understanding this
is tangential to a change dropping IA32 VS EmulatorPkg in the pipeline
but that could be considered as well and I could add that if desired.
Thanks,
Michael
On 12/18/2024 3:44 PM, Michael Kubacki wrote:
Hi Mike,
I've also had trouble reproducing it co
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of
Michael
Kubacki via groups.io
Sent: Wednesday, December 18, 2024 8:48 AM
To: devel@edk2.groups.io; o...@linux.microsoft.com;
leif.lindh...@oss.qualcomm.com; Kinney, Michael D
Cc: Oliver Smith-Denny
Subject: Re: [edk2-devel] CI blo
t have permission to do so, it has to be done by an admin, Mike Kinney
or Michael Kubacki I believe will do it. The plan is to also change the
name of the GCC5 pipeline (Gerd requested this) and instead have more
generically named pipelines so when they are updated in the future we
don't have th
For simplicity of testing on the fork, I'd just create a PAT in your
repo with the necessary permissions and use that as the secret there.
Then, substitute it with the app secret in the edk2-platforms PR.
You can test almost everything that way except the app token generation
itself. But, that
On 8/14/2024 11:49 PM, Michael D Kinney wrote:
-Original Message-
From: Michael Kubacki
Sent: Wednesday, August 14, 2024 7:30 PM
To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Kinney, Michael D
; r...@edk2.groups.io
Cc: 'Andrew Fish' ; 'Leif Lindholm'
; '
Hi Liming,
I apologize for the delayed response.
Thanks,
Michael
On 8/6/2024 1:34 AM, gaoliming via groups.io wrote:
Michael:
Thanks for your great effort. This is a good direction to consolidate code
and issue together. My feedbacks are below:
1. BugZilla supports code first process. Wha
I made updates to the RFC on the GitHub Discussion page with rev tracking.
https://github.com/tianocore/edk2/discussions/5926
On 7/31/2024 1:56 PM, Kinney, Michael D wrote:
-Original Message-
From: Michael Kubacki
Sent: Wednesday, July 31, 2024 7:42 AM
To: devel@edk2.groups.io
Proposed Process
1. Create GitHub issue templates for the following categories that
include basic automation of validation for input.
* Bug Report
* Fields:
* Title
* Packages Affected
Would this be free form text or a multi select list of possib
TLDR: Pipelines should be relatively faster soon
---
As you know, PR gates can take a long time in edk2. While there are
various improvements that could be made, I want to highlight a change in
the queue now, it's impact, and how it will help.
Pipelines are composed of jobs which are compose
TLDR: If CodeQL failed in a PR. Rebase your PR branch on master and push.
---
edk2 uses an application called the CodeQL CLI to run CodeQL in CI builds.
https://github.com/github/codeql-cli-binaries/
A fixed version of the application is used to allow controlled updates
where the version is t
It looks like the permissions will need adjusted. That will come in a
follow up change.
On 7/24/2024 10:35 PM, Michael Kubacki wrote:
A change was just pushed to edk2 to automatically add reviewers to pull
request based on those listed in Maintainers.txt.
For more details and in case of any
A change was just pushed to edk2 to automatically add reviewers to pull
request based on those listed in Maintainers.txt.
For more details and in case of any issues, I put some information on
this wiki page:
https://github.com/tianocore/tianocore.github.io/wiki/Automatic-Pull-Request-Reviewer
Hello,
A topic over the last few weeks in the TianoCore Tools & CI meeting has
been establishing a transition from Bugzilla to GitHub issues. I've
drafted the following RFC to help explain the rationale and a proposed
process to do so.
I think it is easier to read with formatting, so I've pl
, July 17, 2024 10:55 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V ; S,
Ashraf Ali ; Lautner, Kenneth
Subject: [edk2-platforms][PATCH v1 1/2] IntelSiliconPkg: Compiler and linker
fixes
From: Michael Kubacki
Some code is currently not being built in the package. This fixes GCC
From: Michael Kubacki
Adds libraries and modules missing from the [Components] section of
IntelSiliconPkg.dsc.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Ashraf Ali S
Signed-off-by: Michael Kubacki
Reviewed-by: S, Ashraf Ali
---
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 9
From: Michael Kubacki
Some code is currently not being built in the package. This fixes
GCC compiler errors and MSVC linker failures in the code so the
package can build with these modules included.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Ashraf Ali S
Co-authored-by: Ken Lautner
Signed-off
From: Michael Kubacki
Some libraries and modules are missing from the build.
The first patch fixes compiler and linker failures. The second patch
adds the missing components to IntelSiliconPkg.dsc.
A PR with these changes is available here:
https://github.com/tianocore/edk2-platforms/pull/171
From: Michael Kubacki
Adds libraries and modules missing from the [Components] section of
IntelSiliconPkg.dsc.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Ashraf Ali S
Signed-off-by: Michael Kubacki
---
Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 9 +
1 file changed, 9
From: Michael Kubacki
Some code is currently not being built in the package. This fixes
GCC compiler errors and MSVC linker failures in the code so the
package can build with these modules included.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Cc: Ashraf Ali S
Co-authored-by: Ken Lautner
Signed-off
From: Michael Kubacki
Some libraries and modules are missing from the build.
The first patch fixes compiler and linker failures. The second patch
adds the missing components to IntelSiliconPkg.dsc.
A PR with these changes is available here:
https://github.com/tianocore/edk2-platforms/pull/171
The tweaks look good to me.
Thanks,
Michael
On 7/9/2024 11:03 AM, Leif Lindholm wrote:
Hi Michael,
On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote:
Hi Leif,
Thanks for raising this. The label was intended to be set from the PR
template which has an explanation:
https
Hi Leif,
Thanks for raising this. The label was intended to be set from the PR
template which has an explanation:
https://github.com/tianocore/edk2/blob/master/.github/pull_request_template.md
If the breaking change box is checked, it will be added automatically.
I added a description in Git
Hi Rebecca,
I'm covering hosting for the meeting today. I've created a discussion
with your agenda topics here
https://github.com/tianocore/edk2/discussions/5818.
Thanks,
Michael
On 6/23/2024 1:39 PM, Rebecca Cran wrote:
Add edk2-devel
On 6/23/24 11:38 AM, Rebecca Cran wrote:
I have two i
t the latest (incompatible) queries.
https://github.com/tianocore/edk2/pull/5720
On 5/20/2024 9:40 PM, Michael Kubacki wrote:
Just wanted to send a reminder that I recommend
https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for
those that are currently trying to test changes.
T
@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: Wednesday, May 29, 2024 5:51 PM
To: Kinney, Michael D ; devel@edk2.groups.io;
Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
I've updated the wiki process to clarify that mainta
he list of future enhancements when resources are
available to help. We need to focus on a process that works
until those automations can be deployed and supported.
Mike
-Original Message-----
From: Michael Kubacki
Sent: Wednesday, May 29, 2024 12:25 PM
To: devel@edk2.groups.io; Kinney,
Since we already reached agreement in libspdm to move its cmocka
submodule to the gitlab mirror in
https://github.com/DMTF/libspdm/issues/2707 and that was merged in
https://github.com/tianocore/edk2/pull/5697.
I'd like to suggest we go with option 2 as well. This is impacting our
ability to
Mike,
I agree that automatically adding reviewers would be helpful.
Do you think we could add a CODEOWNERS file now to assist with this?
Benefits being:
1. CODEOWNERS is low overhead in that GitHub already supports it.
2. We do not need to require CODEOWNER enforcement yet. We can simply
use
roject for this at
https://github.com/orgs/tianocore/projects/5 which it looks like Michael
Kubacki created last year. I suspect it's obsolete though, since it
looks like the tasks haven't been updated recently.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
We did not want to clone openssl twice.
I though stuart config specifies which submodules to clone. Can’t we skip
all the submodules within libspdm to fix CI?
Can't devs choose to not use --recursive?
Mike
-Original Message-----
From: Michael Kubacki
Sent: Wednesday, May 22, 202
n
libspdm.
Mike
-Original Message-----
From: Michael Kubacki
Sent: Wednesday, May 22, 2024 1:40 PM
To: devel@edk2.groups.io; Yao, Jiewen
Cc: Kinney, Michael D
Subject: libspdm Breaking Builds
Recently, the libspdm submodule was added to SecurityPkg
(SecurityPkg/DeviceSecurity/SpdmLib/l
Recently, the libspdm submodule was added to SecurityPkg
(SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1].
That submodule points to https://github.com/DMTF/libspdm.git.
The libspdm repo contains a submodule for cmocka that is hosted on
cryptomilk.org [2].
Cloning that submodule is failing to
-Original Message-
From: Michael Kubacki
Sent: Friday, May 17, 2024 4:28 PM
To: Kinney, Michael D ; devel@edk2.groups.io;
Andrew Fish ; Leif Lindholm ;
Liming Gao
Cc: Feng, Bob C ; Joey Vagedes
; Rebecca Cran ; Sean Brogan
; Chen, Christine
Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1
In preparation for the transition to a pull request (PR) contribution
process, I've updated the TianoCore wiki.
- Current official TianoCore wiki:
https://github.com/tianocore/tianocore.github.io/wiki/
- My fork with proposed changes:
https://github.com/makubacki/tianocore.github.io/wiki
-
From: Patrick Payne
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as
per the PI 1.8 spec. This flag is used to indicate that the memory
should be treated as special purpose memory (SPM).
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Michael Kubacki
---
Notes:
V3
notes, I will follow up in the future for
a change that should be able to lock the CodeQL query versions against
the CLI version.
Thanks,
Michael
On 5/17/2024 7:20 PM, Michael Kubacki wrote:
To ensure CI is unblocked, I am going to add the push tag now.
On 5/17/2024 6:31 PM, Michael Kubacki
To ensure CI is unblocked, I am going to add the push tag now.
On 5/17/2024 6:31 PM, Michael Kubacki wrote:
Thanks Mike. Are you okay with me completing the PR now?
On 5/17/2024 5:31 PM, Kinney, Michael D wrote:
Reviewed-by: Michael D Kinney
-Original Message-
From: mikub
; Liming Gao ; Kinney,
Michael D ; Rebecca Cran ;
Sean Brogan ; Chen, Christine
Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
From: Michael Kubacki
This fixes an issue where the CodeQL queries currently fetched in the
pipeline are incompatible with the current executable used.
Update
From: Michael Kubacki
This fixes an issue where the CodeQL queries currently fetched in the
pipeline are incompatible with the current executable used.
Update to pick up functional and security fixes. See the following
comparison for detailed differences:
https://github.com/github/codeql-cli
From: Patrick Payne
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as
per the PI 1.8 spec. This flag is used to indicate that the memory
should be treated as special purpose memory (SPM).
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Michael Kubacki
---
Notes:
V2
From: Patrick Payne
Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as
per the PI 1.8 spec. This flag is used to indicate that the memory
should be treated as special purpose memory (SPM).
Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit and
sets the GCD memory
On 5/3/2024 4:38 PM, Michael D Kinney wrote:
-Original Message-
From: Kinney, Michael D
Sent: Friday, May 3, 2024 1:13 PM
To: Pedro Falcato
Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
; Andrew Fish (af...@apple.com) ;
Kinney, Michael D
Subject: RE: [edk2-rfc] [edk2-
Depends on:
https://github.com/mdkinney/github-action-check-codeowners-maintainers
Thanks,
Mike
-Original Message-
From: Michael Kubacki
Sent: Thursday, May 2, 2024 8:21 AM
To: devel@edk2.groups.io; quic_llind...@quicinc.com;
marcin.juszkiew...@linaro.org; Kinney, Michael D
; r.
] Proposal to switch TianoCore Code Review from
email to GitHub Pull Requests on 5-24-2024
On 2024-05-02 04:08, Michael Kubacki wrote:
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for f
On 5/2/2024 6:57 AM, Leif Lindholm wrote:
On 2024-05-02 04:08, Michael Kubacki wrote:
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implem
On 5/2/2024 6:34 AM, Leif Lindholm wrote:
On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The pro
On 5/2/2024 5:37 AM, Ard Biesheuvel wrote:
On Wed, 1 May 2024 at 19:44, Michael D Kinney
wrote:
Hello,
I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.
The proposed date to switch would be immediately after
Thank you for this proposal. We've been anticipating this change for
years and are excited to help support it.
Here's some items we'd like to raise for feedback that we could help
implement. Many could likely be done in time for the transition.
1. Automate reviewers - We've discussed CODEOWN
, thank you Mike.
Should I close/re-open my PR?
Or should I keep waiting?
Thank you
Yao, Jiewen
-Original Message-
From: Kinney, Michael D
Sent: Thursday, April 25, 2024 7:01 AM
To: Yao, Jiewen ; devel@edk2.groups.io; Sean Brogan
; Michael Kubacki
Cc: Gerd Hoffmann ; Ard Biesheuvel
/24/2024 6:11 PM, Michael D Kinney wrote:
Go ahead and add the push label.
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: Wednesday, April 24, 2024 2:55 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Liming Gao
; Rebecca Cran ; Sean
Brogan ; Chen
ichael
On 4/24/2024 1:37 PM, Michael Kubacki wrote:
From: Michael Kubacki
Fixes current CI CodeQL failures due to old CodeQL CLI version.
Updates CodeQL to work with the latest queries. Includes functional
and security fixes within the CodeQL CLI binary.
For more information on release d
From: Michael Kubacki
Fixes current CI CodeQL failures due to old CodeQL CLI version.
Updates CodeQL to work with the latest queries. Includes functional
and security fixes within the CodeQL CLI binary.
For more information on release details see:
https://github.com/github/codeql-cli-binaries
Might be related to this issue
https://gitlab.com/qemu-project/qemu/-/issues/2064.
On 4/8/2024 4:33 AM, Wu, Jiaxin wrote:
Hi Gerd,
With below OVMF build and QEMU command, OVMF hangs after SendSmiIpi
(mBspApicId) during SmmRelocateBases(), is there any issues with latest
code to support SMM o
Can you please fix the following typo? "PcdEnableSpdmDeviceAuthenticaion"
Thanks,
Michael
On 4/1/2024 10:31 PM, Wenxing Hou wrote:
Add EV_EFI_SPDM_DEVICE_POLICY support for MeasureVariable.
Cc: Liming Gao
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdeModulePkg/MdeModulePkg.dec
Hi Mike,
Thanks for continuing to use that project. I haven't seen many updates
but my understanding is that you've worked on some of the items since we
last talked.
Could you please take a look through and see what items you can update?
Mostly these types of updates:
- Check that current
From: Michael Kubacki
Currently CodeQL runs have the following warnings:
Node.js 16 actions are deprecated. Please update the following
actions to use Node.js 20: actions/setup-python@v4,
actions/upload-artifact@v3, actions/cache@v3. For more information
see:
https://github.blog
This looks fine.
Reviewed-by: Michael Kubacki
On 3/1/2024 7:58 AM, gaoliming wrote:
I agree this change. It should have no negative impact. Reviewed-by: Liming
Gao
Michael:
Have you any comments for this change?
Thanks
Liming
-邮件原件-
发件人: Zhihao Li
发送时间: 2024年3月1日 15:12
收件人
On 2/27/2024 10:43 PM, Laszlo Ersek wrote:
On 2/27/24 17:04, Michael Kubacki wrote:
Hi Gerd,
There is a way to suppress results explained here:
https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns
A real-world example is here:
https://github.com/microsoft
Hi Gerd,
There is a way to suppress results explained here:
https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns
A real-world example is here:
https://github.com/microsoft/mu_basecore/blob/release/202311/CodeQlFilters.yml
That can currently operate at the fi
being deprecated
From: Michael Kubacki
Currently CodeQL runs have the following warnings:
Node.js 16 actions are deprecated. Please update the following
actions to use Node.js 20: actions/setup-python@v4,
actions/upload-artifact@v3, actions/cache@v3. For more information
see:
https
From: Michael Kubacki
Currently CodeQL runs have the following warnings:
Node.js 16 actions are deprecated. Please update the following
actions to use Node.js 20: actions/setup-python@v4,
actions/upload-artifact@v3, actions/cache@v3. For more information
see:
https://github.blog
Reviewed-by: Michael Kubacki
On 2/18/2024 3:59 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
Update PatchCheck.py to evaluate all the files modified in each commit
and generate an error if:
* A commit adds/modifies files in multiple package directories
From: Michael Kubacki
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this creates an invalid path.
An example of when this may be an issue is in external dependencies
where
From: Michael Kubacki
Resolves a new CodeQL error due to the value being incremented in the
loop being a narrower type than the variable it is being compared
against.
The variable is changed to a UINT32 type so it has the same width as
the type it is being compared against.
Issue explanation
From: Michael Kubacki
Checks that an offset used to access array elements is within the
expected range before accessing the array item.
Cc: Liming Gao
Cc: Ray Ni
Cc: Rebecca Cran
Cc: Richard Ho
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
From: Michael Kubacki
The "-r" parameter was not added to the application so remove it from
the help string.
The standards section is also updated to point to the current
specification location on uefi.org.
Cc: Nate DeSimone
Cc: Ankit Sinha
Signed-off-by: Michael Kubacki
-
From: Michael Kubacki
Move the range check before array access to enforce the bounds
as expected.
Cc: Ray Ni
Signed-off-by: Michael Kubacki
---
FatPkg/FatPei/FatLiteApi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei
including previously-unreferenced constructors and making sure
multi-file gtest EDK2 components work.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4610
Signed-off-by: Pedro Falcato
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Sean Brogan
---
Note: /WHOLEARCHIVE should work for VS2015 and newer. I
Reviewed-by: Michael Kubacki
On 11/30/2023 7:18 PM, Nate DeSimone wrote:
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in
Reviewed-by: Michael Kubacki
On 11/30/2023 7:18 PM, Nate DeSimone wrote:
Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in
From: Michael Kubacki
Updates the workflow to also output files that can be loaded in emacs
to show CodeQL issues (in addition to the existing SARIF output for
standard SARIF viewers).
The emacs files are in the SARIF zip file attached to each "CodeQL"
run (https://github.com/tian
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3267
Adds two new helper functions.
Currently, a function exists in Tpm2CommandLib to copy a digest list
to a buffer. A function to perform the inverse operation - copying
from a buffer to a digest list is added.
A
From: Michael Kubacki
Updates the default tool chain from VS2015x86 to VS2019.
This is the VS tool chain used in CI and more likely to be installed
on developer's systems. This is used in stuart commands when a
toolchain is not explicitly specified.
Cc: Bob Feng
Cc: Liming Gao
Cc: Re
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3267
Adds two new helper functions.
Currently, a function exists in Tpm2CommandLib to copy a digest list
to a buffer. A function to perform the inverse operation - copying
from a buffer to a digest list is added.
A
From: Michael Kubacki
GetNextEntryAttribute() is currently applying a 64-bit mask
(TT_ATTRIBUTES_MASK) to a 32-bit descriptor value (EntryType).
The original descriptor was 64 bits containing the upper and
lower attributes which are included in TT_ATTRIBUTES_MASK.
The PrevEntryAttribute
From: Michael Kubacki
This series contains two changes:
1. To fix a compiler warning with the current state of code.
2. To update the code to pass the integer width needed for a
comparison to set EFI_MEMORY_XP in the GCD attribute returned
for a given page attribute.
v2 changes
From: Michael Kubacki
Includes two recent Uncrustify formatting commits to prevent them
from showing in git blame.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Rebecca Cran
Signed-off-by: Michael Kubacki
---
.git-blame-ignore-revs | 4
1 file changed, 4 insertions
From: Michael Kubacki
GetNextEntryAttribute() assigns a 64-bit integer to 32-bit integers.
This change explicitly casts the assigned value as UINT32 to prevent
the following Visual Studio compiler warning:
'=': conversion from 'UINT64' to 'UINT32', possible l
From: Michael Kubacki
GetNextEntryAttribute() is currently applying a 64-bit mask
(TT_ATTRIBUTES_MASK) to a 32-bit descriptor value (EntryType).
The original descriptor was 64 bits containing the upper and
lower attributes which are included in TT_ATTRIBUTES_MASK.
The PrevEntryAttribute
From: Michael Kubacki
This series contains two changes:
1. To fix a compiler warning with the current state of code.
2. To update the code to pass the integer width needed for a
comparison to set EFI_MEMORY_XP in the GCD attribute returned
for a given page attribute.
Cc: Leif Lindholm
From: Michael Kubacki
mReplaceLiveEntryFunc is a function pointer but assigned as a VOID*
pointer:
mReplaceLiveEntryFunc = *(VOID **)GET_GUID_HOB_DATA (Hob);
This leads to the Visual Studio warning:
nonstandard extension, function/data pointer conversion in
expression
This change
On 11/15/2023 5:10 AM, Laszlo Ersek wrote:
On 11/14/23 20:37, Michael Kubacki wrote:
On 11/14/2023 11:21 AM, Michael D Kinney wrote:
Hi Ranbir,
First I want to recognize your efforts to collect Coverity issues and
propose changes to address
them.
I still disagree with adding CpuDealLoop
On 11/17/2023 3:42 AM, Laszlo Ersek wrote:
On 11/17/23 03:15, Yoshinoya wrote:
Hi,
I find there is a PrmPkg in udk source code.
Based on its Readme.md, its goal is to offload smm code to sci os
mechanisms.
So, is there any actual use case on real platform now?
It seems it's just a conceptional
On 11/16/2023 3:29 AM, Pedro Falcato wrote:
On Tue, Nov 14, 2023 at 3:01 PM Laszlo Ersek wrote:
On 11/13/23 22:33, Pedro Falcato wrote:
On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote:
On 11/13/2023 1:08 PM, Michael Kubacki wrote:
Yes. I just did it. It is relatively minor and impacts
On 11/13/2023 8:42 AM, Laszlo Ersek wrote:
sorry, unfinished thought:
On 11/13/23 14:39, Laszlo Ersek wrote:
- the "sarif emacs" output seems a bit broken, actually, so it's not usable.
Consider the following entry from the original JSON file:
}, {
"ruleId" : "cpp/missing-null-te
From: Michael Kubacki
Cc: Ard Biesheuvel
Cc: Corvin Köhne
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
Signed-off-by: Michael Kubacki
---
OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 4
++--
OvmfPkg/IncompatiblePciDeviceSupportDxe
From: Michael Kubacki
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael Kubacki
---
EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c
b/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c
From: Michael Kubacki
This patch series updates to 73.0.8 Uncrustify release which brings
the following changes:
- A fix for preventing endless indentation in struct assignment.
- Updates to code areas impacted by the change. This currently
updates 5 files in two packages - EmulatorPkg
On 11/14/2023 11:21 AM, Michael D Kinney wrote:
Hi Ranbir,
First I want to recognize your efforts to collect Coverity issues and
propose changes to address
them.
I still disagree with adding CpuDealLoop() for any static analysis issues.
There have been previous discussions about adding a PA
On 11/13/2023 3:37 PM, Rebecca Cran wrote:
On 11/13/2023 1:08 PM, Michael Kubacki wrote:
Yes. I just did it. It is relatively minor and impacts expected code
areas.
https://github.com/tianocore/edk2/pull/5043/files
Could you update .git-blame-ignore-revs please?
https
On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote:
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
The issue with doing this is
On 11/13/2023 2:07 PM, Pedro Falcato wrote:
On Mon, Nov 13, 2023 at 11:58 AM Laszlo Ersek wrote:
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk
On 11/13/2023 6:58 AM, Laszlo Ersek wrote:
Hi Michael,
recently I encountered an uncrustify failure on github.
The reason was that my local uncrustify was *more recent* (73.0.8) than
the one we use in edk2 CI (which is 73.0.3, per the edk2 file
".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep
On 11/3/2023 10:46 AM, Laszlo Ersek wrote:
On 11/3/23 15:16, Michael Kubacki wrote:
On 11/3/2023 9:06 AM, Laszlo Ersek wrote:
On 11/2/23 21:03, Michael Kubacki wrote:
From: Michael Kubacki
The code in this directory is licensed under Apache License, Version
2.0. Therefore, the directory is
On 11/3/2023 9:06 AM, Laszlo Ersek wrote:
On 11/2/23 21:03, Michael Kubacki wrote:
From: Michael Kubacki
The code in this directory is licensed under Apache License, Version
2.0. Therefore, the directory is listed under paths with licenses
other than BSD-2-Clause Plus Patent. The directory
From: Michael Kubacki
The code in this directory is licensed under Apache License, Version
2.0. Therefore, the directory is listed under paths with licenses
other than BSD-2-Clause Plus Patent. The directory link points to the
complete Apache License, Version 2.0 on apache.org.
Cc: Andrew Fish
From: Michael Kubacki
Updates the CodeQL queries opted into by edk2 to a set of queries from
the standard CodeQL query package `codeql/cpp-queries`.
After testing a large number of queries the included set here were
found to be the most useful with the least number of false positives.
Some
From: Michael Kubacki
Since a large number of CodeQL queries are being enabled to identify
issues that the community can collectively resolve, audit mode needs to
be enabled to prevent the build from failing.
In the future, this global audit mode can be disabled and individual
packages can
1 - 100 of 1006 matches
Mail list logo
