On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote:
On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
to use it then let it get installed at same moment as "build" command is.
The issue with doing this is there's a push to remove all C/C++ code
from BaseTools (including porting existing code to Python), and adding
edk2-uncrustify would work against that.
That was a reason I did not add the code to BaseTools. I personally
think it would bloat the edk2 repo and complicate its build process for
something that rarely changes. Given binary dependencies are already
used and managed for other incoming binaries such as iasl and nasm
(https://github.com/tianocore/edk2/tree/master/BaseTools/Bin) and the
effort to eliminate C/C++ code from BaseTools, I think it makes sense to
keep it in a dedicated repository.
If there is another reason for the move, such as a preference to move
the repo under the Tianocore organization (for whatever reason) or
something like that, please let me know.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111180): https://edk2.groups.io/g/devel/message/111180
Mute This Topic: https://groups.io/mt/102559740/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
