Re: [edk2-devel] MOV64 and CLANGPDB

x9, ((-1) >> 48) & 0x, lsl #48 ; movk x9, ((-1) >> 32) & > 0x, lsl #32 ; movk x9, ((-1) >> 16) & 0x, lsl #16 ; movk x9, > (-1) & 0x >cmp x0, x9 >cset x0, ne >mov x9, xzr >ret > > --- > > On 2/13/2025

[edk2-devel] MOV64 and CLANGPDB

I would very much like to have a MOV64 that's universally usable. That's sort of the point. However, I'm wondering if the error is in fact triggered by the first stanza (movz), which doesn't mask its result, and will have 48 sign extended bits above the ones we care about for the instruction. Ann

[edk2-devel] Various confusing bits around USB host controller protocols

Spotted while looking into https://github.com/tianocore/edk2/pull/10593 This starts with https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Include/Ppi/Usb2HostController.h#L244, which states that PEI_USB2_HOST_CONTROLLER_PPI is modelled after EFI_USB2_HOST_CONTROLLER_PROTOCOL as described

[edk2-devel] Announcing addition of two stewards

Hi all, In line with the statement from the role description[1] "New stewards are elected by existing stewards in recognition of work already being done.", Andrew, Mike, and myself have invited Ard Biesheuvel and Michael Kubacki to join the TianoCore stewards team - and they have accepted! [1] ht

Re: [edk2-devel] Expansion of ARCH in .dsc files

On Wed, 8 Jan 2025 at 15:01, Gerd Hoffmann wrote: > > Because "the list of all architectures being built simultaneously" > > simply isn't very useful information build-time. > > I think this is not intended for building all archs in simultaneously > (even though that often works too), but for firm

Re: [edk2-devel] Expansion of ARCH in .dsc files

gt; "architectural modifiers for the [Defines] section tag are not permitted" > > https://tianocore-docs.github.io/edk2-InfSpecification/release-1.27/3_edk_ii_inf_file_format/34_[defines]_section.html#34-defines-section > > Thanks, > Joey > > -Original Message-

[edk2-devel] Expansion of ARCH in .dsc files

So... I originally tripped over my misunderstanding of when writing https://github.com/tianocore/edk2/pull/6262 to get around something I wanted to test in UefiPayloadPkg. Now Ajan has run into at least an adjacent problem when trying to rework https://github.com/tianocore/edk2/pull/6545 based on

Re: [edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

The job name mismatch is also making all VS CI jobs show as nonexistent in the dashboard of https://github.com/tianocore/edk2/blob/master/ReadMe.rst / Leif On Wed, 18 Dec 2024 at 11:13, Leif Lindholm via groups.io wrote: > > PR CI jobs are currently failing on Ia32 EmulatorPkg R

[edk2-devel] CI blockage: VS2019 Ia32 EmulatorPkg failure

PR CI jobs are currently failing on Ia32 EmulatorPkg RELEASE (passes on DEBUG) with --- ERROR : Could not allocate PeiServicesTablePage @ 1300 --- during the "run to shell" test. I note that the build step for PlatformCI_EmulatorPkg_Windows_VS2019_PR now uses VS2022, presumably as of https://g

[edk2-devel] SBOM template for edk2

Hi all, Richard submitted a PR to add an SBOM .cdx.json template to the main repository: https://github.com/tianocore/edk2/pull/6455 This is a good thing, but I think we could do with some feedback from some of our downstream consumers. I know there has been work ongoing inside UEFI forum around

Re: [edk2-devel] [edk2-discuss] Attempted runtime pool allocation returns non-runtime pool

Hi Adam, I think this topic is better for the "devel" group, rather then "discuss". I've added it to cc. I don't see why you would get back a valid pointer if the request failed. That would feel like a bug in AllocateRuntimeZeroPool. But there could be some subtlety involving pool allocations I'm

[edk2-devel] [edk2-stable202411 soft-freeze] request to include PR #6413 in stable tag

Hi Liming, others, I would like to request that the following PR: https://github.com/tianocore/edk2/pull/6413 is included in the next stable tag. It was submitted during soft freeze, but is a bugfix that resolves a real boot failure on certain newer platforms, due to software operations that are

Re: [edk2-devel] MicrovmX64, "Did not find any '.text' section"

Hi Oliver, Gerd, On Mon, 4 Nov 2024 at 21:17, Oliver Smith-Denny wrote: > >> While working on the FdtLib migration to the submodule variant, I decided > >> to > >> at least try to test build MicrovmX64 ... but I'm failing. > >> > >> Both clang and gcc builds bail out at a GenFw invocation to gen

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

On Tue, 22 Oct 2024 at 12:19, Rebecca Cran wrote: > In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for > over a year, I'd like to proceed with removing them as well. > > Please provide feedback by Thursday October 31st. In the absence of > feedback I'll plan to proceed with r

[edk2-devel] likely upcoming change of my email address at Qualcomm

Hi all, Qualcomm is (finally) trialling some sane infrastructure for open source email communications. As a result, I have a new account I will start a soft migration across to. If everything seems to be working fine, I will send out an update for Maintainers.txt in a couple of weeks. This w

[edk2-devel] MicrovmX64, "Did not find any '.text' section"

Hi Gerd, others, While working on the FdtLib migration to the submodule variant, I decided to at least try to test build MicrovmX64 ... but I'm failing. Both clang and gcc builds bail out at a GenFw invocation to generate ResetVector.efi due to "Did not find any '.text' section". (Assert on

Re: [edk2-devel] Retire EmbeddedPkg/Library/FdtLib

On 2024-09-19 10:57, Nhi Pham via groups.io wrote: Hi, It appears that the EmbeddedPkg/Library/FdtLib could be replaced by MdePkg/Library/BaseFdtLib. Should we remove the old one in EmbeddedPkg and transition to the new one? Yes, but the new one does not (yet) implement all the functionality

Re: [edk2-devel] RFC - Tools & CI Meeting European friendly time

Thanks Ard, Sure, that slot works for me. Regards, Leif On 2024-09-10 09:13, Ard Biesheuvel wrote: (cc Leif) That would work for me - thanks. On Tue, 10 Sept 2024 at 02:22, Sean > wrote: __ Hi, In the Tools and CI meeting it was brought up that

Re: [edk2-devel] [PATCH edk2-platforms 0/3] SbsaQemu: Move from ArmSmcLib to ArmMonitorLib

ArmMonitorLib to simplify code. First patch also moves all SMC calls we use into HardwareInfoLib to have all hardware related queries in one place. Signed-off-by: Marcin Juszkiewicz For the series: Leif Lindholm Thanks! --- Marcin Juszkiewicz (3): SbsaQemu: move SMC calls to

Re: [edk2-devel] [PATCH edk2-platforms v6 0/6] SbsaQemu: Align the PPTT tables with QEMU

> The TF-A part is already merged: > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27189 > > Signed-off-by: Xiong Yining > Signed-off-by: Marcin Juszkiewicz For the series: Reviewed-by: Leif Lindholm Thanks! / Leif > To: devel@edk2.groups.io > Cc: Le

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

tion Only] So Leif, what's your preference? AMD already switched to use PR on edk2-platforms, shall we get back to the email review? Thanks Abner Get Outlook for Android <https://aka.ms/AAb9ysg> ---- *From:* Leif L

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

Err, no we haven't. Although we're in the process of doing that. / Leif On 2024-08-07 08:16, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms?

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

On Thu, Aug 01, 2024 at 10:19:50 -0500, Jeremy Linton wrote: > Hi, > > > On 8/1/24 09:44, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > > > > > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > > > > > > > > Hi, > > > > > > > > On 7/31/24 11:33, Ard Biesh

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf

On Mon, Aug 05, 2024 at 21:14:33 +0200, Marcin Juszkiewicz wrote: > On 31.07.2024 18:33, Ard Biesheuvel wrote: > > PrePeiCore has been superseded by Sec.inf, which is a more common naming > > for the SEC module, aligned with other architectures. No functional > > changes intended. > > > > Switch a

Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg

Hi Oliver, On 2024-08-01 23:39, Oliver Smith-Denny wrote: CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler intrinsics and floating point functions required by OpenSSL, respectively. CompilerIntrinsicsLib is used almost in every DSC that builds ARM/AARCH64 and ArmSoftFloatLib is

Re: [edk2-devel] Can we do something about libspdm?

spdm project. > > Please feel free to submit issue if you see anything could be improved. > > Thank you > Yao, Jiewen > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > > Sent: Wednesday, July 31, 2024 10:10 PM > >

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Wenyi Xie > Cc: Jeremy Linton > Cc: Ling Jia > Cc: Peng Xie > Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Wenyi Xie > Cc: Yiqi Shu > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks!

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: > This adds the SmbusRead() function designed for SMBUS transaction to > support the extraction of the data lenth byte from the initial byte of > the SMBUS Block Read, allowing the I2C master to accurately read the > SMBUS respon

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: > This adds the SmbusRead() function designed for SMBUS transaction to > support the extraction of the data lenth byte from the initial byte of length > the SMBUS Block Read, allowing the I2C master to accurately read the > SMB

Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote: > This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. > > Signed-off-by: Nhi Pham > --- > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 > 1 file changed, 12 insertions(+) > > diff --git a/Silicon/

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

On 2024-08-01 13:49, Rebecca Cran wrote: Replies inline. On 8/1/24 3:45 AM, Leif Lindholm wrote: On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

, since that broke somewhere along the way. > diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md > new file mode 100644 > index ..84882bcab2fa > --- /dev/null > +++ b/CONTRIBUTORS.md > @@ -0,0 +1,68 @@ > +EDK II Platforms Maintainers and Reviewers > +==

Re: [edk2-devel] Can we do something about libspdm?

OK, I've raised https://github.com/DMTF/libspdm/issues/2787. On Wed, Jul 31, 2024 at 12:47:25 +, Yao, Jiewen wrote: > i recommend submitting issue directly to libspdm project github. > > thank you > jiewen yao > ____ > 发件人: Leif Lindholm

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Beagle/PrePi: Fix build after ArmLib refactor

On Wed, Jul 31, 2024 at 12:59:40 +0200, Ard Biesheuvel wrote: > The Chipset/ sub-directories no longer exist and the code has been moved > into MdePkg. Update the includes accordingly. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks! > --- > Pl

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Socionext: Fix line endings

On Wed, Jul 31, 2024 at 12:52:27 +0200, Ard Biesheuvel wrote: > Use CR-LF as required for DSC files. > > Signed-off-by: Ard Biesheuvel For the series: Reviewed-by: Leif Lindholm Thanks! > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 2 +- > 1 file changed,

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Beagle: Fix DSC line endings

On Wed, Jul 31, 2024 at 12:42:03 +0200, Ard Biesheuvel wrote: > Use CR-LF as required for DSC files. > > Signed-off-by: Ard Biesheuvel For the series: Reviewed-by: Leif Lindholm Thanks! > --- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > 1 file changed,

[edk2-devel] Can we do something about libspdm?

Hi, The libspdm submodule is 1.1GB of (compressed) data to clone, but only 18MB once checked out. This is by some margin the majority of the time it takes to clone edk2 and submodules. (It takes me 5m44s, and I don't think it's my Internet connection slowing it down.) Having become curious as to

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

On 2024-07-30 16:18, Ard Biesheuvel wrote: Sure, that works for me. I've released the stuck messages. I probably need to subscribe ardb+...@google.com to the mailing list, which is the from" address when I send patches from my google dev machine. To be clear though, in the moderation system

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

On 2024-07-30 16:00, Ard Biesheuvel wrote: On Tue, 30 Jul 2024 at 16:49, Leif Lindholm wrote: On 2024-07-30 15:30, Rebecca Cran wrote: Ard, It looks like your original message didn't make it through to the list. I don't see it on https://edk2.groups.io/g/devel/messages or in m

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

On 2024-07-30 15:30, Rebecca Cran wrote: Ard, It looks like your original message didn't make it through to the list. I don't see it on https://edk2.groups.io/g/devel/messages or in my personal email client. Huh, indeed. groups.io seems upset that google's email setup has enabled some new

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform AARCH64: Drop bogus local copy of gArmMpCoreInfoPpiGuid GUID

x all of those. > > This is just a janitorial patch with no functional changes so fixing all > of these in one go. > > Cc: Leif Lindholm > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Thanks! / Leif > --- > Platform/Hisilicon/HiKey/Library/HiKeyLib/

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

t; Stop using them in edk2-platforms so we can remove them entirely from > edk2. > > Cc: Leif Lindholm > Cc: Rebecca Cran > Cc: Nhi Pham > Cc: Chuong Tran > Cc: Wenyi Xie > Cc: Peng Xie > Cc: Ling Jia > Cc: Yiqi Shu For the series: Reviewed-by: Leif Lindholm T

Re: [edk2-devel] [PATCH edk2-platforms v2 0/8] RPi: Drop EmbeddedPkg reset runtime

a crash when DmaLib > attempts to set EFI_MEMORY_XP on allocated buffers > - add a patch to force the correct dispatch order for the varstore > related drivers > - fix line endings For the added commits: Reviewed-by: Leif Lindholm > Cc: Leif Lindholm > Cc: Jeremy Linton

Re: [edk2-devel] [PATCH edk2-platforms 5/5] Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

0xD6, 0xB5}} > - gRaspberryPiEventResetGuid = {0xCD7CC258, 0x31DB, 0x11E6, {0x9F, 0xD3, > 0x63, 0xB4, 0xB4, 0xE4, 0xD4, 0xB4}} >gConfigDxeFormSetGuid = {0xCD7CC258, 0x31DB, 0x22E6, {0x9F, 0x22, 0x63, > 0xB0, 0xB8, 0xEE, 0xD6, 0xB5}} *loud sigh at looking those "G

Re: [edk2-devel] [PATCH edk2-platforms 00/11] Phase out ArmSmcPsciResetSystemLib

ovided for those. > > Patches #1 and #2 are unrelated fixes. > > Cc: Leif Lindholm For the series: Reviewed-by: Leif Lindholm Thanks for this cleanup! > Ard Biesheuvel (11): > Platform,Silicon: Fix line endings > Silicon/SynQuacer: Fix CLANGDWARF build > P

Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver

nf > > - > EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf Would it make sense to move the existing ResetSystemLib mapping here? Not for any particular reason other than it's not actually used anywhere else. Regardless, for the series: Reviewed

[edk2-devel] Remove Deprecated ArmPsciResetSystemLib #5922

patches for edk2-platforms Maintainers.txt adding your github IDs in [] after your email addresses, so I know how to loop everyone in on github conversations easily? For example: Leif Lindholm [leiflindholm] / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat

o the CRLF->LF conversion work once the shock from the Github-PR switch has settled. Regards, Leif Regards, JP -Original Message- From: Leif Lindholm Sent: Wednesday, July 17, 2024 7:55 PM To: devel@edk2.groups.io; Jayaprakash, N ; Kinney, Michael D Cc: Rebecca Cran Subject: Re:

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat

: Kinney, Michael D Sent: Friday, July 12, 2024 9:29 PM To: Jayaprakash, N ; devel@edk2.groups.io; Leif Lindholm Cc: Rebecca Cran ; Kinney, Michael D Subject: RE: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat + Leif .gitattributes is not used in

Re: [edk2-devel] [PATCH edk2-platforms v3 4/5] SbsaQemu: provide cache info per core in PPTT

On Wed, Jul 10, 2024 at 14:58:52 +0100, Jonathan Cameron wrote: > On Tue, 9 Jul 2024 14:01:53 +0100 > "Leif Lindholm" wrote: > > > On Tue, Jul 09, 2024 at 12:47:09 +0200, Marcin Juszkiewicz wrote: > > > During Linaro Connect MAD24 I was asked to move cache

Re: [edk2-devel] github impact:breaking-change

/tianocore/edk2/pull/5895 for some minor language tweaks that hopefully reduce the risk of misinterpretation. > I added a description in GitHub for the label as well: > > https://github.com/tianocore/edk2/labels Thanks! Regards, Leif > > Thanks, > Michael > > On 7

Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

On Tue, Jul 09, 2024 at 15:12:37 +0200, Marcin Juszkiewicz wrote: > Dnia wtorek, 9 lipca 2024 15:00:12 CEST Leif Lindholm via groups.io pisze: > > On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > > > Function AddPpttTable() adding PPTT got too long. This

Re: [edk2-devel] [PATCH edk2-platforms v3 4/5] SbsaQemu: provide cache info per core in PPTT

> Socket -> Clusters -> Cores + Caches -> Threads (if exist) > > to: > > Socket -> Clusters -> Cores -> Caches + Threads (if exist) > > Cache sizes are still 32+32+512KB (L1d, L1i, L2) as QEMU does not > implement them at all so we can tell whatever.

Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > Function AddPpttTable() adding PPTT got too long. This change moves part > of it into helper function AddCoresToPpttTable() which takes care of > generating entries for Core and below (Cache, Thread). > > Signed-off-by: Marcin Jus

Re: [edk2-devel] [PATCH edk2-platforms v3 3/5] SbsaQemu: update PPTT to ACPI 6.5

On Tue, Jul 09, 2024 at 12:47:08 +0200, Marcin Juszkiewicz wrote: > ACPI 6.5 is the newest version of specification so far. The only change "The only functional change..." With that: Reviewed-by: Leif Lindholm / Leif > to make is handling of CacheId (has to be unique and

Re: [edk2-devel] [PATCH edk2-platforms v3 2/5] SbsaQemu: align the PPTT tables with QEMU

te complex PPTT tables > setups. > > We can get the CPU topology information via SMC. > > Signed-off-by: Xiong Yining > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm / Leif > --- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h |

Re: [edk2-devel] [PATCH edk2-platforms v3 1/5] SbsaQemu: get the information of CPU topology via SMC calls

On 2024-07-09 13:40, Leif Lindholm wrote: On Tue, Jul 09, 2024 at 12:47:06 +0200, Marcin Juszkiewicz wrote: Provide functions to check for CPU topology information: - the number of sockets on sbsa-ref platform. - the number of clusters in one socket. - the number of cores in one cluster

Re: [edk2-devel] [PATCH edk2-platforms v3 1/5] SbsaQemu: get the information of CPU topology via SMC calls

> +/** > + Get cpu topology(sockets, clusters, cores, threads) from device tree > passed by Qemu. We don't need to talk about qemu internals that will change in the future. "Get cpu topology ... from Qemu.) Other than that: Reviewed-by: Leif Lindholm / Leif

[edk2-devel] github impact:breaking-change

Hi, I'm seeing something in several PRs in flight (and merged) that have "impact:breaking-change" set, where the purpose of the PR is to fix said breakage, not introduce API compatibilities. Am I correct in my understanding that this is not the intended use, and if so how do we address the m

Re: [edk2-devel] [PATCH edk2-platforms v2 2/3] Silicon/SbsaQemu: align the PPTT tables with QEMU

On Tue, Jul 02, 2024 at 18:33:03 +0200, Marcin Juszkiewicz wrote: > From: Xiong Yining > > To align the CPU topology information recognized by the operating system > with the CPU topology information configured by QEMU, we need to make > use of the CPU topology information to create complex PPTT

Re: [edk2-devel] [PATCH edk2-platforms v2] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL

; TRNG is not implemented in TCG mode but is required by RngDxe to run. > > On older cpu cores nothing changes. > > Signed-off-by: Marcin Juszkiewicz Thanks! Reviewed-by: Leif Lindholm With one niggle below: > --- > By default we have Neoverse-N2 cpu which supports FEAT_RNG

Re: [edk2-devel] [PATCH edk2-platforms 0/4] Platform,Silicon: fix SiFive U540 and Opensbi builds

On Mon, Jun 24, 2024 at 22:37:27 +0530, Sunil V L wrote: > On Mon, Jun 24, 2024 at 02:32:33PM +0100, Leif Lindholm wrote: > > Heinrich reported a build breakage of U540, due to it lacking a > > mapping for RiscVMmuLib. While looking into that, I found that > > 1) The Opensbi

Re: [edk2-devel] How do debug tianocore.PatchCheck failed?

Hi Joey, On 2024-07-02 07:42, joeyli via groups.io wrote: Hi EDK2 experts, I was filed a submit request on github for "[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But I got a Azure Pipelines/tianocore.PatchCheck failed: https://github.com/tianocore/edk2/pull/5550/c

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

(Dropping direct cc:s) On 2024-07-01 20:16, Rebecca Cran wrote: Now that edk2 has been using PRs for a few weeks, I'd like to propose enabling the same workflow for edk2-platfoms. As maintainers or reviewers of platforms in the edk2-platforms repo, I'd like to get any feedback on moving from

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL

On 2024-07-01 14:35, Ard Biesheuvel wrote: Ard: would you be opposed to putting a DEBUG print and/or an ASSERT in BaseRngLibContructor if mRndrSupported == 0? An alternative would be to place a test and noisy warning inside SbsaQemuPlatformDxe. I'm not sure I follow what we are trying to fix h

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL

On 2024-07-01 13:58, Marcin Juszkiewicz wrote: diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc index 9306986bf7c0..3463e5c7a635 100644 --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc @@ -148,7 +148,9 @@ [LibraryClasses.c

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL

On 2024-06-27 15:22, Marcin Juszkiewicz wrote: By default we have Neoverse-N2 cpu which supports FEAT_RNG feature. Commit 5de5e230a80bed083360da95ba16a2c4a001620d (in EDK2) enabled that for ArmVirt platform. RNDR is implemented by both Neoverse-N2 and 'max' cpu implemented by QEMU. Other cpu mo

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: bump OemRevision to today

Makes sense. If you change the new version to 2024 instead of 2023 :) Reviewed-by: Leif Lindholm On 2024-06-25 18:56, Marcin Juszkiewicz wrote: Lot of time passed since 10th of August 2020 when this platform was added to EDK2-platforms repository. So let bump PcdAcpiDefaultOemRevision value

[edk2-devel] [PATCH edk2-platforms 4/4] Silicon/RiscVOpensbiLib: fix submodule version

Cc: Daniel Schaefer Cc: Sunil V L Cc: Abner Chang Signed-off-by: Leif Lindholm --- Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/opensbi b/Silicon/RISC-V/

[edk2-devel] [PATCH edk2-platforms 3/4] Platform/SiFive: add RiscVMmuLib mapping for U540

The freedom unleashed platform currently fails to build due to a missing mapping for RiscVMmuLib, so add one. Cc: Daniel Schaefer Cc: Sunil V L Cc: Abner Chang Signed-off-by: Leif Lindholm --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + 1 file changed, 1

[edk2-devel] [PATCH edk2-platforms 2/4] Platform/SiFive: CRLF fixup in U540.dsc

Cc: Daniel Schaefer Cc: Sunil V L Cc: Abner Chang Signed-off-by: Leif Lindholm --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b

[edk2-devel] [PATCH edk2-platforms 0/4] Platform,Silicon: fix SiFive U540 and Opensbi builds

Schuchardt Cc: Daniel Schaefer Cc: Sunil V L Cc: Abner Chang Leif Lindholm (4): Maintainers.txt: fix entry for SiFive U5SeriesPkg Platform/SiFive: CRLF fixup in U540.dsc Platform/SiFive: add RiscVMmuLib mapping for U540 Silicon/RiscVOpensbiLib: fix submodule version Platform/SiFive

[edk2-devel] [PATCH edk2-platforms 1/4] Maintainers.txt: fix entry for SiFive U5SeriesPkg

There was an error in the wildcard path described for U5SeriesPkg, so it failed to match. Fix the mistake. Cc: Michael D Kinney Cc: Daniel Schaefer Signed-off-by: Leif Lindholm --- Maintainers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Maintainers.txt b

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

On Sat, Jun 22, 2024 at 21:53:02 -0700, Sami Mujawar wrote: > Hi Leif, > > Thank you for this patch. > > These changes look good to me. > > Reviewed-by: Sami Mujawar Thanks! 3/5 pushed as d9bcbf86b03f. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. Vie

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] SbsaQemu: reformat all sources using uncrustify

matting sources without generating extra work for developers. > > Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm Thanks! / Leif > --- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 50 +- > .../Include/IndustryStandard/SbsaQemuAcpi.h | 86 +-- &g

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: reformat all sources using uncrustify

On Fri, Jun 21, 2024 at 15:39:01 +0200, Marcin Juszkiewicz wrote: > uncrustify is required in EDK2 repository. SbsaQemu (and other platforms > in edk2-platforms) code was free from using it IIRC. > > Reformat all files to make new contributions easier. We can recommend > formatting sources without

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

On Thu, Jun 20, 2024 at 16:43:00 +0200, Ard Biesheuvel wrote: > On Thu, 20 Jun 2024 at 16:33, Leif Lindholm wrote: > > > > Related to https://github.com/tianocore/edk2/pull/5797 > > > > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. > > Its

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

Obvs I forgot to update the subject when I squashed a bunch of line ending fixups. I'll do that before I push if anyone gives me an R-b on this. / Leif On 2024-06-20 15:32, Leif Lindholm wrote: A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endin

[edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Signed-off-by: Leif Lindholm --- Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 +- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc| 2 +- Silicon/NXP

[edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz

timout calculations, so could lead to a change in platform behaviour. Cc: Marcin Wojtas Cc: Narinder Dhillon Signed-off-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon

[edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

could lead to a change in platform behaviour. Cc: Sami Mujawar Cc: Thomas Abraham Signed-off-by: Leif Lindholm --- Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 -- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 -- Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 2

[edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

Gregory Cc: Marcin Juszkiewicz Cc: Meenakshi Aggarwal Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Signed-off-by: Leif Lindholm --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 5 - Silicon/NXP/NxpQoriqLs.dsc.inc

[edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz

lead to a change in platform behaviour. Cc: Ard Biesheuvel Cc: Wenyi Xie Signed-off-by: Leif Lindholm --- Platform/Hisilicon/D05/D05.dsc | 6 -- 1 file changed, 6 deletions(-) diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index d247e67e92fc..0cd98d54ddb3 100644

[edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

Wojtas Cc: Meenakshi Aggarwal Cc: Narinder Dhillon Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Leif Lindholm (5): Platform/SbsaQemu: fix .dsc line endings Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz Platform/ARM: d

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

Thank you. Reviewed-by: Leif Lindholm Pushed as 4e36179c55f4. / Leif On 2024-06-13 12:07, Tommy Huang via groups.io wrote: Hi Leif, Got it. I have pushed my patch update into below .git. You could clone it for further checked. https://github.com

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

On 2024-06-13 09:33, Leif Lindholm wrote: On 2024-06-13 09:04, Tommy Huang wrote: Hi Leif, Do we need to do more test for this commit? Or include more people for this? Hi Nhi, Apologies, traveling and having patchy access to time to look at things. (As can also be seen by how I

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

Chen ; BMC-SW Subject: Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver On 5/30/2024 8:33 AM, Tommy Huang wrote>> On 5/29/2024 8:18 PM, Leif Lindholm via groups.io wrote: +Nhi, Could you check/verify these work fine on your systems? Yes, I can. Thank

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

span over multiple packages as these Chipset/* files are relocated to a new directory and include paths must be updated. [1] https://edk2.groups.io/g/devel/message/111566 For my part, for the series: Reviewed-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Leif

Re: [edk2-devel] ArmCallSmc() and SMCCC specification

Hi Marcin. A few high-level thoughs below. On 2024-05-31 08:14, Marcin Juszkiewicz wrote: EDK2/ArmPkg/Library/ArmSmcLib has code to do SMC calls. There are ArmCallSmc[0-3]() functions for up to 3 arguments/results and ArmCallSmc() function which can use 7 arguments and get 4 results back. T

Re: [edk2-devel] SMBIOS BIOS ROM Size

On 2024-05-30 12:58, Rebecca Cran wrote: On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote: While reviewing https://github.com/tianocore/edk2/pull/5702, I found myself wondering "shouldn't this (doesn't apply to UEFI-based systems) be the case for the size field also?&quo

[edk2-devel] SMBIOS BIOS ROM Size

Hi Rebecca, While reviewing https://github.com/tianocore/edk2/pull/5702, I found myself wondering "shouldn't this (doesn't apply to UEFI-based systems) be the case for the size field also?". But the SMBIOS spec is quite clear that the size field refers to the size of the physical device the

Re: [edk2-devel] [PATCH edk2-non-osi v2 1/1] Qemu/Sbsa: update to TF-A 2.11.0

On 2024-05-29 14:29, Marcin Juszkiewicz wrote: Update TF-A binaries to the same version as QEMU CI uses. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm --- Platform/Qemu/Sbsa/Readme.md | 49 --- Platform/Qemu/Sbsa/bl1.bin | Bin 23349

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: update to TF-A 2.11.0

Can you update the hashes in Readme.md as well? / Leif On 2024-05-29 14:18, Marcin Juszkiewicz wrote: Update TF-A binaries to the same version as QEMU CI uses. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/Sbsa/bl1.bin | Bin 23349 -> 2 bytes Platform/Qemu/Sbsa/fip.bin | Bin

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch64 Gop UEFI Driver

behavior. 6.Signed .efi files for secuity boot needing. Cc: Ard Biesheuvel Cc: Isaac Oram Cc: Nate DeSimone Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ryan Chen Cc: BMC-SW Signed-off-by: Tommy Huang --- .../AArch64/ASpeedAst2500Gop.efi | Bin 45056 -> 5 bytes .../AArc

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On 2024-05-02 04:08, Michael Kubacki wrote: Thank you for this proposal. We've been anticipating this change for years and are excited to help support it. Here's some items we'd like to raise for feedback that we could help implement. Many could likely be done in time for the transition. 1.

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On 2024-05-02 07:33, Marcin Juszkiewicz wrote: W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze: I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately a

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On 2024-05-02 02:28, Rebecca Cran wrote: On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote: * The Pull Request submitter is required to invite the required maintainers and reviewers to the pull request. This is the same set of maintainers and reviewers that are required to be listed

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On 2024-05-01 18:43, Michael D Kinney wrote: Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently scheduled for M

Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] SbsaQemu: some cleanups

es DSDT nodes so iasl does not complain. > > Marcin Juszkiewicz (2): > SbsaQemu: do not set Timer interrupts > SbsaQemu: remove some methods from DSDT For series: Reviewed-by: Leif Lindholm Thanks! / Leif > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 10 -- > Si

[edk2-devel] [PATCH edk2-non-osi 1/1] Maintainers.txt: add maintainers for SbsaQemu platform

Signed-off-by: Leif Lindholm --- p.s. Mike, could you add write access for Marcin in this repo as well? It was a pure oversight not to ask this at the same time as for edk2-platforms. Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b

  1   2   3   4   5   6   7   8   9   10   >