On Thu, Jun 20, 2024 at 16:43:00 +0200, Ard Biesheuvel wrote: > On Thu, 20 Jun 2024 at 16:33, Leif Lindholm <quic_llind...@quicinc.com> wrote: > > > > Related to https://github.com/tianocore/edk2/pull/5797 > > > > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. > > Its functionality has been partially broken, and mostly ignored, for > > all AArch64 platforms since December 2020. > > > > This set cleans up some broken line endings in .dsc* files, then > > drops all non-invasive references to the Pcd: > > - .dsc* files setting it to 0 (which is the default in the definition, > > and means "just read it from the system register instead") > > - .inf files declaring a dependency that is in fact not there in > > current code. > > > > Finally, it drops the setting of the Pcd for platforms that set it to > > non-0. This has *never* done the right thing on these platforms since > > they are all AArch64, but it may affect timer timeout, so deserves > > deeper testing. > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Chuong Tran <chu...@os.amperecomputing.com> > > Cc: Graeme Gregory <gra...@xora.org.uk> > > Cc: Marcin Juszkiewicz <marcin.juszkiew...@linaro.org> > > Cc: Marcin Wojtas <marcin.s.woj...@gmail.com> > > Cc: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com> > > Cc: Narinder Dhillon <ndhil...@marvell.com> > > Cc: Nhi Pham <n...@os.amperecomputing.com> > > Cc: Rebecca Cran <rebe...@os.amperecomputing.com> > > Cc: Sami Mujawar <sami.muja...@arm.com> > > Cc: Thomas Abraham <thomas.abra...@arm.com> > > Cc: Wenyi Xie <xiewen...@huawei.com> > > > > Leif Lindholm (5): > > Platform/SbsaQemu: fix .dsc line endings > > Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz > > Platform/ARM: drop use of PcdArmArchTimerFreqInHz > > Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz > > Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz > > > > Looks fine to me > > Reviewed-by: Ard Biesheuvel <a...@kernel.org>
Thanks! Since 1-2 are just cleanup, I have now pushed those two commits, with R-b:s given, as 3f08401365d6..b29e69a688d6. I am tempted to now merge https://github.com/tianocore/edk2/pull/5797, at which point the platforms affected by 3-5 will break. Any objection? / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119670): https://edk2.groups.io/g/devel/message/119670 Mute This Topic: https://groups.io/mt/106780872/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
