Hi Rebecca,

While reviewing https://github.com/tianocore/edk2/pull/5702, I found myself wondering "shouldn't this (doesn't apply to UEFI-based systems) be the case for the size field also?".

But the SMBIOS spec is quite clear that the size field refers to the size of the physical device the BIOS is stored on.

Currently, this field is hardwired to PcdFdSize in the smbios helper library. But that would only be accurate for platforms that use the edk2 build system to generate the final flashable image to a fixed size.

This isn't really true for SbsaQemu, and I don't think it is for Mt. Jade. And those are the only two upstream platforms using this SmbiosMiscDxe.

Do we need to solve this by adding another function for OemMiscLib?

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119385): https://edk2.groups.io/g/devel/message/119385
Mute This Topic: https://groups.io/mt/106385738/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to