Reviewed. Merged.
Thank you Ard!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Tuesday, April 4, 2023 5:46 PM
> To: devel@edk2.groups.io; mhaeu...@posteo.de; Ni, Ray
> Cc: Andrew Fish ; Kinney, Michael D
> ; Liu, Zhiguang ;
> Rebecca Cran ; Tom
Reviewed-by: Ray Ni
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, April 3, 2023 10:29 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Andrew
> Fish ; Kinney, Michael D ;
> Liu, Zhiguang ; Rebecca Cran
> ; Tom Lendacky ;
> Marvin Häuser
> Subject: [PATCH v4 3
Reviewed-by: Ray Ni
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, April 3, 2023 10:29 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Ni, Ray ; Andrew
> Fish ; Kinney, Michael D ;
> Liu, Zhiguang ; Rebecca Cran
> ; Tom Lendacky ;
> Marvin Häuser
> Subject: [PATCH v4 2
On Thu, Apr 06, 2023 at 01:15:21PM +0800, Chai, Evan wrote:
> Booting to uefi shell is verfied in Qemu mode,
> The qemu command be refered to '5a> Boot on QEMU' in
> https://github.com/riscv-admin/riscv-uefi-edk2-docs
>
Thanks! Evan for fixing this. The series LGTM.
Reviewed-by: Sunil V L
-=-
RiscVSbiLib was implemented in MdePkg/Library/BaseRiscVSbiLib.
Cc: Daniel Schaefer
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Evan Chai
---
Platform/RISC-V/PlatformPkg/Library/ResetSystemLib/ResetSystemLib.c
| 4 +++-
Platform/RISC-V/PlatformPkg/Library/ResetS
They had been implemented in MdePkg/Library/BaseLib
Cc: Daniel Schaefer
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Evan Chai
---
Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVCpuLib.h | 20
+---
Silicon/RISC-V/ProcessorPkg/Library/RiscVCpuLib/Cpu.S | 41
+--
It will be replaced by UefiCpuPkg/Library/BaseRiscV64CpuTimerLib.
Cc: Daniel Schaefer
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Evan Chai
---
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 11
++-
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U
UefiCpuPkg/CpuDxeRiscV64 will replace it later.
Cc: Daniel Schaefer
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Evan Chai
---
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 2 +-
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 2 +-
Pla
It will be replaced by UefiCpuPkg/CpuTimerDxeRiscV64.
Cc: Daniel Schaefer
Cc: Sunil V L
Cc: Andrei Warkentin
Signed-off-by: Evan Chai
---
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 2 +-
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 2 +
Booting to uefi shell is verfied in Qemu mode,
The qemu command be refered to '5a> Boot on QEMU' in
https://github.com/riscv-admin/riscv-uefi-edk2-docs
Evan Chai (5):
Silicon/RISC-V/ProcessorPkg: remove redundant CpuDxe driver
Platform/Sifive: remove redundant TimerDxe from Platform
Silicon
Booting to uefi shell is verfied in Qemu mode,
The qemu command be refered to '5a> Boot on QEMU' in
https://github.com/riscv-admin/riscv-uefi-edk2-docs
Evan Chai (5):
Silicon/RISC-V/ProcessorPkg: remove redundant CpuDxe driver
Platform/Sifive: remove redundant TimerDxe from Platform
Silicon
Hi Evan,
On Sun, Apr 02, 2023 at 11:15:37PM +0800, Chai, Evan wrote:
> *** BLURB HERE ***
>
This should be replaced with some valid cover letter for the series.
Also, please add [edk2-platforms] in the subject for the patch set.
Thanks,
Sunil
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
Hi Andrei,
I had couple of questions on previous version of this patch. Adding them
inline again in case you had missed them. Please check if they are
valid.
Also, I think it would be better to have single directory
BaseSerialPortLibRiscVSbiLib and inside that we can have both INF files.
This way
Hi Pedro,
Thank you for starting this.
I recall some challenges with the Openssl libc wrapper, so let's work on that
one last.
If we can get a libc wrapper that is compatible with Brotli, regular expression,
jannson, and fdtlib that would be a huge step forward.
Can you test your code against
Thanks Leif. Your understanding is right.
The openssl fork will be used by edk2-staging repo only.
The openssl fork will NOT be by edk2 repo.
Creating project specific fork is not unique.
For example, we already have other fork in tianocore -
https://github.com/tianocore/rust
For example, we alr
Okay, I'll do that.
Do I need to do the same with the CLANG35 and CLANG38 toolchains,
marking them deprecated before removing them?
--
Rebecca Cran
On 4/5/23 6:57 PM, gaoliming wrote:
Rebecca:
If you plan to change GCC49 tool chain to GCCNOLTO name, I would suggest to
take the same rul
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, April 6, 2023
7:30pm to 8:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e3
On April 3, 2023 7:21 PM, Gerd Hoffmann wrote:
> > > I agree that the efi variable store is not secure without smm. But
> > > after 58eb8517ad7b be introduced, the -D SECURE_BOOT_ENABLE doesn't
> > > work with SEV. System just hangs in "NvVarStore FV headers were invalid."
> > Hi, Joeyli
> > ASSERT
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Wednesday, April 5, 2023 6:06 PM
> To: devel@edk2.groups.io; Ard Biesheuvel ;
> Demeter, Miki ; Kinney,
> Michael D ; Leif Lindholm
>
> Cc: Rebecca Cran
> Subject: [edk
Ard:
Can you submit one BZ for this new feature? I will add it into the stable tag
feature planning.
For this patch set, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2023年4月4日 23:40
> 收件人: devel@edk2.groups.io
> 抄送: Ard Biesh
Acked-by: Liming Gao
> -邮件原件-
> 发件人: Michael D Kinney
> 发送时间: 2023年4月5日 2:22
> 收件人: devel@edk2.groups.io
> 抄送: Chris Johnson ; Liming Gao
> ; Zhiguang Liu
> 主题: [Patch v2 05/12] MdePkg: Add gmock examples
>
> From: Chris Johnson
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Michael D Kinney
> 发送时间: 2023年4月5日 2:22
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Zhiguang Liu
>
> 主题: [Patch v2 10/12] MdePkg/Library/BaseLib: HOST_APPLICATION
> IA32/X64 only
>
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Signed-off-by: Michael
We no longer use Gitbook for publishing the documentation.
Update the section to direct users to use the mailing list to
send feedback, and since we use GitHub Flavored Markdown, remove the
link to Gitbook.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
---
R
We no longer publish documentation to gitbook.com, instead
using tianocore-docs.github.io. Update the links to point
to the correct locations.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
Reviewed-by: Michael D Kinney
---
Readme.md | 117 +-
We stopped using Gitbook for publishing documentation a
while ago, and now use GitHub Flavored Markdown
and publish pages to Github Pages at tianocore-docs.github.io.
Fix the links to the draft documentation pages,
and update the text to point users to the mailing list
since they can no longer pro
We stopped using Gitbook for publishing documentation a
while ago, and now use GitHub Flavored Markdown
and publish pages to Github Pages at tianocore-docs.github.io.
Fix the links to the draft documentation pages,
and update the text to point users to the mailing list
since they can no longer pro
We stopped using Gitbook for publishing documentation a
while ago, and now use GitHub Flavored Markdown
and publish pages to Github Pages at tianocore-docs.github.io.
Fix the links to the draft documentation pages,
and update the text to point users to the mailing list
since they can no longer pro
Rebecca:
If you plan to change GCC49 tool chain to GCCNOLTO name, I would suggest to
take the same rule that adds GCCNOLTO tool chain first.
We still have downstream AARCH64 platforms to use GCC49 tool chain now.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
Seemly, you still uses Python2.7. Can you try Python 3 ?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 luming.jin via groups.io
发送时间: 2023年4月5日 19:35
收件人: devel@edk2.groups.io
主题: [edk2-devel] please help fix building error
Hello all
I am trying to build but with following error msg,
Cou
Rebecca:
I think this is a good solution to setup Edk2 development environment.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Rebecca Cran
> 发送时间: 2023年4月6日 4:54
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] RFC: Adding an alias to format patches with --stat= and
> --stat-graph
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Rebecca Cran
> 发送时间: 2023年4月6日 1:03
> 收件人: devel@edk2.groups.io; Bob Feng ; Liming
> Gao ; Yuwei Chen ;
> Michael D Kinney
> 抄送: Rebecca Cran
> 主题: [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default
>
> Update the antlr makefile t
Tinh,
You appear to be sending emails in quoted-printable format, while we
prefer them in 8bit encoding: quoted-printable causes issues such as
equals signs being replaced with "=3D" in the plain text for example.
Could you make sure you've run "python3 BaseTools/Scripts/SetupGit.py"
for th
Hi Leif,
Thanks for the review.
The work on this started in 2022, so the copyright dates
should be correct.
Rest of comments addressed below.
Mike
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, April 5, 2023 11:17 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc:
I've noticed several patches recently which has ellipses at the start of
the diffstat filenames.
When I started contributing to edk2 I remember being asked to always use
--stat=1000 --stat-graph-width=20 to avoid that problem: it's mentioned
in
https://github.com/tianocore/tianocore.github.io
Pushed as
https://github.com/tianocore/edk2/commit/2bb693894920e634153275bea60278a9f192a8ef
--
Rebecca Cran
On 4/5/23 11:15 AM, Rebecca Cran wrote:
Reviewed-by: Rebecca Cran
On 3/30/23 3:48 AM, Patrick Rudolph wrote:
The clang toolchain might default to fPIE/fPIC, which prevents
lld from
Thanks for sending this out, looks to be a pretty clean unit
testing interface. We are testing this now with some of
our unit tests and will update with any feedback.
In the meantime, for the patchset:
Reviewed-by: Oliver Smith-Denny
On 4/4/2023 11:22 AM, Michael D Kinney wrote:
REF: https://
On Wed, Apr 05, 2023 at 13:39:21 +0200, Gerd Hoffmann wrote:
> On Wed, Apr 05, 2023 at 01:37:23AM +, Yao, Jiewen wrote:
> > Hi
> > This is follow up for the "Openssl1.1 replacement proposal"
> > https://edk2.groups.io/g/devel/topic/96741156.
> > openssl 3.0 POC result is shown at
> > https://
On Tue, Apr 04, 2023 at 11:22:09 -0700, Michael D Kinney wrote:
> From: Chris Johnson
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389
>
> Add subhook submodule that is required to hook internal functions
> when using gmock.
>
> https://github.com/Zeex/subhook
>
> Add SubhookLi
On 2023-03-09 19:43, Kun Qin wrote:
This change added a markdown file as a policy guideline for Tianocore EDK2
community to handle security sensitive reports.
Patch v1 branch: https://github.com/kuqin12/edk2/tree/patch-1
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Miki Demeter
Hello all
I am trying to build but with following error msg,
Could you please help?
Active Platform =
/home/luming/01_work/01_project/8295/rse/sa8295p-hqx-4-5-5-1_amss_standard_oem/boot/boot_images/boot/QcomPkg/SocPkg/Makena/AU/Core.dsc
done!
#
build.py...
: error C0DE: Unknown f
Reviewed-by: Rebecca Cran
On 3/30/23 3:48 AM, Patrick Rudolph wrote:
The clang toolchain might default to fPIE/fPIC, which prevents
lld from linking the objects into a binary.
Specify -fno-pie -fno-pic as done on GCC to fix linking.
Test:
Building the Universal Payload using the command
'pyt
Sorry for the delay. I've just sent my reviewed-by.
On 4/4/23 3:46 AM, Ard Biesheuvel wrote:
Thanks all
Ray, any comments on this version? Thanks.
Liming, Rebecca, any comments on the BaseTools changes?
On Tue, 4 Apr 2023 at 09:57, Marvin Häuser wrote:
FWIW, Reviewed-by: Marvin Häuser
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 4/3/23 8:29 AM, Ard Biesheuvel wrote:
We rely on PIE executables to get the codegen that is suitable for
PE/COFF conversion where the resulting executables can be loaded
anywhere in the address space.
However, ELF linkers may default to disallowi
Update the antlr makefile to remove the explicit setting of CC to either
clang or gcc. This causes it to use /usr/bin/cc or whatever the user has
set $(CC) to.
This removes the last dependency on gcc for BaseTools.
Signed-off-by: Rebecca Cran
---
BaseTools/Source/C/VfrCompile/Pccts/antlr/makefi
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, April 6, 2023
8:00am to 9:00am
(UTC-07:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Joi
I will add a more complete description to the commit messages.
These patches are only for modules of type HOST_APPLICATION that are
used for host-based unit tests that run as a Windows or Linux application.
Many of the other HOST_APPLICATION components that are linked with
these components only l
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, April 6, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@ar
On Wed, Apr 05, 2023 at 01:37:23AM +, Yao, Jiewen wrote:
> Hi
> This is follow up for the "Openssl1.1 replacement proposal"
> https://edk2.groups.io/g/devel/topic/96741156.
> openssl 3.0 POC result is shown at
> https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-Ope
On Tue, 4 Apr 2023 at 20:36, Rebecca Cran wrote:
>
> Thanks, deprecating it for a while makes a lot of sense. We can consider
> removing it in 6-12 months maybe?
>
I would at least wait for a stable release to appear that supports
both GCC5 and GCC/GCCNOLTO, and then perhaps queue the removal (an
Hi,
Can anyone help to look into this?
Thanks.
On Tue, 4 Apr 2023 at 14:46, Lean Sheng Tan wrote:
>
> Hi Rebecca/ Marvin,
> Patrick has filed it as a separate patch email here
> https://edk2.groups.io/g/devel/message/102168
> However the email still group them together.
> It is because he could
On Tue, 4 Apr 2023 at 20:23, Michael D Kinney
wrote:
>
This patch has no commit log so it is hard to understand the purpose
of this patch.
> Cc: Michael Kubacki
> Cc: Nate DeSimone
> Signed-off-by: Michael D Kinney
> ---
> .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf | 2
51 matches
Mail list logo
