I will add a more complete description to the commit messages. These patches are only for modules of type HOST_APPLICATION that are used for host-based unit tests that run as a Windows or Linux application.
Many of the other HOST_APPLICATION components that are linked with these components only list IA32 and X64, so this change is to make all HOST_APPLICATION components consistent. The only host-based unit test environments that I am aware have been tested are 32-bit and 64-bit x86 OS environments. Additional host environments could be supported, but would require updates to the UnitTestFrameworkPkg and perhaps BaseTools and would also require CI agents or other testing to make sure it is functional and stays functional. If anyone is running host based unit tests with additional host os CPU architectures, then please let the UnitTestFrameworkPkg Maintainer know so we can get the components and docs updated. Also let us know if there are additional host os CPU architectures that need to be supported for host based unit test execution. Thanks, Mike > -----Original Message----- > From: Michael Kubacki <mikub...@linux.microsoft.com> > Sent: Wednesday, April 5, 2023 5:46 AM > To: Ard Biesheuvel <a...@kernel.org>; devel@edk2.groups.io; Kinney, Michael D > <michael.d.kin...@intel.com> > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> > Subject: Re: [edk2-devel] [Patch v2 12/12] PrmPkg/Library: HOST_APPLICATION > IA32/X64 only > > On 4/5/2023 3:50 AM, Ard Biesheuvel wrote: > > On Tue, 4 Apr 2023 at 20:23, Michael D Kinney > > <michael.d.kin...@intel.com> wrote: > >> > > > > This patch has no commit log so it is hard to understand the purpose > > of this patch. > > I think a message would be helpful as well. > > > > > >> Cc: Michael Kubacki <mikub...@linux.microsoft.com> > >> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > >> Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> > >> --- > >> .../UnitTest/DxePrmContextBufferLibUnitTestHost.inf | 2 +- > >> .../UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git > >> a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf > b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf > >> index 7cf6a16867d4..eefaddb10aaf 100644 > >> --- > >> a/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf > >> +++ > >> b/PrmPkg/Library/DxePrmContextBufferLib/UnitTest/DxePrmContextBufferLibUnitTestHost.inf > >> @@ -17,7 +17,7 @@ [Defines] > >> # > >> # The following information is for reference only and not required by > >> the build tools. > >> # > >> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 > > > > AArch64 also supports PRM so why are you removing it here? > > > You're correct. The firmware code supports AARCH64. I am not aware of > these host unit tests being run on a AARCH64 host so I was okay to > remove this until that was confirmed. Do you have more context Mike? > > > >> +# VALID_ARCHITECTURES = IA32 X64 > >> # > >> > >> [Sources] > >> diff --git > >> a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf > b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf > >> index 8aae1f7cd78a..fd4b44a9bf85 100644 > >> --- > >> a/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf > >> +++ > >> b/PrmPkg/Library/DxePrmModuleDiscoveryLib/UnitTest/DxePrmModuleDiscoveryLibUnitTestHost.inf > >> @@ -17,7 +17,7 @@ [Defines] > >> # > >> # The following information is for reference only and not required by > >> the build tools. > >> # > >> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 > >> +# VALID_ARCHITECTURES = IA32 X64 > >> # > >> > >> [Sources] > >> -- > >> 2.39.1.windows.1 > >> > >> > >> > >> > >> > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102556): https://edk2.groups.io/g/devel/message/102556 Mute This Topic: https://groups.io/mt/98066303/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
