Thanks Leif. Your understanding is right.
The openssl fork will be used by edk2-staging repo only.
The openssl fork will NOT be by edk2 repo.


Creating project specific fork is not unique.
For example, we already have other fork in tianocore - 
https://github.com/tianocore/rust
For example, we already have fork for openssl - 
https://github.com/open-quantum-safe/openssl

The idea here is similar.

Thank you
Yao, Jiewen


> -----Original Message-----
> From: Leif Lindholm <quic_llind...@quicinc.com>
> Sent: Thursday, April 6, 2023 2:32 AM
> To: devel@edk2.groups.io; kra...@redhat.com
> Cc: Yao, Jiewen <jiewen....@intel.com>
> Subject: Re: [edk2-devel] [RFC] [edk2-openssl fork] Add openssl fork repo to
> Tianocore to support OpenSSL11_EOL
> 
> On Wed, Apr 05, 2023 at 13:39:21 +0200, Gerd Hoffmann wrote:
> > On Wed, Apr 05, 2023 at 01:37:23AM +0000, Yao, Jiewen wrote:
> > > Hi
> > > This is follow up for the "Openssl1.1 replacement proposal"
> https://edk2.groups.io/g/devel/topic/96741156.
> > > openssl 3.0 POC result is shown at https://github.com/tianocore/edk2-
> staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md
> > > The size increase is reduced to ~10%.
> > >
> > > In order to achieve maximum size optimization for openssl 3.0, we
> > > updated openssl 3.0 branch and recorded to
> > > https://github.com/liyi77/openssl/tree/openssl-3.0-POC.
> > > To help the community review and feedback the openssl 3.0 change
> > > and plan to openssl upstream in the future, we should avoid
> > > personal branch usage.
> >
> > I fail to see the point.  To get the openssl changes merged upstream
> > you needed engage with the openssl community, and I don't see how a
> > tianocore openssl repository helps with that.
> 
> Here is my understanding:
> - There is a concern that this change may break existing use-cases,
>   and the proposal is to collate current state of work - undergoing
>   upstreaming to openssl - so that the tianocore community (and
>   downstream consumers) can start testing it with minimal amount of
>   faff.
> - There is *no* plan for the edk2 repository to switch to using this
>   submodule.
> 
> If that understanding is correct, as long as the README.md is updated
> to clearly state that this repository is for integration and
> verification purposes only - at the very top - I think this is a good
> thing.
> 
> /
>     Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102587): https://edk2.groups.io/g/devel/message/102587
Mute This Topic: https://groups.io/mt/98074585/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to