[GitHub] [whimsy] sebbASF commented on issue #99: Agenda tool remind-actions.json.rb says "Error: no emails were sent to " even when they were sent.

sebbASF commented on issue #99: URL: https://github.com/apache/whimsy/issues/99#issuecomment-730512368 I think the error message should be followed by a comma-separated list of the recipients whose emails could not be found. Maybe the list contains some invisible people; as a check I can

[GitHub] [whimsy] sebbASF closed pull request #100: Roster emeritus

sebbASF closed pull request #100: URL: https://github.com/apache/whimsy/pull/100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [whimsy] sebbASF commented on pull request #100: Roster emeritus

sebbASF commented on pull request #100: URL: https://github.com/apache/whimsy/pull/100#issuecomment-730516526 This has been implemented This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [whimsy] sebbASF opened a new issue #107: \s[8] might be a typo for \s{8} ?

sebbASF opened a new issue #107: URL: https://github.com/apache/whimsy/issues/107 https://github.com/apache/whimsy/blob/5b23bfc97e3c3b05ea03cfe76366a536ce68fc57/lib/whimsy/asf/agenda/discussion.rb#L15 @rubys It looks like the [8] might be a typo for {8}? --

[GitHub] [whimsy] sebbASF commented on issue #107: \s[8] might be a typo for \s{8} ?

sebbASF commented on issue #107: URL: https://github.com/apache/whimsy/issues/107#issuecomment-732294070 If it is really intended to match just '8', then the surrounding [] should be dropped This is an automated message from

[GitHub] [whimsy] rubys commented on issue #107: \s[8] might be a typo for \s{8} ?

rubys commented on issue #107: URL: https://github.com/apache/whimsy/issues/107#issuecomment-732317405 It is meant to match ```8```, the square brackets are unnecessary here. Presumably it was copied and adapted from another place where more than one character was matched. ---

[GitHub] [whimsy] sebbASF opened a new issue #108: Should '=' be '==' ?

sebbASF opened a new issue #108: URL: https://github.com/apache/whimsy/issues/108 https://github.com/apache/whimsy/blob/2ad1a7972e9e43744abc04497208b9fb04a4b310/lib/whimsy/asf/rack.rb#L153 @rubys The operator here looks odd. Is it supposed to be equality rather than assignment?

[GitHub] [whimsy] asfgit closed issue #107: \s[8] might be a typo for \s{8} ?

asfgit closed issue #107: URL: https://github.com/apache/whimsy/issues/107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [whimsy] rubys commented on issue #108: Should '=' be '==' ?

rubys commented on issue #108: URL: https://github.com/apache/whimsy/issues/108#issuecomment-732479079 This is supposed to be equality. Follow the link in the comment on line 150 to see the original code. Perhaps adding parens or splitting in two lines will placate whatever linter you ar

[GitHub] [whimsy] sebbASF commented on issue #108: Should '=' be '==' ?

sebbASF commented on issue #108: URL: https://github.com/apache/whimsy/issues/108#issuecomment-732488062 Do you mean assignment? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [whimsy] rubys commented on issue #108: Should '=' be '==' ?

rubys commented on issue #108: URL: https://github.com/apache/whimsy/issues/108#issuecomment-732489537 Yes, I meant the assignment operator. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [whimsy] asfgit closed issue #108: Should '=' be '==' ?

asfgit closed issue #108: URL: https://github.com/apache/whimsy/issues/108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [whimsy] royfielding opened a new issue #109: Agenda new action responding with 500 status

royfielding opened a new issue #109: URL: https://github.com/apache/whimsy/issues/109 This seems to be an odd one, perhaps caused by a recent change to committee-info or the process for reading that file, or maybe something in the December minutes. I am getting a 500 error from whim

[GitHub] [whimsy] rubys commented on issue #109: Agenda new action responding with 500 status

rubys commented on issue #109: URL: https://github.com/apache/whimsy/issues/109#issuecomment-748403052 See: * https://github.com/rails/rails/issues/40884 * https://lists.apache.org/thread.html/r125240a4bbf350bece8baf8bb78567bce21f3cbd1c128bf408787c12%40%3Cdev.whimsical.apache.org%

[GitHub] [whimsy] rubys closed issue #109: Agenda new action responding with 500 status

rubys closed issue #109: URL: https://github.com/apache/whimsy/issues/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [whimsy] royfielding commented on issue #109: Agenda new action responding with 500 status

royfielding commented on issue #109: URL: https://github.com/apache/whimsy/issues/109#issuecomment-748517605 confirmed fix, thanks Sam, This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [whimsy] rubys opened a new issue #110: Upgrade to Vue v3 or move back to React.js

rubys opened a new issue #110: URL: https://github.com/apache/whimsy/issues/110 Not urgent, but this work should be planned for. Summary * Vue.js version 3 was [released](https://github.com/vuejs/vue-next/releases/tag/v3.0.0?ref=madewithvuejs.com) in September of 2020. It is not

[GitHub] [whimsy] sebbASF commented on issue #110: Upgrade to Vue v3 or move back to React.js

sebbASF commented on issue #110: URL: https://github.com/apache/whimsy/issues/110#issuecomment-757136777 How does this compare with the proposal to rewrite in Node.js? This is an automated message from the Apache Git Service.

[GitHub] [whimsy] sebbASF commented on issue #110: Upgrade to Vue v3 or move back to React.js

sebbASF commented on issue #110: URL: https://github.com/apache/whimsy/issues/110#issuecomment-757136777 How does this compare with the proposal to rewrite in Node.js? This is an automated message from the Apache Git Service.

[GitHub] [whimsy] QiAnXinCodeSafe opened a new issue #111: There is a vulnerability in jQuery v1.11.1,upgrade recommended

QiAnXinCodeSafe opened a new issue #111: URL: https://github.com/apache/whimsy/issues/111 https://github.com/apache/whimsy/blob/a5cd50a028af4277c32d3612c0f474b29ee17a8e/www/members/js/jquery-1.11.1.min.js#L1 CVE-2015-9251 CVE-2019-11358 CVE-2020-11022 CVE-2020-11023 Recomme

[GitHub] [whimsy] clr-apache opened a new pull request #112: Update icla-account-requested.erb

clr-apache opened a new pull request #112: URL: https://github.com/apache/whimsy/pull/112 Add requested account name to acknowledgement email to user This is an automated message from the Apache Git Service. To respond to the

[GitHub] [whimsy] sebbASF merged pull request #112: Update icla-account-requested.erb

sebbASF merged pull request #112: URL: https://github.com/apache/whimsy/pull/112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [whimsy] jbampton opened a new pull request #113: chore: fix spelling

jbampton opened a new pull request #113: URL: https://github.com/apache/whimsy/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [whimsy] royfielding opened a new issue #114: update titles in agenda for new bylaws

royfielding opened a new issue #114: URL: https://github.com/apache/whimsy/issues/114 So, with the change to Board Chair, I am getting a 404 on the link to https://whimsy.apache.org/board/minutes/Board_Chair as opposed to some copy or redirect to https://whimsy.apac

[GitHub] [whimsy] sebbASF commented on issue #114: update titles in agenda for new bylaws

sebbASF commented on issue #114: URL: https://github.com/apache/whimsy/issues/114#issuecomment-797148742 The minutes are parsed by tools/collate_minutes.rb Project name changes are done here: https://github.com/apache/whimsy/blob/a876d2f90c9263c3cf781212bc135abd2bce790d/tools/collate_

[GitHub] [whimsy] sebbASF commented on issue #114: update titles in agenda for new bylaws

sebbASF commented on issue #114: URL: https://github.com/apache/whimsy/issues/114#issuecomment-797502685 Committed 0722e78 which I hope fixes it. Turns out the officer report name changes are done elsewhere This is an auto

[GitHub] [whimsy] royfielding commented on issue #114: update titles in agenda for new bylaws

royfielding commented on issue #114: URL: https://github.com/apache/whimsy/issues/114#issuecomment-797634149 Yes, that fixes it, thanks! But it looks like a duplicate redirect was added to .htaccess This is an automated mess

[GitHub] [whimsy] royfielding closed issue #114: update titles in agenda for new bylaws

royfielding closed issue #114: URL: https://github.com/apache/whimsy/issues/114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [whimsy] sebbASF commented on issue #114: update titles in agenda for new bylaws

sebbASF commented on issue #114: URL: https://github.com/apache/whimsy/issues/114#issuecomment-797827704 Oops -- good catch, fixed the dupe. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [whimsy] dave2wave opened a new pull request #115: Petri info.yaml has moved

dave2wave opened a new pull request #115: URL: https://github.com/apache/whimsy/pull/115 Reference the info.yaml file on the petri website This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [whimsy] sebbASF merged pull request #115: Petri info.yaml has moved

sebbASF merged pull request #115: URL: https://github.com/apache/whimsy/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [whimsy] clr-apache opened a new issue #116: Please include meeting date in board agenda page titles

clr-apache opened a new issue #116: URL: https://github.com/apache/whimsy/issues/116 Currently the page title changes from e.g. "2020-12-25" to "President" when the user navigates from the main page to the president's report. The possibly unintended side effect of this is that when u

[GitHub] [whimsy] sebbASF closed issue #116: Please include meeting date in board agenda page titles

sebbASF closed issue #116: URL: https://github.com/apache/whimsy/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] [whimsy] sebbASF commented on issue #116: Please include meeting date in board agenda page titles

sebbASF commented on issue #116: URL: https://github.com/apache/whimsy/issues/116#issuecomment-803185532 Hopefully fixed with c277085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [whimsy] clr-apache opened a new pull request #117: Update coi.cgi

clr-apache opened a new pull request #117: URL: https://github.com/apache/whimsy/pull/117 Remove cc: secretary when filing COI document -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [whimsy] clr-apache merged pull request #117: Update coi.cgi

clr-apache merged pull request #117: URL: https://github.com/apache/whimsy/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [whimsy] sstriker opened a new pull request #118: Change meeting duration to 1 hour

sstriker opened a new pull request #118: URL: https://github.com/apache/whimsy/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [whimsy] rubys merged pull request #118: Change meeting duration to 1 hour

rubys merged pull request #118: URL: https://github.com/apache/whimsy/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [whimsy] rubys commented on pull request #118: Change meeting duration to 1 hour

rubys commented on pull request #118: URL: https://github.com/apache/whimsy/pull/118#issuecomment-843213110 FYI, `1.hour` would have also worked. As would `60.minutes`. See https://api.rubyonrails.org/classes/Numeric.html#method-i-hours -- This is an automated message from the Apache G

[GitHub] [whimsy] sebbASF opened a new issue #119: Docker requires access to home directory

sebbASF opened a new issue #119: URL: https://github.com/apache/whimsy/issues/119 The Docker build currently requires read access to the entire user home directory in order to mount the file $HOME/.gitconfig. It also requires access to the .ssh and .subversion directories. It would

[GitHub] [whimsy] clr-apache opened a new pull request #120: Family First support in secretary workbench

clr-apache opened a new pull request #120: URL: https://github.com/apache/whimsy/pull/120 This patch adds support for the family first flag in ICLA.pdf. It adds pdf parsing for the form field. It modifies the handling of file name if the family first flag is set. No testing has been d

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886177003 I think the name parsing should be done in lib/whimsy/asf/person.rb alongside ldap_name, using an API of the form: sn, givenname = def ldap_parsecn(cn, familyfirst) Th

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886241940 I like the approach of creating a new common method sn, givenname = def ldap_parsecn(cn, familyfirst) This would eliminate a lot of unneeded parameters and variables and l

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886256847 The ldap_name method actually has code that looks for De and van etc.. This could perhaps be used if there are more than 3 words. But unless there are likely to be a lot of

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886277898 The code with De, de, Van, Von, van, von, etc. is interesting but having looked at many names over the past couple of months, I'm not convinced that an algorithm will end up bei

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886311824 Hi Sebb, I did not mean to disparage your efforts at figuring out the sn and given name from the cn. The algorithm in ldap_name is very sophisticated and we should see how t

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887082137 I have created a DRAFT method to split cn into sn and givenName: ASF::Person.ldap_parse_cn_DRAFT. However, AFAICT there is currently no way to actually use sn and givenName.

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887156529 This is great. Can you push it to the branch? I'd love to understand how you test this. Is there some test case infrastructure where we can add test cases? -- This is a

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887426891 The test cases are in lib/spec/lib/person_spec.rb. However, I think this is all moot. I don't think there is a use-case for the sn and givenName fields. INFRA have a

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887884985 Hi Sebb, I am inclined to agree with you that the only reason we have LDAP sn is to satisfy a schema requirement that an LDAP "person" needs a cn and an sn. I'd li

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887893058 "I'd like to understand when and where the decision was made that we should implement LDAP person." That's a question for Infra, but as far as I know, the ASF LDAP schema is

[GitHub] [whimsy] sebbASF merged pull request #113: chore: fix spelling

sebbASF merged pull request #113: URL: https://github.com/apache/whimsy/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@w

[GitHub] [whimsy] sebbASF commented on pull request #113: chore: fix spelling

sebbASF commented on pull request #113: URL: https://github.com/apache/whimsy/pull/113#issuecomment-888276989 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [whimsy] sebbASF commented on issue #119: Docker requires access to home directory

sebbASF commented on issue #119: URL: https://github.com/apache/whimsy/issues/119#issuecomment-894272806 .gitconfig did not appear to be used, so the Docker build has been updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [whimsy] sebbASF commented on issue #119: Docker requires access to home directory

sebbASF commented on issue #119: URL: https://github.com/apache/whimsy/issues/119#issuecomment-894273433 AFAICT .ssh and .subversion are not needed either -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [whimsy] clr-apache opened a new pull request #121: Update Gemfile

clr-apache opened a new pull request #121: URL: https://github.com/apache/whimsy/pull/121 Puma gem cannot be installed. It is not needed anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [whimsy] rubys merged pull request #121: Update Gemfile

rubys merged pull request #121: URL: https://github.com/apache/whimsy/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whi

[GitHub] [whimsy] dave2wave opened a new issue #122: WHIMSY-357 - Support git write of calendar.md in agenda tool

dave2wave opened a new issue #122: URL: https://github.com/apache/whimsy/issues/122 Since the apache.org website is now in git there needs to be support for writing (commit/push) in the git.rb module. Specifically updating `https://github.com/apache/www-site/blob/main/content/founda

[GitHub] [whimsy] dave2wave opened a new issue #123: Podling resolutionLink and resolutionUrl are not output in public_podlings.json

dave2wave opened a new issue #123: URL: https://github.com/apache/whimsy/issues/123 In c0198aa support for resolutionLink and resolutionUrl were added. For some reason these do not flow through to https://whimsy.apache.org/public/public_podlings.json -- This is an automated message from

[GitHub] [whimsy] asfgit closed issue #123: Podling resolutionLink and resolutionUrl are not output in public_podlings.json

asfgit closed issue #123: URL: https://github.com/apache/whimsy/issues/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsic

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702563 What is the use-case for this, now that the workbench does checks for name clashes? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894702891 The family first flag allows for the ICLA submitter to tell secretary that the names are culturally consistent. Secretary can then create the file name consistent with the curre

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894704206 We have already discussed that givenName and sn are not actually used, so it really does not matter what they are. givenName is optional to the LDAP schema, so can be omitted

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894710333 @sebbASF My interest in this is motivated by over 10 years of experience filing ICLAs and IMHO adding family first flag to the ICLA and secretary workbench is an improvement

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894711284 You still have not explained how it helps to know the whether the family name is first or not. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894711513 In case it is not obvious, I am -1 on applying this PR without a clear explanation of the benefit. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [whimsy] sebbASF commented on pull request #124: Fix spelling

sebbASF commented on pull request #124: URL: https://github.com/apache/whimsy/pull/124#issuecomment-894859021 Thanks, but there are still changes to the board agenda test data. Please don't change any of those files. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [whimsy] jbampton commented on pull request #124: Fix spelling

jbampton commented on pull request #124: URL: https://github.com/apache/whimsy/pull/124#issuecomment-894867619 @sebbASF all done now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [whimsy] sebbASF merged pull request #124: Fix spelling

sebbASF merged pull request #124: URL: https://github.com/apache/whimsy/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@w

[GitHub] [whimsy] gstein commented on pull request #120: Family First support in secretary workbench

gstein commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894875632 > We have already discussed that givenName and sn are not actually used, so it really does not matter what they are. Euh... those fields *are* used by some tools. They cannot

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-894877198 Note that givenName is optional according to the schema. I dropped mine (and some other ids don't have them) and I have not noticed any issues. As to sn, it needs to be pr

[GitHub] [whimsy] jvz commented on pull request #120: Family First support in secretary workbench

jvz commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-895595343 I think this helps maintain some consistency of data going forward. If you set up Apache LDAP in an address book, aren't those fields used for example? -- This is an automated messag

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-895598280 On Mon, 9 Aug 2021 at 23:33, Matt Sicker ***@***.***> wrote: > I think this helps maintain some consistency of data going forward. If you > set up Apache LDAP in an address

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-895634866 The motivation for this project is to help secretary perform the mission enumerated in the Bylaws: the Secretary shall have general charge of the corporate books and rec

[GitHub] [whimsy] rlenferink closed pull request #104: Update usage of http to https

rlenferink closed pull request #104: URL: https://github.com/apache/whimsy/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [whimsy] rlenferink commented on pull request #104: Update usage of http to https

rlenferink commented on pull request #104: URL: https://github.com/apache/whimsy/pull/104#issuecomment-895814565 Closing this PR as it has been open for quite some time and I don’t feel like constantly spending time resolving merge conflicts. -- This is an automated message from the Apac

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-895882841 -1 If the intention is to ensure that givenName and sn are accurate, then we should ask for them explicitly. But AFAICT there is no need for these. The FF flag does not

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896038607 > On Aug 10, 2021, at 2:37 AM, sebbASF ***@***.***> wrote: > > > -1 > If the intention is to ensure that givenName and sn are accurate, then we should ask f

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896049223 The last two ICLAs received were from Yu Zhou or Zhou Yu and Yi Yuan or Yuan Yi. Are we going to just guess what name to file them under and fix it later? Like we have do

[GitHub] [whimsy] gstein commented on pull request #120: Family First support in secretary workbench

gstein commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896052488 > by creating a file name that reflects the user's cultural ordering of the name Why is the user being burdened with specifying a filename for our internal records? We hide

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896091901 Thanks for adding your perspective. I'm trying to fix a problem that doesn't affect infra. It affects secretary. This handy tool (thanks, sebb) shows that there are

[GitHub] [whimsy] jvz commented on pull request #120: Family First support in secretary workbench

jvz commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896149336 Does this not help with ensuring consistency of file names? No secretary can be expected to understand 300 different languages and cultures, hence the addition of a flag to disambiguat

[GitHub] [whimsy] jvz edited a comment on pull request #120: Family First support in secretary workbench

jvz edited a comment on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896149336 Does this not help with ensuring consistency of file names? No secretary can be expected to understand 300 different languages and cultures, hence the addition of a flag to disa

[GitHub] [whimsy] gstein commented on pull request #120: Family First support in secretary workbench

gstein commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896190711 Which of these three file names is objectively best for you: `bumvle-thorpe.pdf thorpe-bumvle.pdf 33876.pdf` -- This is an automated message from the Apache Git Servic

[GitHub] [whimsy] gstein commented on pull request #120: Family First support in secretary workbench

gstein commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896192867 Why does the filename need to reflect a name, rather than simply be a rowid/primary-key? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [whimsy] sebbASF opened a new issue #125: How to file ICLAs

sebbASF opened a new issue #125: URL: https://github.com/apache/whimsy/issues/125 ICLAs are currently filed using a filename stem based on the full name. This approach increasingly suffers from collisions; it also has the potential to expose PII. We need to find a different id

[GitHub] [whimsy] ShaneCurcuru commented on pull request #120: Family First support in secretary workbench

ShaneCurcuru commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896803279 Immaterial of whether or not Infra has a use for some fields - or even if we have well-understood and thoroughly documented "how all tools use LDAP" somewhere - I fail to see

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-896811346 On Wed, 11 Aug 2021 at 13:56, Shane Curcuru ***@***.***> wrote: > Immaterial of whether or not Infra has a use for some fields - or even if > we have well-understood and

[GitHub] [whimsy] clr-apache merged pull request #120: Family First support in secretary workbench

clr-apache merged pull request #120: URL: https://github.com/apache/whimsy/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [whimsy] sebbASF commented on issue #125: How to file ICLAs

sebbASF commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-897568868 The advantage of the file hash is that it automatically detects exact duplicates, and collisions are vanishingly rare with the appropriate choice of hash function. It also does n

[GitHub] [whimsy] sebbASF commented on issue #125: How to file ICLAs

sebbASF commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-897648795 There are some issues to be sorted out: - how to handle ICLAs consisting of multiple parts (e.g. JPEGs) - how to handle ICLAs which need to be rotated: hash before or after rotatio

[GitHub] [whimsy] clr-apache commented on issue #125: How to file ICLAs

clr-apache commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-897685133 > On Aug 12, 2021, at 6:40 AM, sebbASF ***@***.***> wrote: > > > There are some issues to be sorted out: > > how to handle ICLAs consisting of multiple parts

[GitHub] [whimsy] sebbASF commented on issue #125: How to file ICLAs

sebbASF commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-897712967 The reason for wanting to keep the original hash is to detect exact duplicates. When content is adjusted, it may not get the same hash. We don't have to keep the original (it shou

[GitHub] [whimsy] dave2wave commented on issue #125: How to file ICLAs

dave2wave commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-897732212 This is an interesting topic and approach. One question to consider is if there is a way other than a contributor emailing secretary@? Perhaps there can be a web form somewhere that c

[GitHub] [whimsy] sebbASF commented on issue #125: How to file ICLAs

sebbASF commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-898010092 @dave2wave That is an entirely separate issue from how ICLAs are filed. Please start a separate issue for alternative ways to submit ICLAs. As to metadata for the existing ICLA fi

[GitHub] [whimsy] sebbASF commented on issue #125: How to file ICLAs

sebbASF commented on issue #125: URL: https://github.com/apache/whimsy/issues/125#issuecomment-899056202 It would probably be worth recording the following email meta-data as well: - email-from - message-id - date This would make it easier to link back to the original email.

[GitHub] [whimsy] clr-apache commented on pull request #126: Update parts.js.rb

clr-apache commented on pull request #126: URL: https://github.com/apache/whimsy/pull/126#issuecomment-944958514 Thanks for taking a look. We no longer ask for phone number; there is no place on the form for phone number. -- This is an automated message from the Apache Git Service. T

[GitHub] [whimsy] sebbASF commented on pull request #126: Update parts.js.rb

sebbASF commented on pull request #126: URL: https://github.com/apache/whimsy/pull/126#issuecomment-944890293 It would help to know why this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [whimsy] clr-apache opened a new pull request #126: Update parts.js.rb

clr-apache opened a new pull request #126: URL: https://github.com/apache/whimsy/pull/126 Remove "missing phone" from "incomplete ICLA" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [whimsy] sebbASF commented on a change in pull request #126: Update parts.js.rb

sebbASF commented on a change in pull request #126: URL: https://github.com/apache/whimsy/pull/126#discussion_r730400438 ## File path: www/secretary/workbench/views/parts.js.rb ## @@ -163,13 +163,6 @@ def render _input type: 'hidden', name: 'missing_email', value:

  1   2   3   >