sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-886177003
I think the name parsing should be done in lib/whimsy/asf/person.rb alongside ldap_name, using an API of the form: sn, givenname = def ldap_parsecn(cn, familyfirst) This would make it easier to test (and re-use) Also givenname can be omitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsical.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
