clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887884985
Hi Sebb, I am inclined to agree with you that the only reason we have LDAP sn is to satisfy a schema requirement that an LDAP "person" needs a cn and an sn. I'd like to understand when and where the decision was made that we should implement LDAP person. Moving forward, I'd agree that we could e.g. change all sn entries to the user's apache id and givenName entries to empty. Then the only thing we care about is LDAP cn which I'm fine with keeping and initializing to ICLA Public Name. Craig > On Jul 27, 2021, at 4:16 AM, sebbASF ***@***.***> wrote: > > > The test cases are in lib/spec/lib/person_spec.rb. > > However, I think this is all moot. > > I don't think there is a use-case for the sn and givenName fields. > INFRA have already said they are not interested in the fields [1]. > It so happens that the LDAP schema requires sn, but it could be set to 'N/A' or similar. > > It would be a lot simpler to completely ignore givenName, and set sn to a fixed value. > This would also have the advantage that there is less exposure of PII. > > Do we really need sn and givenName? > If so, what for? > > [1] https://issues.apache.org/jira/browse/INFRA-22087?focusedCommentId=17382350&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17382350 <https://issues.apache.org/jira/browse/INFRA-22087?focusedCommentId=17382350&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17382350> > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/whimsy/pull/120#issuecomment-887426891>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RBM6UFPQDZKV67JMMLTZ2ISRANCNFSM5A5YANHQ>. > Craig L Russell ***@***.*** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsical.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
