sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887426891
The test cases are in lib/spec/lib/person_spec.rb. However, I think this is all moot. I don't think there is a use-case for the sn and givenName fields. INFRA have already said they are not interested in the fields [1]. It so happens that the LDAP schema requires sn, but it could be set to 'N/A' or similar. It would be a lot simpler to completely ignore givenName, and set sn to a fixed value. This would also have the advantage that there is less exposure of PII. Do we *really* need sn and givenName? If so, what for? [1] https://issues.apache.org/jira/browse/INFRA-22087?focusedCommentId=17382350&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17382350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@whimsical.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
