Re: svn commit: r1151068 - /subversion/trunk/subversion/libsvn_subr/cmdline.c

2011-07-26 Thread Noorul Islam K M
s...@apache.org writes: > Author: stsp > Date: Tue Jul 26 12:09:32 2011 > New Revision: 1151068 > > URL: http://svn.apache.org/viewvc?rev=1151068&view=rev > Log: > * subversion/libsvn_subr/cmdline.c > (svn_cmdline_create_auth_baton): Convert 'space-before-paren' formatting > to 'no-space-bef

Re: Trivial patches pending review.

2011-07-26 Thread Noorul Islam K M
Noorul Islam K M writes: > Here is a list of patches that I submitted over a period of time but did > not get any response. I am listing it here, if in case anyone finds > time. > > http://svn.haxx.se/dev/archive-2011-06/0229.shtml This is committed in r1151044 by stsp. >

Re: [PATCH] Remove redundant comment line

2011-07-26 Thread Noorul Islam K M
Stefan Sperling writes: > On Tue, Jul 26, 2011 at 10:56:04AM +0530, Noorul Islam K M wrote: > >> "Noorul Islam K M" writes: >> >> > While reading code I found this unnecessary comment. >> > >> > Log >> > >> > [[[ >

Re: [PATCH] New test for 'svnadmin lslocks' and 'svnadmin rmlocks'

2011-07-26 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> New test for 'svnadmin lslocks' and 'svnadmin rmlocks'. >> >> * subversion/tests/cmdline/svnadmin_tests.py >> (test_lslocks_and_rmlocks): New test. >> (test_list): Add new test.

Trivial patches pending review.

2011-07-25 Thread Noorul Islam K M
Here is a list of patches that I submitted over a period of time but did not get any response. I am listing it here, if in case anyone finds time. http://svn.haxx.se/dev/archive-2011-06/0229.shtml http://svn.haxx.se/dev/archive-2011-07/0251.shtml http://svn.haxx.se/dev/archive-2011-07/0299.shtml

Re: [PATCH] Remove redundant comment line

2011-07-25 Thread Noorul Islam K M
"Noorul Islam K M" writes: > While reading code I found this unnecessary comment. > > Log > > [[[ > > * subversion/libsvn_wc/info.c > (build_info_for_entry): Remove redundant comment line. > > ]]] > > Thanks and Regards > No

Re: [PATCH] info_tests.py - Fix indentation.

2011-07-25 Thread Noorul Islam K M
"Noorul Islam K M" writes: > Attached is the patch that fixes indentation in info_tests.py. > > Log > [[[ > > * subversion/tests/cmdline/info_tests.py > (info_show_exclude): Fix indentation, remove a redundant blank > line, no functional chan

Re: [PATCH] New test for 'svnadmin lslocks' and 'svnadmin rmlocks'

2011-07-25 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> Index: subversion/tests/cmdline/svnadmin_tests.py >> === >> --- subversion/tests/cmdline/svnadmin_tests.py (revision 1150581) >>

Re: [PATCH] New test for 'svnadmin lslocks' and 'svnadmin rmlocks'

2011-07-25 Thread Noorul Islam K M
"Philip Martin" writes: > Noorul Islam K M writes: > >> +def test_lslocks_and_rmlocks(sbox): >> + "test 'svnadmin lslocks' and 'svnadmin rmlocks'" >> + >> + def verify_lslocks_output(expected, actual): >> +&

Re: [PATCH] - Fix issue 3690 - "svn log" with ignore property changes

2011-07-20 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> Philip Martin writes: >> >>> Noorul Islam K M writes: >>> >>>> +static svn_error_t * >>>> +props_only_receiver(void *baton, svn_log_entry_t *log_entry, apr_pool_t >>

Re: [PATCH] - Fix issue 3690 - "svn log" with ignore property changes

2011-07-20 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> +static svn_error_t * >> +props_only_receiver(void *baton, svn_log_entry_t *log_entry, apr_pool_t >> *pool) >> +{ >> + props_only_receiver_baton_t *rb = baton; >

Re: [PATCH] - Fix issue 3690 - "svn log" with ignore property changes

2011-07-20 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> From issue tracker: >> == >> Add an option to ignore files with only property changes and no content >> changes. >&

[PATCH] - Fix issue 3690 - "svn log" with ignore property changes

2011-07-20 Thread Noorul Islam K M
st_list): Add new test. * subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout (): add --props-only and --ignore-props-only help text. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/tests/cmdline

Re: [PATCH] Issue 3942 - Provide new subcommand on svnadmin to create a lock

2011-07-18 Thread Noorul Islam K M
"C. Michael Pilato" writes: > On 07/15/2011 08:58 AM, Noorul Islam K M wrote: > >> As first step I implemented the following syntax. >> >> svnadmin lock REPOS PATH USERNAME COMMENT-FILE >> >> I will add the optional TOKEN argument later. I h

[PATCH] Issue 3942 - Provide new subcommand on svnadmin to create a lock

2011-07-15 Thread Noorul Islam K M
Noorul Islam K M writes: > From: http://subversion.tigris.org/issues/show_bug.cgi?id=3942 > === > The svnadmin command currently allows you to list and remove locks. It > would be useful if you could also

Re: svn commit: r1145982 - in /subversion/trunk/subversion: svn/proplist-cmd.c tests/cmdline/tree_conflict_tests.py

2011-07-14 Thread Noorul Islam K M
Noorul Islam K M writes: > "Bert Huijben" writes: > >>> -Original Message----- >>> From: Noorul Islam K M [mailto:noo...@collab.net] >>> Sent: donderdag 14 juli 2011 7:18 >>> To: dev@subversion.apache.org >>> Cc: comm...@sub

Re: svn commit: r1145982 - in /subversion/trunk/subversion: svn/proplist-cmd.c tests/cmdline/tree_conflict_tests.py

2011-07-14 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: donderdag 14 juli 2011 7:18 >> To: dev@subversion.apache.org >> Cc: comm...@subversion.apache.org >> Subject: Re: svn commit: r114

[PATCH] Re: svn commit: r1145972 - in /subversion/trunk/subversion: libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c svn/changelist-cmd.c tests/cmdline/changelist_tests.py tests/cmdline/tree_conflict_tests.

2011-07-14 Thread Noorul Islam K M
Noorul Islam K M writes: > rhuij...@apache.org writes: > >>if (changelist_name) >> { >> - return svn_cl__try >> - (svn_client_add_to_changelist(targets, changelist_name, >> + SVN_ERR(svn_cl__try( >> +

Re: svn commit: r1145982 - in /subversion/trunk/subversion: svn/proplist-cmd.c tests/cmdline/tree_conflict_tests.py

2011-07-13 Thread Noorul Islam K M
rhuij...@apache.org writes: > Author: rhuijben > Date: Wed Jul 13 12:47:26 2011 > New Revision: 1145982 > > URL: http://svn.apache.org/viewvc?rev=1145982&view=rev > Log: > Resolve another review todo from issue #3779 "how to handle actual only nodes" > by making 'svn proplist' return a non zero ex

Re: svn commit: r1145972 - in /subversion/trunk/subversion: libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c svn/changelist-cmd.c tests/cmdline/changelist_tests.py tests/cmdline/tree_conflict_tests.py

2011-07-13 Thread Noorul Islam K M
bversion/svn/changelist-cmd.c > (svn_cl__changelist): Return an error when an error occurred, just like > the other svn commands that handle SVN_WC_PATH_NOT_FOUND. > > * subversion/tests/cmdline/changelist_tests.py > (add_remove_non_existent_target, >add_remove_unversion

Re: Recursive deletion of property throws unnecessary warning

2011-07-13 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: woensdag 13 juli 2011 9:38 >> To: Subversion >> Subject: Recursive deletion of property throws unnecessary warning >> >>

Recursive deletion of property throws unnecessary warning

2011-07-13 Thread Noorul Islam K M
Initial mail from Geoff Rowell is here. http://svn.haxx.se/dev/archive-2009-07/0191.shtml He said: - Subversion 1.6.3 on Windows When recursively deleting a property from a working copy, an unnecessary warning is thrown because the property isn't defined on the root working copy folder.

[PATCH] svnadmin- Change error strings to one that is already translated.

2011-07-12 Thread Noorul Islam K M
Log [[[ * subversion/svnadmin/main.c (parse_args): Change error strings to one that is already translated in the po files. Also use _(). Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/svnadmin/main.c

[PATCH] Return "Too many arguments" for 'svnadmin lslocks'

2011-07-12 Thread Noorul Islam K M
Log [[[ * subversion/svnadmin/main.c (subcommand_lslocks): Return better error message when too many arguments are passed to 'svnadmin lslocks'. Patch by: Noorul Islam K M ]]] Index: subversion/svnad

[PATCH] Fix regression in 'svn cl' add and remove operations on non-existent target.

2011-07-12 Thread Noorul Islam K M
ngelist_tests.py (add_remove_non_existent_target, add_remove_unversioned_target): New tests. (test_list): Run them. Patch by: Noorul Islam K M Found by: danielsh ]]] Index: subversion/tests/cmdline/changelist_tests.py ==

Re: [PATCH] New test for 'svnadmin lslocks' and 'svnadmin rmlocks'

2011-07-11 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> +def test_lslocks_and_rmlocks(sbox): >> + "test 'svnadmin lslocks' and 'svnadmin rmlocks'" >> + >> + def verify_lslocks_output(expected, actual): >> +""

[PATCH] New test for 'svnadmin lslocks' and 'svnadmin rmlocks'

2011-07-11 Thread Noorul Islam K M
Log [[[ New test for 'svnadmin lslocks' and 'svnadmin rmlocks'. * subversion/tests/cmdline/svnadmin_tests.py (test_lslocks_and_rmlocks): New test. (test_list): Run it. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/tests/cmdli

[PATCH] info_tests.py - Fix indentation.

2011-07-10 Thread Noorul Islam K M
Attached is the patch that fixes indentation in info_tests.py. Log [[[ * subversion/tests/cmdline/info_tests.py (info_show_exclude): Fix indentation, remove a redundant blank line, no functional change. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/tests

Re: [PATCH] Re: svn commit: r1143731 - /subversion/trunk/subversion/tests/cmdline/info_tests.py

2011-07-08 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Fri, Jul 08, 2011 at 10:08:55 +0530: > >> Daniel Shahaf writes: >> >> > rhuij...@apache.org wrote on Thu, Jul 07, 2011 at 09:44:12 -: >> > >> >> Author: rhuijben >> >>

Issue 3942 - Provide new subcommand on svnadmin to create a lock

2011-07-08 Thread Noorul Islam K M
From: http://subversion.tigris.org/issues/show_bug.cgi?id=3942 === The svnadmin command currently allows you to list and remove locks. It would be useful if you could also create locks. Suggested syntax would be something like:

[PATCH] Re: svn commit: r1143731 - /subversion/trunk/subversion/tests/cmdline/info_tests.py

2011-07-07 Thread Noorul Islam K M
t; Add testcase for issue #3787. >> >> * subversion/tests/cmdline/info_tests.py >> (info_show_exclude): New testcase. >> (test_list): Add info_show_exclude. >> >> Patch by: Noorul Islam K M >> (extended by me) >> >> Modified: >> su

[PATCH] Issue 3947 - subversion fails with incorrect home directory/HOME variable

2011-07-06 Thread Noorul Islam K M
f the configuration directory is non-readable. I think we should do the same in the above case also. Attached is the patch for this. Log [[[ * subversion/svn/main.c (main): Fallback to default config if the config directory is non-directory. Update comment to reflect the change. Patch

Test results using SERVER_MINOR_VERSION=6

2011-07-05 Thread Noorul Islam K M
Attached is the fails.log file for the tests that I ran using the following command. make check SERVER_MINOR_VERSION=6 I hope this will be useful to figure whether we need to fix those tests. Thanks and Regards Noorul fails.log.svn_minor_version_6.txt.gz Description: Binary data

Re: Test results using SERVER_MINOR_VERSION=4

2011-07-05 Thread Noorul Islam K M
Noorul Islam K M writes: > Attached is the fails.log and tests.log files for the tests that I ran > using the following command. > Actually only fails.log file is attached. I think that is sufficient. Thanks and Regards Noorul

Test results using SERVER_MINOR_VERSION=5

2011-07-05 Thread Noorul Islam K M
Attached is the fails.log file for the tests that I ran using the following command. make check SERVER_MINOR_VERSION=5 I hope this will be useful to figure whether we need to fix those tests. Thanks and Regards Noorul fails.log.svn_minor_version_5.txt.gz Description: Binary data

Re: [PATCH] run_tests.py - Restrict values to --server-minor-version.

2011-07-04 Thread Noorul Islam K M
s case. > I don't think it is possible. Log [[[ * build/run_tests.py (main): Restrict --server-minor-version to take values in the range 4-7. * subversion/tests/cmdline/svntest/main.py (_parse_options): Add cross-referencing comment. Patch by: Noorul Islam K M ]]] Thanks and R

Re: [PATCH] Fix for issue 3787

2011-07-04 Thread Noorul Islam K M
Noorul Islam K M writes: > "Bert Huijben" writes: > >>> -Original Message----- >>> From: Noorul Islam K M [mailto:noo...@collab.net] >>> Sent: maandag 4 juli 2011 18:05 >>> To: Daniel Shahaf >>> Cc: Subversion >>> Subje

[PATCH] run_tests.py - Restrict values to --server-minor-version.

2011-07-04 Thread Noorul Islam K M
Log [[[ * build/run_tests.py (main): Restrict --server-minor-version to take values in the range 4-7. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: build/run_tests.py === --- build/run_tests.py (revision

Re: Implement support for 'make check' variants

2011-07-04 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Mon, Jul 04, 2011 at 17:52:53 +0530: > >> Noorul Islam K M writes: >> >> An update >> >> > Daniel came up with idea of extending Makefile.in to support 'make >> > check' variants.

Re: [PATCH] Fix for issue 3787

2011-07-04 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: maandag 4 juli 2011 18:05 >> To: Daniel Shahaf >> Cc: Subversion >> Subject: Re: [PATCH] Fix for issue 3787 > >> [[[ >

Re: [PATCH] Fix for issue 3787

2011-07-04 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Apr 07, 2011 at 02:46:45PM +0530, Noorul Islam K M wrote: > >> Daniel Shahaf writes: >> >> > Noorul Islam K M wrote on Thu, Apr 07, 2011 at 10:17:49 +0530: >> > >>

Re: Implement support for 'make check' variants

2011-07-04 Thread Noorul Islam K M
Noorul Islam K M writes: An update > Daniel came up with idea of extending Makefile.in to support 'make > check' variants. > > 1. 'make check' with svnserve -T This was already implemented. Completed testing using "make svnserveautocheck THREADED=1"

[PATCH] Fix broken link to #partial-commit-access.

2011-07-03 Thread Noorul Islam K M
Found this while reading doc couple of weeks back. Log [[[ * docs/community-guide/general.part.html Fix broken link to #partial-commit-access. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: docs/community-guide/general.part.html

Issue #3690 - "svn log" with ignore property changes

2011-07-01 Thread Noorul Islam K M
I am revisiting this issue after 6 months. I stopped working on this because everyone was busy working towards 1.7 release. The then thread was getting little attention. Link to the issue is http://subversion.tigris.org/issues/show_bug.cgi?id=3690 and following is the initial comment in the issu

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Noorul Islam K M
Johan Corveleyn writes: > Hi, > > Sometimes, a (part of a) working copy gets corrupted (errors like > 'checksum mismatch ...' while running 'update'). Maybe it happened > because a third-party tool has messed with the base files, or with the > entries file, or ... or maybe it happened because of

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Noorul Islam K M
Noorul Islam K M writes: > Daniel Shahaf writes: > >> Reads fine. >> >> I'd like to test this patch (perhaps later this week?). >> > > I tested with short_circuit configuration. I did not see any errors. > >> Would >> make davautocheck

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Noorul Islam K M
Daniel Shahaf writes: > Reads fine. > > I'd like to test this patch (perhaps later this week?). > I tested with short_circuit configuration. I did not see any errors. > Would > make davautocheck ENVVAR=short_circuit > be a better interface? > I made it this way. make davautocheck SVN_PATH

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
Stefan Sperling writes: > On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > >> On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: >> >>+svn bisect start [-rN[:M]] >> >>+ >> >When we discussed you had a concern that above syntax is

[Arwin Arni] Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
This mail missed dev@ list. Forwarding it. --- Begin Message --- On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > ar...@apache.org writes: > >> Author: arwin >> Date: Tue Jun 28 08:43:40 2011 >> New Revision: 1140482 >> >> URL: http://svn.apache.or

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
ar...@apache.org writes: > Author: arwin > Date: Tue Jun 28 08:43:40 2011 > New Revision: 1140482 > > URL: http://svn.apache.org/viewvc?rev=1140482&view=rev > Log: > Added a branch readme. > * BRANCH-README : New file. > > Added: > subversion/branches/svn-bisect/BRANCH-README > > Added: subver

[PATCH] Re: Implement support for 'make check' variants

2011-06-27 Thread Noorul Islam K M
Noorul Islam K M writes: > Daniel came up with idea of extending Makefile.in to support 'make > check' variants. > > 1. 'make check' with svnserve -T > 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in >(1.4, 1.5

[PATCH] Fix for issue #3938 - revert throws an error for unversioned targets

2011-06-24 Thread Noorul Islam K M
Log [[[ Fix for issue #3938. Make 'svn revert' to skip unversioned targets. * subversion/libsvn_client/revert.c (revert): Send 'skip' notification when svn_wc_revert4() returns SVN_ERR_WC_PATH_NOT_FOUND. Patch by: Noorul Islam K M ]]] Thanks and Regards Nooru

Re: [PATCH] Follow-up to r1138830. Fix comment in test.

2011-06-23 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > [[[ > > Follow-up to r1138830. Remove comment in test which became absolute > after r1138830. Add new comment related to issue #3936. > > * subversion/tests/cmdline/log_tests.py > (log_with_unrelated_peg_and_operative_revs): Fix absolu

[PATCH] Follow-up to r1138830. Fix comment in test.

2011-06-23 Thread Noorul Islam K M
Log [[[ Follow-up to r1138830. Remove comment in test which became absolute after r1138830. Add new comment related to issue #3936. * subversion/tests/cmdline/log_tests.py (log_with_unrelated_peg_and_operative_revs): Fix absolute comment and add new relevant one. Patch by: Noorul Islam

Implement support for 'make check' variants

2011-06-23 Thread Noorul Islam K M
Daniel came up with idea of extending Makefile.in to support 'make check' variants. 1. 'make check' with svnserve -T 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in (1.4, 1.5, 1.6, 1.7)) 3. 'make check' with SVNPathAuthz short_circuit. As of now this is supported by st

Re: [PATCH] Fix for issue 3813

2011-06-23 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Jun 23, 2011 at 03:25:37PM +0530, Noorul Islam K M wrote: > >> I thought if the patch was incorrect, I might be getting some feedback. > > Sorry, sometimes things just fall through the cracks :( > > Please don't take this as somethin

Re: [PATCH] Fix for issue 3931.

2011-06-23 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Jun 23, 2011 at 04:02:23PM +0530, Noorul Islam K M wrote: > >> >> Log >> >> [[[ >> >> Fix for issue 3931. 'svn log' is returning log of unrelated path when >> peg revision is not related to ope

[PATCH] Fix for issue 3931.

2011-06-23 Thread Noorul Islam K M
operative revision range. * subversion/tests/cmdline/log_tests.py (log_with_unrelated_peg_and_operative_revs): Remove XFail marker. Fix expected error message. Patch by: Noorul Islam K M ]]] Index: subversion/tests/cmdline/lo

Re: [PATCH] Fix for issue 3813

2011-06-23 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: donderdag 23 juni 2011 5:44 >> To: Daniel Shahaf >> Cc: Julian Foad; Subversion; Bert Huijben >> Subject: Re: [PATCH] Fix for issue 381

Re: [PATCH] Fix for issue 3813

2011-06-22 Thread Noorul Islam K M
Daniel Shahaf writes: > Looks like Bert committed a functionally equivalent fix as part of r1138474. > Bert, May I know why this patch was not considered? Looking at the commit I could not see any difference. Thanks and Regards Noorul > Noorul Islam K M wrote on Wed, Jun 22, 2011 at

Re: Improved docs for custom diff3 command

2011-06-22 Thread Noorul Islam K M
Julian Foad writes: > On Mon, 2011-06-20 at 11:31 +0800, Arpe, Kevin C wrote: > >> Hi, >> >> I am a Subversion command-line tools user on Windows XP. >> Version string = svn, version 1.6.12 (r955767) / compiled Jun 21 2010, >> 16:00:59 >> >> I wrote my own diff3 command batch file. We use it

Re: [PATCH] Fix for issue 3813

2011-06-22 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Subject: Re: [PATCH] Fix for issue 3813 > [...] >> [[[ >> Fix for issue 3813. >> [...] >> ]]] > > Hi Noorul. Please always include a brief description of the issue in > the email subject line

[PATCH] Fix for issue 3813

2011-06-21 Thread Noorul Islam K M
file. Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Index: subversion/libsvn_wc/diff_editor.c === --- subversion/libsvn_wc/diff_editor.c (revision 1137953) +++ subversion/libsvn_wc/diff_editor.c (working copy) @@ -1

[PATCH] Remove redundant comment line

2011-06-07 Thread Noorul Islam K M
While reading code I found this unnecessary comment. Log [[[ * subversion/libsvn_wc/info.c (build_info_for_entry): Remove redundant comment line. ]]] Thanks and Regards Noorul Index: subversion/libsvn_wc/info.c === --- subver

Re: [PATCH] Re: svn commit: r1071809 - in /subversion/trunk: build/run_tests.py subversion/tests/cmdline/svntest/main.py win-tests.py

2011-06-06 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 28, 2011 at 10:03:45AM +0530, Noorul Islam K M wrote: > >> >> Pinging to get some attention to this thread. >> > >> > Hi Noorul, >> > >> > I can't evaluate this patch since I don't

[PATCH] Re: Bug in exporting externals?

2011-06-01 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> Noorul Islam K M writes: >> >>> While working on issue 3799, in one of the review comments julianf said >>> the following about number 10 test in external_tests.py. >>> >>> >>&

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Noorul Islam K M
Julian Foad writes: > On Tue, 2011-05-31 at 14:52 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > Noorul Islam K M wrote: >> > >> >> Noorul Islam K M writes: >> >> > Julian Foad writes: >> > [...] >>

Re: Bug in exporting externals?

2011-05-31 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> While working on issue 3799, in one of the review comments julianf said >> the following about number 10 test in external_tests.py. >> >> >> A/B/gamma is only an external: it does not appear in the

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-31 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> > Julian Foad writes: > [...] >> >> * Use SVN_ERR instead of svn_error_clear. There 'kind' variable is not >> >> guaranteed to be set to a valid value if

Re: Bug in exporting externals?

2011-05-31 Thread Noorul Islam K M
Noorul Islam K M writes: > While working on issue 3799, in one of the review comments julianf said > the following about number 10 test in external_tests.py. > > > A/B/gamma is only an external: it does not appear in the WC until > Subversion processes the external definition

Re: Bug in exporting externals?

2011-05-30 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: maandag 30 mei 2011 12:17 >> To: Subversion >> Subject: Bug in exporting externals? >> >> >> While working on iss

Bug in exporting externals?

2011-05-30 Thread Noorul Islam K M
While working on issue 3799, in one of the review comments julianf said the following about number 10 test in external_tests.py. A/B/gamma is only an external: it does not appear in the WC until Subversion processes the external definitions. It looks to me like that failure was showing us a bug

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-25 Thread Noorul Islam K M
Noorul Islam K M writes: > Julian Foad writes: > >> Just taking a quick look. >> >> * Please always include the log message with the patch. >> > > I did include the log message in one of the previous mails. Since there > was no change to the log mess

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-25 Thread Noorul Islam K M
(export_file_overwrite_with_force): New test (test_list): Add reference to new test * subversion/tests/cmdline/externals_tests.py (export_wc_with_externals): Fix failing test by passing --force. Patch by: Noorul Islam K M ]]] > * Why does that externals test (number 10) need "--f

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-24 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Tue, May 24, 2011 at 15:39:10 +0530: > >> Philip Martin writes: >> >> > Noorul Islam K M writes: >> > >> >> Index: subversion/libsvn_client/export.c >> >>

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-24 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> Philip Martin writes: >> >>> Noorul Islam K M writes: >>> >>>> Index: subversion/libsvn_client/export.c >>>> =

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-24 Thread Noorul Islam K M
Stefan Sperling writes: > On Fri, May 20, 2011 at 01:04:18PM +0200, Stefan Sperling wrote: > >> On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote: >> > Pinging again. >> >> Looking into this... > > Noorul, > > unfortunately your

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-24 Thread Noorul Islam K M
Philip Martin writes: > Noorul Islam K M writes: > >> Index: subversion/libsvn_client/export.c >> === >> --- subversion/libsvn_client/export.c(revision 1071880) >> +++ subversion/libsvn_client

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-05-20 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> Gavin Baumanis writes: >> >>> Hi Noorul, >>> >>> Just a quick message to see if you're still working on this patch or not? >>> My threads stop at the comments below from Andrew

Re: [PATCH] Followup to r1089786.

2011-04-25 Thread Noorul Islam K M
Noorul Islam K M writes: > Log > [[ > Follow-up to r1089786. > > * subversion/svn/main.c > (main): Replace macro usage by constant output. > > Patch by: Noorul Islam K M > ]] > > Thanks and Regards > Noo

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-04-25 Thread Noorul Islam K M
Noorul Islam K M writes: > Gavin Baumanis writes: > >> Hi Noorul, >> >> Just a quick message to see if you're still working on this patch or not? >> My threads stop at the comments below from Andrew? >> > > Someone has to review this and if everyth

Re: 1.7 Roadmap Items Evaluation

2011-04-11 Thread Noorul Islam K M
"C. Michael Pilato" writes: > "Remove obliterate code": I think the obliterate code is all tucked away in > private functions and such at this point. Is that as far as we plan to take > this in 1.7? If not, the purge of this stuff would be some pretty > low-hanging fruit for a would-be contrib

[PATCH] Followup to r1089786.

2011-04-07 Thread Noorul Islam K M
Log [[ Follow-up to r1089786. * subversion/svn/main.c (main): Replace macro usage by constant output. Patch by: Noorul Islam K M ]] Thanks and Regards Noorul Index: subversion/svn/main.c === --- subversion/svn/main.c

Re: [PATCH] Fix for issue 3787

2011-04-07 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Thu, Apr 07, 2011 at 10:17:49 +0530: > >> Index: subversion/libsvn_client/info.c >> === >> --- subversion/libsvn_client/info.c (revision 1089373) >>

Re: [PATCH] Fix for issue 3787

2011-04-06 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Mar 10, 2011 at 04:49:32PM +0530, Noorul Islam K M wrote: > >> >> >From issue tracker >> (http://subversion.tigris.org/issues/show_bug.cgi?id=3787) >> >> It would be ever-so-helpful to folks looking to capture and

Re: [PATCH] Fix for issue 3799 - exporting file should not overwrite

2011-04-05 Thread Noorul Islam K M
mitted updated patch. After that this thread has got no updates. Thanks and Regards Noorul > > > On 01/03/2011, at 12:25 AM, Bolstridge, Andrew wrote: > >> >>> -Original Message- >>> From: Julian Foad [mailto:julian.f...@wandisco.com] >>> Sent: 2

[Noorul Islam K M] Re: [PATCH] Fix for issue 3826

2011-03-15 Thread Noorul Islam K M
I wonder, why this patch was not considered for fixing issue 3826. I could see a fix 1081799 which I see very similar to what I have done. Did I miss anything here? Thanks and Regards Noorul --- Begin Message --- Julian Foad writes: > On Thu, 2011-03-03 at 22:48 +0530, Noorul Islam K M wr

[PATCH] Fix for issue 3787

2011-03-10 Thread Noorul Islam K M
_node_walk_children. (svn_client_info3): Add new parameter. Pass this to crawl_entries. * subversion/svn/info-cmd.c (svn_cl__info): Pass show_exclude option to svn_client_info3. * subversion/tests/cmdline/depth_tests.py (info_show_exclude): New test. (test_list): Run it. Pat

Re: [PATCH] - Fix for issue #3792

2011-03-09 Thread Noorul Islam K M
Hyrum K Wright writes: > On Wed, Mar 9, 2011 at 5:48 AM, Stefan Sperling wrote: > >> On Wed, Mar 09, 2011 at 10:51:19AM +0530, Noorul Islam K M wrote: >>> I fixed the warning issue. Is there anything else do be done with this >>> patch? >> >> Nothing

[PATCH] Remove entry of test for issue #3792.

2011-03-09 Thread Noorul Islam K M
Log [[[ * notes/xfail-status: Remove entry of test for issue #3792. Test passes now. ]]] Thanks and Regards Noorul Index: notes/xfail-status === --- notes/xfail-status (revision 1079793) +++ notes/xfail-status (working copy) @@

Re: [PATCH] - Fix for issue #3792

2011-03-08 Thread Noorul Islam K M
Noorul Islam K M writes: > Stefan Sperling writes: > >> On Thu, Mar 03, 2011 at 10:39:11PM +0530, Noorul Islam K M wrote: >> >>> @@ -164,9 +171,18 @@ >>>if (tmpinfo->depth == svn_depth_unknown) >>> tmpinfo->depth = svn_depth_infin

Re: [PATCH] Fix for issue 3826

2011-03-08 Thread Noorul Islam K M
Julian Foad writes: > On Thu, 2011-03-03 at 22:48 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > On Wed, 2011-03-02, Noorul Islam K M wrote: >> > >> >> Please find attached patch for issue 3826. All tests pass using 'make

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Noorul Islam K M
Stefan Sperling writes: > On Thu, Mar 03, 2011 at 10:39:11PM +0530, Noorul Islam K M wrote: > >> @@ -164,9 +171,18 @@ >>if (tmpinfo->depth == svn_depth_unknown) >> tmpinfo->depth = svn_depth_infinity; >> >> - SVN_ERR(svn_wc__

Re: [PATCH] Fix for issue 3826

2011-03-03 Thread Noorul Islam K M
Julian Foad writes: > On Wed, 2011-03-02, Noorul Islam K M wrote: > >> Please find attached patch for issue 3826. All tests pass using 'make >> check' > [...] >> Index: subversion/svn/diff-cmd.c >> ===

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Noorul Islam K M
Stefan Sperling writes: > On Sat, Feb 05, 2011 at 12:55:55PM +0530, Noorul Islam K M wrote: > >> Daniel Shahaf writes: >> >> @@ -363,6 +364,9 @@ >> >> SVN_ERR(svn_cmdline_printf(pool, _("Copied From Rev: %ld\n"), >> >&

Re: [PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
Daniel Becroft writes: > On Thu, Mar 3, 2011 at 3:34 AM, Noorul Islam K M wrote: > >> >> Please find attached patch for issue 3826. All tests pass using 'make >> check' >> > > Hey Noorul, > > I had a quick look at this issue last night.

Re: [PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
Daniel Becroft writes: > On Thu, Mar 3, 2011 at 3:34 AM, Noorul Islam K M wrote: > >> >> Please find attached patch for issue 3826. All tests pass using 'make >> check' >> > > Hey Noorul, > > I had a quick look at this issue last night.

[PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
sion/tests/cmdline/diff_tests.py (diff_abs_localpath_from_wc_folder): Fix test to use correct absolute path. Remove XFail marker. Patch by: Noorul Islam K M Found by: danielsh ]]] Index: subversion/tests/cmdline/diff_tests.py === ---

Re: [PATCH] New XFail test for issue 3826

2011-03-01 Thread Noorul Islam K M
Daniel Shahaf writes: > r1076100. Review below. > > Noorul Islam K M wrote on Wed, Mar 02, 2011 at 09:33:54 +0530: >> Index: subversion/tests/cmdline/diff_tests.py >> === >> --- subversion/tests/cmdlin

Re: [PATCH] Fix ctypes-python tests by clearing pool

2011-03-01 Thread Noorul Islam K M
Daniel Shahaf writes: > Noorul Islam K M wrote on Wed, Mar 02, 2011 at 07:36:08 +0530: > >> Noorul Islam K M writes: >> > Noorul Islam K M writes: >> >> This patch fixes some minor issues with ctypes-python. Now we are >> >>

  1   2   3   4   >