"Bert Huijben" <b...@qqmail.nl> writes: >> -----Original Message----- >> From: Noorul Islam K M [mailto:noo...@collab.net] >> Sent: donderdag 23 juni 2011 5:44 >> To: Daniel Shahaf >> Cc: Julian Foad; Subversion; Bert Huijben >> Subject: Re: [PATCH] Fix for issue 3813 >> >> Daniel Shahaf <d...@daniel.shahaf.name> writes: >> >> > Looks like Bert committed a functionally equivalent fix as part of > r1138474. >> > >> >> Bert, >> >> May I know why this patch was not considered? Looking at the commit I >> could not see any difference. > > Applying a one line patch takes me 5 times more time than just editing the > code. And as the final whitespace (and comment) didn't match your original > patch, adding a patch by wasn't really appropriate. >
I thought if the patch was incorrect, I might be getting some feedback. > Discussion on irc showed that we couldn't just apply the patch without the > additional work from Stefan as that would open a window where somebody could > look at otherwise hidden files. (I assumed he would apply your patch after > that, but later I just applied the change anyway) > > I just added a 'found by' to the log message of r1138474. > It was actually found by Daniel. Thanks and Regards Noorul
