Re: [PATCH] Fix for issue 3787

[Noorul Islam K M]

"Bert Huijben" <b...@qqmail.nl> writes:

>> -----Original Message-----
>> From: Noorul Islam K M [mailto:noo...@collab.net]
>> Sent: maandag 4 juli 2011 18:05
>> To: Daniel Shahaf
>> Cc: Subversion
>> Subject: Re: [PATCH] Fix for issue 3787
>  
>> [[[
>> 
>> Fix for issue 3787. Make 'svn info --depth' variants display minimal
>> information about nodes with depth exclude in the tree.
>> 
>> * subversion/libsvn_client/info.c
>>   (crawl_entries): Pass TRUE to svn_wc__node_walk_children() as
>>     show_hidden parameter value.
>> 
>> * subversion/tests/cmdline/depth_tests.py
>>   (info_show_exclude): New test.
>>   (test_list): Run it.
>> 
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> 
>> ]]]
>
> (Please look in your irc log. We talked about this on IRC before)
>
> This simple fix makes that the code also gets not-present and  server
> excluded nodes. But the info api (and the output) don't handle these cases. 
>
> Switching the 'show hidden' flag requires more work in the callback to hide
> all unexpected hidden kinds.
>
>       Bert

In those cases build_info_for_entry() is throwing error. Is that not
good enough?

<code>
  else if (status == svn_wc__db_status_not_present
           || status == svn_wc__db_status_server_excluded)
    {
      return svn_error_createf(SVN_ERR_WC_PATH_NOT_FOUND, NULL,
                               _("The node '%s' was not found."),
                               svn_dirent_local_style(local_abspath,
                                                      scratch_pool));
    }
</code>

Thanks and Regards
Noorul