Re: Ruby SWIG bindings fail to build with upcoming GCC-15 release

2025-04-05 Thread Jun Omae
/lists.apache.org/thread/h2687xzt7r9ylgzj2vpz8ox2xxysptq7 -- Jun Omae (大前 潤)

Re: Ruby SWIG bindings fail to build with upcoming GCC-15 release

2025-04-04 Thread Jun Omae
On 2025/04/03 20:23, Nathan Hartman wrote: > On Wed, Apr 2, 2025 at 10:53 PM James McCoy wrote: > > On Thu, Apr 03, 2025 at 11:10:29AM +0900, Jun Omae wrote: > >Hi, > > > >On 2025/04/03 10:27, James McCoy wrote: > >> As noted in the [porting

Re: Ruby SWIG bindings fail to build with upcoming GCC-15 release

2025-04-04 Thread Jun Omae
On 2025/04/03 11:52, James McCoy wrote: > On Thu, Apr 03, 2025 at 11:10:29AM +0900, Jun Omae wrote: >> Hi, >> >> On 2025/04/03 10:27, James McCoy wrote: >>> As noted in the [porting docs], GCC-15 uses c23 (well, gnu23) by >>> default. This causes -Wincompat

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-03 Thread Jun Omae
nimal client, it uses `repr` but `__repr__` method of `Notification` class is not defined. I'd suggest to add the `__repr__` method. [[[ @@ -131,6 +140,8 @@ class Client(asynchat.async_chat): class Notification(object): def __init__(self, data): self.__dict__.update(data) + def __repr__(self): +return '%s(%r)' % (self.KIND, self.__dict__) class Commit(Notification): KIND = 'COMMIT' ]]] Finally, `cc` and `mc` methods in the minimal client should have `url` parameter. [[[ --- svnpubsub-client.py.orig 2024-12-04 06:25:33.083708157 +0900 +++ svnpubsub-client.py2024-12-02 10:28:30.489176287 +0900 @@ -1,10 +1,10 @@ -def cc(o): +def cc(url, o): print("commit " + repr(o)) def ec(url, type, o): print("event on " + repr(url) + ": " + repr(type) + "\n" + repr(o)) -def mc(o): +def mc(url, o): print("metadata " + repr(o)) import client ]]] -- Jun Omae (大前 潤)

Re: autoconf out-of-tree builds broken

2024-11-25 Thread Jun Omae
x27;))), > - 'tests/cmdline/svneditor.sh') > + svneditor_script = os.path.join(sys.path[0], 'svneditor.sh') > > # Username and password used by the working copies > wc_author = 'jrandom' > ]]] > > What do you think? Did it work for you? The patch looks good to me (tested in tree and out-of-tree builds). However, I think "# This script is in the build tree, ..." comment should be removed also. -- Jun Omae (大前 潤)

Re: svn commit: r1921524 - /subversion/branches/1.14.x/STATUS

2024-11-17 Thread Jun Omae
@ Candidate changes: >> votes: >> +1: jun66j5 >> >> + * r1921505 >> + Make swig-py compatible with SWIG 4.3.0. >> + Justification: >> + Ditto. >> + votes: >> + +1: jun66j5 >> + >> Veto-blocked changes: >> = -- Jun Omae (大前 潤)

swig-rb: Unable to build with msvc and svn/util.rb not work with x64-mswin64

2024-11-02 Thread Jun Omae
confirmed that the tests for swig-rb pass on Windows [3], could someone please test it? [1] https://github.com/jun66j5/ruby-build/releases/tag/v20241013 [2] https://github.com/MSP-Greg/ruby-loco/releases/tag/ruby-master [3] https://github.com/jun66j5/subversion-build/actions/runs/11640686568 --

Re: check-swig-rb failures with SWIG 4.3.0

2024-10-23 Thread Jun Omae
On 2024/10/22 6:07, Andreas Stieger wrote: > > On 2024-10-18 16:52, Andreas Stieger wrote >> >> On 2024-10-18 07:57, Jun Omae wrote: >>> I created patches and tested with SWIG 3.0.12, 4.2.1, 4.3.0-beta1. >>> >>>   - swig-4.3.0-swig-rb.patch.txt  

Re: Windows build complaining about missing 'ruby'

2024-10-23 Thread Jun Omae
On 2024/10/07 18:38, Johan Corveleyn wrote: > On Sun, Oct 6, 2024 at 10:17 PM Johan Corveleyn wrote: >> >> On Sat, Oct 5, 2024 at 8:20 AM Jun Omae wrote: >> ... >>>> Yes, that looks good to me. The warning is gone :-). >> Thanks again! >> >>

Re: check-swig-rb failures with SWIG 4.3.0

2024-10-17 Thread Jun Omae
.x) - swig-4.3.0-swig...@trunk.patch.txt (swig-py for trunk) - swig-4.3.0-swig...@1.14.x.patch.txt (swig-py for 1.14.x) Could anybody please test the patches? -- Jun Omae (大前 潤)From 002741a54b88661268e2cc901a31835ebd696af4 Mon Sep 17 00:00:00 2001 From: Jun Omae Date: Tue, 15 Oct 2024 03:

Re: Windows build complaining about missing 'ruby'

2024-10-04 Thread Jun Omae
979,11 @@ def _find_ruby(self, show_warnings): "Find the right Ruby library name to link swig bindings with" +try: + subprocess.run(['ruby', '--version'], capture_output=True) +except OSError: + return # not found, permission error, ... + lib_dir = None inc_dirs = [] ]]] -- Jun Omae (大前 潤)

Re: Windows build: gen_make.py trips over zlib 1.3

2024-10-04 Thread Jun Omae
a4a2d2b, Sep 6 2024, 20:11:23) [MSC v.1940 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> minimal_zlib_version = (1, 2, 5) >>> (1, 2) < minimal_zlib_version True >>> (1, 2, 4) < minimal_zlib_version True >>> (1, 2, 4, 1) < minimal_zlib_version True >>> (1, 2, 5) < minimal_zlib_version False >>> (1, 3) < minimal_zlib_version False >>> (1, 3, 1) < minimal_zlib_version False >>> (1, 3, 1, 1) < minimal_zlib_version False ]]] -- Jun Omae (大前 潤)

Re: swig-py test failure with textdelta handler

2024-09-25 Thread Jun Omae
I just confirmed swig-py tests pass with Python 3.7-3.12, 2.7. It is unable to reproduce it. https://github.com/jun66j5/subversion-build/actions/runs/11040634538 Please let me know versions of the dependencies on your environment. Jun Omae (大前 潤) On Thu, Sep 26, 2024 at 4:41 Stefan Sperling

Re: Removing configuration of svneditor.sh script?

2024-09-25 Thread Jun Omae
like svneditor.bat: # SVN_TEST_PYTHON set by svntest/main.py - Remove "svneditor.sh" from svn:ignore of subversion/tests/cmdline -- Jun Omae (大前 潤)

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-25 Thread Jun Omae
On 2024/09/24 7:07, Timofei Zhakov wrote: > On Mon, Sep 23, 2024 at 9:25 AM Jun Omae wrote: >> >> On 2024/09/22 22:55, Timofei Zhakov wrote: >>> On Sun, Sep 22, 2024 at 2:02 AM Jun Omae wrote: >>>> >>>> On 2024/09/21 5:50, Timofei Zhakov wrote:

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-23 Thread Jun Omae
On 2024/09/22 22:55, Timofei Zhakov wrote: > On Sun, Sep 22, 2024 at 2:02 AM Jun Omae wrote: >> >> On 2024/09/21 5:50, Timofei Zhakov wrote: >>> On Fri, Sep 20, 2024 at 11:30 AM Jun Omae wrote: >>>> >>>> Hi, >>>> >>>> On 20

Re: svn commit: r1920768 - /subversion/trunk/CMakeLists.txt

2024-09-22 Thread Jun Omae
On 2024/09/22 23:24, Timofei Zhakov wrote: > On Sun, Sep 22, 2024 at 2:12 AM Jun Omae wrote: >> >> On 2024/09/18 21:12, rin...@apache.org wrote: >>> Author: rinrab >>> Date: Wed Sep 18 12:12:52 2024 >>> New Revision: 1920768 >>> >>> UR

Re: svn commit: r1920768 - /subversion/trunk/CMakeLists.txt

2024-09-21 Thread Jun Omae
ild/run_tests.py" +--bin ${CMAKE_CURRENT_BINARY_DIR} +--tools-bin ${CMAKE_CURRENT_BINARY_DIR} +--verbose +--log-to-stdout +--set-log-level=WARNING +${CMAKE_CURRENT_SOURCE_DIR} +${CMAKE_CURRENT_BINARY_DIR} +${py_test_path} +) endforeach() endif() ]]] -- Jun Omae (大前 潤)

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-21 Thread Jun Omae
On 2024/09/21 5:50, Timofei Zhakov wrote: > On Fri, Sep 20, 2024 at 11:30 AM Jun Omae wrote: >> >> Hi, >> >> On 2024/09/16 21:41, rin...@apache.org wrote: >>> Author: rinrab >>> Date: Mon Sep 16 12:41:13 2024 >>> New Revision: 1920717 >>

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-20 Thread Jun Omae
txt (revision 1920797) +++ CMakeLists.txt (working copy) @@ -671,13 +671,13 @@ "cmdline.${py_test_name}" COMMAND "${Python3_EXECUTABLE}" "${CMAKE_CURRENT_SOURCE_DIR}/build/run_tests.py" - --bin ${CMAKE_CURRENT_BINARY_DIR} -

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-18 Thread Jun Omae
On 2024/09/18 4:06, Timofei Zhakov wrote: > On Tue, Sep 17, 2024 at 7:55 PM Timofei Zhakov wrote: >> >> Hi, >> >> On Tue, Sep 17, 2024 at 6:45 AM Jun Omae wrote: >>> >>> On 2024/09/16 21:41, rin...@apache.org wrote: >>>> Author: rin

Re: svn commit: r1920717 - in /subversion/trunk: ./ CMakeLists.txt INSTALL build/cmake/ build/generator/gen_cmake.py build/generator/templates/targets.cmake.ezt gen-make.py subversion/svn_private_conf

2024-09-16 Thread Jun Omae
string(REGEX REPLACE "[ \t\r\n]*\\($" "" func_name ${func_name}) list(APPEND defs "${func_name}") endforeach() ]]] Thoughts? -- Jun Omae (大前 潤)

Re: svn commit: r1919757 - in /subversion/branches/cmake: CMakeLists.txt build/cmake/Findpy3c.cmake build/generator/templates/targets.cmake.ezt

2024-08-12 Thread Jun Omae
finally: _dll_path = None for _dll_path in _dll_paths: ... ]]] 2. I run build and install using cmake, however Python bindings are not installed (libsvn_swig_py*.dll is installed but *.py and *.pyd files not). C> cmake -B %CD:\=/%/out -D CMAKE_INSTALL_PREFIX=%CD:\=/%/dist ... C> cmake --build %CD:\=/%/out --target install ... -- Jun Omae (大前 潤)

Re: Building Subversion with CMake

2024-06-22 Thread Jun Omae
if target.install == "bdb-test": return True + + if os.name == 'nt': +def errno_filter(self, codes): + """From errno_filter() in gen_win.py""" + return [code for code in codes if not (1 <= code <= 10100)] ]]] -- Jun Omae (大前 潤)

Re: Building Subversion with CMake

2024-06-16 Thread Jun Omae
C:\usr\src\subversion\subversion.git\out\db-test.vcxproj" (default targets) -- FAILED. 32>Done Building Project "C:\usr\src\subversion\subversion.git\out\conflicts-test.vcxproj" (default targets) -- FAILED. 31>Done Building Project "C:\usr\src\subversion\subversion.git\out\conflict-data-test.vcxproj" (default targets) -- FAILED. 1>Done Building Project "C:\usr\src\subversion\subversion.git\out\ALL_BUILD.vcxproj" (default targets) -- FAILED. ]]] -- Jun Omae (大前 潤)

Re: Building Subversion with CMake

2024-06-12 Thread Jun Omae
ods like `get_static_win_depends` and `get_linked_win_depends` in `gen_win.py`? Have you got success to build on your Windows environment with cmake? -- Jun Omae (大前 潤)

Re: Building Subversion with CMake

2024-06-10 Thread Jun Omae
uld not find a package configuration file provided by "expat" with any of the following names: expatConfig.cmake expat-config.cmake Add the installation prefix of "expat" to CMAKE_PREFIX_PATH or set "expat_DIR" to a directory containing one of the above files. If "expat" provides a separate development package or SDK, be sure it has been installed. -- Configuring incomplete, errors occurred! ]]] -- Jun Omae (大前 潤)

Re: [PATCH] Check the change argument for a double minus at the start.

2024-05-20 Thread Jun Omae
ative is TRUE, raise > SVN_ERR_CL_ARG_PARSING_ERROR. Do the same if the changeno_end is > negative. > * subversion/tests/cmdline/diff_tests.py > (diff_invalid_change_arg): New test. > (test_list): Run new test. > ]]] > > Additionally, I am thinking about moving the code, which parses a > change revision, into a function in the opt.c file, like > svn_opt_parse_revision_to_range. > > Thanks! Found another similar issue in -c option. The following works correctly: $ ~/svn/1.14.3/bin/svn diff -c '0-1' file:///tmp/svnrepos svn: E205000: There is no change 0 However, the following aborts: $ ~/svn/1.14.3/bin/svn diff -c '1-0' file:///tmp/svnrepos svn: E235000: In file 'subversion/libsvn_client/ra.c' line 692: assertion failed (SVN_IS_VALID_REVNUM(start_revnum)) Aborted -- Jun Omae (大前 潤)

Re: [PATCH] Make svn_apply_autoprops.py Windows-compatible

2024-04-24 Thread Jun Omae
expandvars('$HOME/.subversion/config') However, the following registry or file is used in Windows. * HKEY_CURRENT_USER\Software\Tigris.org\Subversion\Config * %USERPROFILE%\AppData\Roaming\Subversion\config To make the script compatible with Windows needs to change the reading configurations. -- Jun Omae (大前 潤)

Re: svn commit: r1915317 - /subversion/branches/1.14.x/STATUS

2024-02-01 Thread Jun Omae
but a quick glance positive). > > Kind regards, > Daniel In my opinion, yes. Python users have no workaround for the issue except downgrading to 1.14.2. I think it happens if Python is a long-running process like a daemon or with large repositories. At least, I'm considering to report it with the patch to distributors (Debian, Ubuntu, FreeBSD, etc.). -- Jun Omae (大前 潤)

Re: svn commit: r1908547 - /subversion/trunk/subversion/svnserve/svnserve.c

2024-01-31 Thread Jun Omae
On Tue, Jan 30, 2024 at 9:42 PM Daniel Sahlberg wrote: > > Den tis 30 jan. 2024 kl 01:39 skrev Jun Omae : >> >> On 2024/01/30 6:15, Daniel Sahlberg wrote: >> > Good catch! How about: >> > >> > [

Re: svn commit: r1908547 - /subversion/trunk/subversion/svnserve/svnserve.c

2024-01-29 Thread Jun Omae
p_apr(status, _("Can't accept client connection")); } /* Add a reference to CONNECTION, i.e. keep it and it's pool valid unless ]]] -- Jun Omae (大前 潤)

Re: svn commit: r1908547 - /subversion/trunk/subversion/svnserve/svnserve.c

2024-01-29 Thread Jun Omae
sages even if the system call is interrupted when stop request by SIGTERM/SIGINT. -- Jun Omae (大前 潤)

Re: svn commit: r1915215 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/revert.c svn/notify.c svnbench/notify.c

2024-01-29 Thread Jun Omae
dk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at org.apache.subversion.javahl.RunTests.main(RunTests.java:119) Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 90 out of bounds for length 80 ... 19 more FAILURES!!! Tests run: 148, Fa

Re: build/run_tests.py, error on line 990 getattr()

2023-07-27 Thread Jun Omae
dest='set_log_level', const=logging.DEBUG, help='Print binary command-lines (same as ' + - '"--set-log-level logging.DEBUG")') + '"--set-log-level DEBUG")') parser.add_option('-q', '--quiet', action='store_true', help='Print only unexpected results (not with --verbose)') parser.add_option('-p', '--parallel', action='store_const', ]]] -- Jun Omae (大前 潤)

Re: "copy.c' line 1187: assertion failed (! svn_path_is_empty(path))" when running `svn move `

2023-05-29 Thread Jun Omae
could use a raw bytes literal. [[[ - if not re.match(b'.*\$LastChangedRevision:\s*\d+\s*\$', line_contents[3]): + if not re.match(rb'.*\$LastChangedRevision:\s*\d+\s*\$', line_contents[3]): ]]] However, in attached patch, correct the escape sequences because "make ch

Re: "copy.c' line 1187: assertion failed (! svn_path_is_empty(path))" when running `svn move `

2023-05-29 Thread Jun Omae
I will send this in a separate thread when > I've had some more time to look at it). The `SyntaxWarning` from line 1424 is displayed since Python 3.12, even without -Wdefault option. $ python3.12 -c '"\$"' :1: SyntaxWarning: invalid escape sequence '\$' $ python3.11 -c '"\$"' # no warnings $ python3.11 -Wdefault -c '"\$"' :1: DeprecationWarning: invalid escape sequence '\$' See also: https://docs.python.org/3.12/whatsnew/3.12.html?highlight=backslash-character#other-language-changes -- Jun Omae (大前 潤)

Re: "copy.c' line 1187: assertion failed (! svn_path_is_empty(path))" when running `svn move `

2023-05-28 Thread Jun Omae
dir ]]] See attached dav-fails.log. -- Jun Omae (大前 潤) dav-fails.log Description: Binary data

Re: svn commit: r1908545 - /subversion/trunk/build.conf

2023-05-27 Thread Jun Omae
ersion\build\win32\vcnet-vcproj\wc-queries-test.vcxproj] D:\a\subversion\subversion\Release\subversion\tests\libsvn_wc\wc-queries-test.exe : fatal error LNK1120: 2 unresolved externals [D:\a\subversion\subversion\build\win32\vcnet-vcproj\wc-queries-test.vcxproj] ]]] -- Jun Omae (大前 潤)

Re: svn commit: r1907965 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/ tests/cmdline/

2023-03-03 Thread Jun Omae
.h to include/private/svn_wc_private.h in order to export the symbol. -- Jun Omae (大前 潤)

Re: svn commit: r1904198 - in /subversion/trunk/build: ac-macros/swig.m4 generator/gen_win_dependencies.py

2022-10-02 Thread Jun Omae
- print("WARNING: Subversion Python bindings for Python 2 require 1.3.24 <= SWIG < 4.0.0") + print("WARNING: Subversion Python bindings for Python 2 require SWIG 1.3.24 or newer") return - opts = "-python -classic" + if self.swig_version < (4, 0, 0): +opts = "-python -nofastunpack -classic" + else: +opts = "-python -nofastunpack" +if show_warnings and self.swig_version > (4, 0, 2): + print("WARNING: Subversion Python bindings may work,\n" +"but we didn't check with this SWIG version.") self.user_macros.append(UserMacro("SWIG_PY_OPTS", opts)) self._libraries['python'] = SVNCommonLibrary('python', inc_dir, lib_dir, None, diff --git a/subversion/bindings/swig/include/proxy.swg b/subversion/bindings/swig/include/proxy.swg index 7d2d0dd03..5949c52e0 100644 --- a/subversion/bindings/swig/include/proxy.swg +++ b/subversion/bindings/swig/include/proxy.swg @@ -75,7 +75,7 @@ _set_instance_attr = _swig_setattr_nondynamic_instance_variable(object.__setattr__) %} -#elif defined(SWIGPYTHON_PY3) +#elif !defined(SWIG_PYTHON_CLASSIC) %pythoncode %{ # SWIG classes generated with -modern do not define this variable try: ]]] -- Jun Omae (大前 潤)

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Jun Omae
e \c at position 32 (line 1, column 33) > FAIL: diff_tests.py 48: svn diff --diff-cmd provides the correct arguments > ]]] I've posted patch for the failure. See https://lists.apache.org/thread/2o0xtqfzy9xg8wzxscj2wb641p2kyo9c -- Jun Omae (大前 潤)

Re: r1897441 (ping to jun66j5 and futatuki)

2022-03-30 Thread Jun Omae
verbroken ]]] Please check Release\subversion\tests\cmdline\httpd\log file in your environment. -- Jun Omae (大前 潤)

Re: r1897441 (ping to jun66j5 and futatuki)

2022-03-29 Thread Jun Omae
However, I get 2 failures from 1.14.x/win-tests.py on Windows (tests for swig-py, swig-pl and javahl pass). FAIL: mod_authz_svn_tests.py 10: repos-relative access file FAIL: mod_authz_svn_tests.py 11: repos-relative access file with bad repository URL It seems to be necessary to merge r18

Re: Questions on Release Management Process

2022-03-21 Thread Jun Omae
this file unless you know what you are doing--modify # the SWIG interface file instead. $ tar xaf ~/arc/subversion-1.14.1.tar.bz2 -O subversion-1.14.1/subversion/bindings/swig/python/core.c | head -5 /* * This file was automatically generated by SWIG (http://www.swig.org). * Version 3.0.12 * * This file is not intended to be easily readable and contains a number of ]]] -- Jun Omae (大前 潤)

Re: svn commit: r1899014 - /subversion/trunk/subversion/tests/cmdline/upgrade_tests.py

2022-03-17 Thread Jun Omae
On Fri, Mar 18, 2022 at 12:01 PM Daniel Shahaf wrote: > > Jun Omae wrote on Fri, Mar 18, 2022 at 11:27:16 +0900: > > Hi, > > > > On Fri, Mar 18, 2022 at 9:44 AM Daniel Shahaf > > wrote: > > > > > > Could someone test this on Windows, please? I su

Re: svn commit: r1899014 - /subversion/trunk/subversion/tests/cmdline/upgrade_tests.py

2022-03-17 Thread Jun Omae
2.11 Using bundled lz4 1.7.5 Using bundled utf8proc 2.1.0 ]]] -- Jun Omae (大前 潤) dav-fails.log Description: Binary data

Re: svn commit: r1898528 - /subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/diff_tests.py

2022-03-03 Thread Jun Omae
cmdline/diff_tests.py (working copy) @@ -3090,8 +3090,8 @@ r"iota\t\(revision 1\)\n", "-L\n", r"iota\t\(working copy\)\n", -os.path.abspath(svntest.main.get_admin_name()) + '.*' + "\n", -os.path.abspath("iota") + "\n"]) +re.escape(os.path.abspath(svntest.main.get_admin_name())) + '.*' + "\n", +re.escape(os.path.abspath("iota")) + "\n"]) # Check that the output of diff corresponds with the expected arguments, # in the correct order. ]]] -- Jun Omae (大前 潤)

Re: svn commit: r1897443 - in /subversion/trunk/subversion/tests/cmdline/svntest: actions.py main.py

2022-03-03 Thread Jun Omae
Hi, On 2022/02/19 21:27, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, Feb 08, 2022 at 11:47:47 +: Jun Omae wrote on Sat, Feb 05, 2022 at 00:28:51 +0900: After r1897443, prop_tests.py 12 is failing on Windows. svntest.Failure: Repository diskpath in stderr: [ "svn: E175008:

Re: svn commit: r1897443 - in /subversion/trunk/subversion/tests/cmdline/svntest: actions.py main.py

2022-02-04 Thread Jun Omae
' " ".join(sys.argv[2:]))\n' - 'sys.exit(1)\n', - cmd_alternative= - '@shift\n' - '@echo pre-revprop-change %* 1>&2\n' - '@exit 1\n') + 'sys.exit(1)\n') def create_failing_post_commit_hook(repo_dir): """Create a post-commit hook script in the repository at REPO_DIR that always ]]] -- Jun Omae (大前 潤)

Re: [PATCH] Fix file path transcoding around editor invocation.

2021-05-17 Thread Jun Omae
ter r1887641 on Windows (and perhaps on macOS). > > To reproduce it, in non UTF-8 CodePage/locale, set SVN_EDITOR to > non existent path which contains non-ascii character and The patch looks good to me and verified with the following environments: * Windows 10 (cp932) * Linux (ja_JP.eucj

Re: svn commit: r1887704 - in /subversion/trunk/subversion: libsvn_fs_fs/verify.c po/de.po po/sv.po

2021-05-05 Thread Jun Omae
r1866587, > r1866588 and above. It seems that r1866587 in the message is incorrect. It might be actually r1865987. -- Jun Omae (大前 潤)

Re: Should 'svn help' with APR lifetime debug enabled run without issues?

2021-05-04 Thread Jun Omae
e. > > Also, suggest to generate future patches with hunk titles enabled («svn > diff -x-p»). That tends to improve reviewability. Thanks for the testing and suggestions. Committed in r1889487. -- Jun Omae (大前 潤)

Re: Should 'svn help' with APR lifetime debug enabled run without issues?

2021-05-03 Thread Jun Omae
l.py (PoolTestCase): Add tests for pools referred from circular reference. }}} -- Jun Omae (大前 潤) pools-in-circular-ref.diff Description: Binary data

Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-17 Thread Jun Omae
On Tue, Nov 17, 2020 at 7:42 PM Branko Čibej wrote: > On 17.11.2020 04:09, Jun Omae wrote: > > On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf > > wrote: > >> Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: > >>> On 16.11.2020 04:16, Jun Omae wrote: &g

Re: [PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-16 Thread Jun Omae
On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf wrote: > > Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: > > On 16.11.2020 04:16, Jun Omae wrote: > > > The attached patch adds #pragma warning to make C4204 a warning > > > instead of an > > > error only

[PATCH] fix C4204 errors while building swig-py with Python 3.9 on Windows

2020-11-15 Thread Jun Omae
-py with Visual Studio. -- Jun Omae (大前 潤) Fix C4204 errors while building swig-py with Python 3.9 on Windows. * subversion/bindings/swig/include/svn_global.swg: Add #pragma to make C4204 a warning instead of an errors from Python.h in Python 3.9 with Visual Studio. * subversion/bindings/swig

Re: [PATCH] svn_cmdline__edit_file_externally() may not be able to open the target file in locale other than UTF-8

2020-10-07 Thread Jun Omae
ind the path specified. svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"') returned 1 ]]] -- Jun Omae (大前 潤)

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-20 Thread Jun Omae
On Mon, May 18, 2020 at 8:25 AM Yasuhito FUTATSUKI wrote: > > On 2020/05/18 2:51, Johan Corveleyn wrote: > > On Sun, May 17, 2020 at 3:43 PM Jun Omae wrote: > > >> Assertion for negative ref count is raised from test_conflict > >> (client.SubversionClientTestCase

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-17 Thread Jun Omae
Fatal Python error: subversion/bindings/swig/python/svn_client.c:26916 object at 0x7fe73b53a150 has negative ref count -2604246222170760230 -- Jun Omae (大前 潤)

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-15 Thread Jun Omae
On Wed, May 13, 2020 at 5:56 PM Jun Omae wrote: At least, I think we should use python_d.exe when debug configuration. ... Python bindings with debug configuration for Python 3.x has something wrong. [[[ -- Running Swig Python tests -- Traceback (most recent call last): File "C:\us

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-13 Thread Jun Omae
\src\subversion\trunk-py3\Debug\swig\pylib\libsvn\core.py", line 16, in swig_import_helper return importlib.import_module('_core') File "C:\usr\apps\python37\lib\importlib\__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) ModuleNotFoundError: No module named '_core' [Test runner reported failure] ]]] -- Jun Omae (大前 潤)

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-11 Thread Jun Omae
o not contain). Therefore, the Python bindings will only compile in Release mode. (This is due to pyconfig.h using the _DEBUG flag too and setting a #pragma comment(lib) value.) ]]] -- Jun Omae (大前 潤)

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-11 Thread Jun Omae
Thanks for the reviewing. On 2020/05/11 0:57, Daniel Shahaf wrote: Jun Omae wrote on Sun, 10 May 2020 13:27 +0900: +def _dll_paths(): +import os +if hasattr(os, 'add_dll_directory'): # Python 3.8+ on Windows +cookies = [] +for path in os.environ.get('P

Re: [PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-09 Thread Jun Omae
On Sun, May 10, 2020 at 1:27 PM Jun Omae wrote: > I created patch to resolve the issue using moduleimport option of %module > directive. > After attached patch, *.pyd file is successfully loaded and tests for Python > bindings pass. Tested with the following environments: - (

[PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows

2020-05-09 Thread Jun Omae
rsion/bindings/swig/svn_ra.i * subversion/bindings/swig/svn_repos.i * subversion/bindings/swig/svn_wc.i Add moduleimport option with SVN_PYTHON_MODULEIMPORT to %module directive for Python. ]]] [1] https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew -- Jun Omae (大前 潤) * subvers

Re: Problems running testsuite on Windows with Python 3

2020-05-08 Thread Jun Omae
tions): Use LoggingStdoutHandler() instead of StreamHandler(sys.stdout). ]]] Tested with the following environments: * Python 3.8.2 and Python 2.7.18 on Windows 10 * Python 3.8.2 on Linux -- Jun Omae (大前 潤) * build/run_tests.py (open_logfile): New function returning file-like object whi

[PATCH] Fix differences of SWIG_PY_OPTS between Unix and Windows

2020-05-02 Thread Jun Omae
on_client.vcxproj" (default targets) -- FAILED. ... 87 Warning(s) 102 Error(s) Time Elapsed 00:01:26.67 Investigating the issue, I noticed generated SWIG_PY_OPTS differs between Unix and Windows. -python -py3 should be "-python -py3 -nofastunpack" when SWIG

[PATCH] Fix variable declarations in swigutil_py.c

2020-05-01 Thread Jun Omae
\..\subversion\bindings\swig\python\libsvn_swig_py\swigutil_py.c(1332): error C4022: 'apr_hash_set' : pointer mismatch for actual parameter 4 It seems that several variable declarations are not at start of block. The declarations lead the syntax errors with Visual Studio 2008. Afte

[PATCH] Fix unable to build with Visual Studio 2008

2020-05-01 Thread Jun Omae
g line in vcnet_vcproj.ezt is incorrect. The line is introduced in r873230. ProgramDataBaseFileName="$(IntDir)/[sources.reldir]/[target.proj_name]-[sources.reldir].pdb"/> After attached patch, the error goes away and build successfully. -- Jun Omae (大前 潤) * build/generator/vcne

Re: [Patch] Support building with SWIG 4 on Python 3.x

2019-11-14 Thread Jun Omae
(Posting to dev list, again...) On Thu, Nov 14, 2019 at 1:47 AM Julian Foad wrote: > Nathan wrote in another thread: > > Note: If the patch contributed by Jun Omae a little earlier is > > committed, the text regarding SWIG 4.0.0+ in INSTALL will need to be > > adjusted ac

[Patch] Support building with SWIG 4 on Python 3.x

2019-11-13 Thread Jun Omae
/swig/include/proxy.swg (_get_instance_attr): New function to get an instance attribute without metadata for new-style and old-style classes. (_set_instance_attr): New function to set an instance attribute for new-style and old-style classes. ]]] -- Jun Omae (大前 潤) diff --git a/build/ac

[Patch] swig-py3: .swig__checked files are left after reconfiguration and distclean task

2019-10-30 Thread Jun Omae
. START OF PATCH commit e9662e8e284f778de13559a61ee3c081c96652d9 Author: Jun Omae Date: Wed Oct 30 15:56:09 2019 +0900 On branch swig-py3: Remove .swig_{pl,py,rb}_checked files on reconfiguration and distclean task. * Makefile.in (clean-swig-pl, clean-swig-py, clean-swig-rb

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-21 Thread Jun Omae
have SWIG installed correctly, run "swig -version" - from the command line. SWIG should report that it is version 1.3.24 + from the command line. SWIG should report that it is version 3.0.9 or newer. Step 1a: Install py3c library if building Python SWIG bindings. ]]] -- Jun Omae (大前 潤)

Re: [Patch] (swig-py) accept core.svn_stream_t object for svn_stream_t *

2018-12-11 Thread Jun Omae
_t in svn_swig_py_make_stream(), I think the code is redundant. Using svn_swig_py_convert_ptr() would simplify the converting the given py_io parameter to a svn_stream_t pointer. Thoughts? START OF PATCH commit f857f1f529cc0e621a074a48e7c689a0b32d18cf Author: Jun Omae Date: Tue Dec 11 19:41:25