Hi all,
On Sun, Oct 4, 2020 at 11:33 PM Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>
wrote:
I commited the v3 patch in 1882234.
I confirmed that on Windows in CP932, both of with and without
the v3 patch, it cannot pass the file name to edit.
For Windows I confirmed that it can be fixed by using _wsystem()
with WCHAR string, so I commited it in 1882235.
I found a minor issue on Windows after r1882235.
When the editor command (via SVN_EDITOR environment and --editor-cmd option) has
non-ascii characters, it is unable to launch the editor.
I think we should convert the editor command to UTF-16 encoding before passing
it
to _wsystem(), otherwise r1882235 should be reverted.
[[[
C> subversion\svnadmin\svnadmin.exe create C:\usr\tmp\svnrepos
C> mkdir C:\usr\tmp\エディタ
C> copy nul C:\usr\tmp\エディタ\editor-stub.cmd
C> set SVN_EDITOR=C:\usr\tmp\エディタ\editor-stub.cmd
C> subversion\svn\svn.exe propedit svn:ignore file:///C:/usr/tmp/svnrepos
The system cannot find the path specified.
svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"')
returned 1
C> subversion\svn\svn.exe propedit --editor-cmd=C:\usr\tmp\エディタ\editor-stub.cmd
svn:ignore file:///C:/usr/tmp/svnrepos
The system cannot find the path specified.
svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"')
returned 1
C> set SVN_EDITOR=
C> subversion\svn\svn.exe propedit --editor-cmd=C:\usr\tmp\エディタ\editor-stub.cmd
svn:ignore file:///C:/usr/tmp/svnrepos
The system cannot find the path specified.
svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"')
returned 1
C> subversion\svn\svn.exe propedit
--editor-cmd=C:\usr\tmp\エディタ\editor-stubx.cmd svn:ignore
file:///C:/usr/tmp/svnrepos
The system cannot find the path specified.
svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stubx.cmd "svn-prop.tmp"')
returned 1
C> subversion\svn\svn.exe propedit --editor-cmd=C:\usr\tmp\エディタ\editor-stub.cmd
svn:ignore file:///C:/usr/tmp/svnrepos
The system cannot find the path specified.
svn: E200012: system('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"')
returned 1
]]]
--
Jun Omae <jun6...@gmail.com> (大前 潤)
