On Tue, May 4, 2021 at 1:20 AM Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Yasuhito FUTATSUKI wrote on Mon, 03 May 2021 15:12 +00:00: > > The patch looks good to me. Also I confirmed that the test crash before > > apply patch to proxy_apr.swg with signal 10 or signal 11 and that > > the test passed without crash on Python 3.7 and 3.9, on FreeBSD 12. > > > > On Python 2.7, the test passed without crash both with/without patch > > to proxy_apr.swg, as it would be expected. > > > > +1 to commit. > > Suggest to link to the Python bug ticket in the log message. > > Also, suggest to generate future patches with hunk titles enabled («svn > diff -x-p»). That tends to improve reviewability.
Thanks for the testing and suggestions. Committed in r1889487. -- Jun Omae <jun6...@gmail.com> (大前 潤)
