On Tue, Nov 17, 2020 at 7:42 PM Branko Čibej <br...@apache.org> wrote: > On 17.11.2020 04:09, Jun Omae wrote: > > On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf <d...@daniel.shahaf.name> > > wrote: > >> Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100: > >>> On 16.11.2020 04:16, Jun Omae wrote: > >>>> The attached patch adds #pragma warning to make C4204 a warning > >>>> instead of an > >>>> error only on building swig-py with Visual Studio. > >>> +1 > >> Should that be added to build/generator/templates/ instead? Note that > >> 4204 is specifically there in two places already. > > The C4204 has turned into an error in r1442063. > > > > I've searched reasons of r1442063 in the archive of dev@ mailing list before > > posting the patch, however it was unable to find. I consider that r1442063 > > is > > to detect breakage of C89/C90 compat, the proposed patch has no changes of > > build/generator/templates/*.ezt files. > > The patch is correct. We want to enforce C90 compatibility in our code, > but relax it only when we have to for external code. It makes more sense > to do that in code than in the build generator. There's another example > of this approach in sqlite3wrapper.c.
Thanks for the review. Committed in r1883570. -- Jun Omae <jun6...@gmail.com> (大前 潤)
