On 2024/09/22 23:24, Timofei Zhakov wrote:
> On Sun, Sep 22, 2024 at 2:12 AM Jun Omae <jun6...@gmail.com> wrote:
>>
>> On 2024/09/18 21:12, rin...@apache.org wrote:
>>> Author: rinrab
>>> Date: Wed Sep 18 12:12:52 2024
>>> New Revision: 1920768
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1920768&view=rev
>>> Log:
>>> cmake: Exclude svneditor.py from tests, since it is just an internal script
>>> for the test-suite and cannot be run as a test.
>>>
>>> * CMakeLists.txt
>>>   (pytests): Filter 'svneditor' test name.
>>>
>>> Modified:
>>>     subversion/trunk/CMakeLists.txt
>>
>> In build.conf, it is configured to collect 
>> "subversion/tests/cmdline/*_tests.py"
>> for test scripts, not "subversion/tests/cmdline/*.py".
>>
>> I think we could use ".../*_tests.py" rather than filtering "svneditor.py".
>>
>> [[[...]]]
> 
> Thanks for reviewing and noticing this!
> 
> Changing the glob pattern seems to be a great resolution to me. Are
> you going to commit it?

Okay. Committed in r1920846.

-- 
Jun Omae <jun6...@gmail.com> (大前 潤)

Reply via email to