Re: Building subversion-trunk on Windows with cmake - anyone have a recipe?

2025-08-07 Thread Branko Čibej
On 7. 8. 25 15:05, Daniel Sahlberg wrote: Den tors 7 aug. 2025 kl 14:05 skrev Timofei Zhakov : On Thu, Aug 7, 2025 at 2:22 PM Daniel Sahlberg wrote: Den tis 5 aug. 2025 kl 19:27 skrev Graham Leggett via dev : Hi all, I am keen to build subversi

.github/workflows/cmake.yml for macOS

2025-08-06 Thread Branko Čibej
Looking at the macOS GHA, I noticed some possible issues in the dependency configuration: - name: Install dependencies (Mac OS, homebrew) if: runner.os == 'macOS' # Subversion is being installed here only to get the Serf library, # since there is no separate package. run: | brew install apr a

Re: svn commit: r1927483 - subversion/trunk/subversion/bindings/ctypes-python

2025-07-26 Thread Branko Čibej
On 27. 7. 25 01:26, Daniel Sahlberg wrote: Den lör 26 juli 2025 kl 22:19 skrev Branko Čibej : On 26. 7. 25 20:40, dsahlb...@apache.org wrote: Author: dsahlberg Date: Sat Jul 26 18:40:48 2025 New Revision: 1927483 Log: GitHub removed their SVN server some years ago so

Re: svn commit: r1927483 - subversion/trunk/subversion/bindings/ctypes-python

2025-07-26 Thread Branko Čibej
On 26. 7. 25 20:40, dsahlb...@apache.org wrote: Author: dsahlberg Date: Sat Jul 26 18:40:48 2025 New Revision: 1927483 Log: GitHub removed their SVN server some years ago so getting sources with svn won't work anymore. * subversion/bindings/ctypes-python/README (BUILDING CSVN): Remove exampl

Re: svn commit: r1927212 - in /subversion/branches/1.14.x: ./ STATUS tools/hook-scripts/svnperms.py

2025-07-13 Thread Branko Čibej
On 14. 7. 25 06:00, svn-r...@apache.org wrote: Author: svn-role Date: Mon Jul 14 04:00:05 2025 New Revision: 1927212 URL:http://svn.apache.org/viewvc?rev=1927212&view=rev Log: Merge r1886358 from trunk: * r1886358 Python 3 compatibility: Update a raise statement probably missed in revisio

Re: Corrupt checkout, but 'svn status' and 'svn diff' refuse to admit it?

2025-07-10 Thread Branko Čibej
On 10. 7. 25 21:50, EML wrote: Hi - On 10/07/2025 19:36, Branko Čibej wrote: On 10. 7. 25 17:37, Johan Corveleyn wrote: In general, the file in your $broken_workingcopy might have been changed out-of-band, by some other tool, a virus, a disk failure, ... but the main question is: why doesn&#

Re: Corrupt checkout, but 'svn status' and 'svn diff' refuse to admit it?

2025-07-10 Thread Branko Čibej
On 10. 7. 25 17:37, Johan Corveleyn wrote: On Wed, Jul 9, 2025 at 9:53 PM EML wrote: I have a 2+ GB repo which I committed to today, to reach rev 357 I then attempted to use a SQL database in the checkout, which turned out to be corrupt. When importing in MariaDB, it complained about a null ch

Re: [PATCH] Hide user-specific paths from error traces in debug mode.

2025-07-08 Thread Branko Čibej
On 8. 7. 25 02:18, Branko Čibej wrote: When Subversion is built with SVN_DEBUG defined, error messages contain a call trace with absolute paths to the source files. This potentially exposes sensitive user info, such as project or company names, when people post error reports to the 'net

[PATCH] Hide user-specific paths from error traces in debug mode.

2025-07-07 Thread Branko Čibej
When Subversion is built with SVN_DEBUG defined, error messages contain a call trace with absolute paths to the source files. This potentially exposes sensitive user info, such as project or company names, when people post error reports to the 'net or e-mail. As luck would have it, Subversion'

Deadlocks in the test suite? [Was: Re: [PR] Report SSL error messages from serf [subversion])

2025-07-02 Thread Branko Čibej
On 2. 7. 25 18:21, brainy (via GitHub) wrote: brainy commented on code in PR #32: URL:https://github.com/apache/subversion/pull/32#discussion_r2180482516 ## subversion/libsvn_ra_serf/util.c: ## @@ -958,7 +982,14 @@ svn_ra_serf__context_run(svn_ra_serf__session_t *sess,

Re: svn commit: r1926277 - in /subversion/trunk/subversion: include/private/svn_opt_private.h libsvn_client/cmdline.c libsvn_subr/opt.c libsvn_wc/adm_files.c svnadmin/svnadmin.c svnsync/svnsync.c

2025-06-28 Thread Branko Čibej
On 9. 6. 25 14:17, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 12:17:12 2025 New Revision: 1926277 URL:http://svn.apache.org/viewvc?rev=1926277&view=rev Log: Use svn_opt_args_to_target_array3() instead of svn_opt__args_to_target_array() and drop it. [...] Modified: subversion/tr

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-27 Thread Branko Čibej
On 27. 6. 25 18:18, Timofei Zhakov wrote: On Fri, Jun 27, 2025 at 9:59 AM Daniel Sahlberg wrote: Den tors 26 juni 2025 kl 23:19 skrev Branko Čibej : By the way, I noticed that the CMake build is consistently, intentionally behaving differently from the autotools build

Re: Drop support for Python 2.7? (Was: Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/)

2025-06-27 Thread Branko Čibej
On 27. 6. 25 12:00, Daniel Sahlberg wrote: Den sön 8 juni 2025 kl 16:46 skrev Nathan Hartman : On Tue, May 20, 2025 at 8:32 AM wrote: Author: brane Date: Tue May 20 12:32:49 2025 New Revision: 1925717 URL: http://svn.apache.org/viewvc?rev=1925717&view=rev

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-26 Thread Branko Čibej
On 26. 6. 25 22:35, Daniel Sahlberg wrote: Hi Jun, Thanks for testing! Den tors 26 juni 2025 kl 05:02 skrev Jun Omae : Also, the searching libraries using pkg-config doesn't work on my environment. I think it is caused by the prefix passed to pkg_check_modules is wrong. [[[

Re: svn commit: r1926599 - /subversion/trunk/.github/workflows/cmake.yml

2025-06-25 Thread Branko Čibej
On 21. 6. 25 16:38, Timofei Zhakov wrote: In my testing, the whole action completed successfully on Mac OS, except of one test: ``` 24: svn_tests: E26: Expected error SVN_ERR_SQLITE_BUSY but got SVN_ERR_SQLITE_ERROR 24: svn_tests: E200030: sqlite[S10]: disk I/O error 24: svn_tests: E200042:

Re: subversion-trunk + serf: An appropriate version of serf could not be found

2025-06-19 Thread Branko Čibej
On 19. 6. 25 16:00, Branko Čibej wrote: On 19. 6. 25 14:48, Graham Leggett via dev wrote: Hi all, Trying a routine build of subversion-trunk on EL9, and have added the --with-serf=yes option expecting it to find the /usr/lib64/pkgconfig/serf.pc file. No luck: [minfrin@rocky9 subversion

Re: subversion-trunk + serf: An appropriate version of serf could not be found

2025-06-19 Thread Branko Čibej
On 19. 6. 25 14:48, Graham Leggett via dev wrote: Hi all, Trying a routine build of subversion-trunk on EL9, and have added the --with-serf=yes option expecting it to find the /usr/lib64/pkgconfig/serf.pc file. No luck: [minfrin@rocky9 subversion-trunk]$ ./configure --with-serf=yes configu

Re: svn propchange: r1926515 - svn:log

2025-06-19 Thread Branko Čibej
On 19. 6. 25 14:45, Timofei Zhakov wrote: On Wed, Jun 18, 2025 at 2:03 AM Branko Čibej wrote: On 17. 6. 25 20:55, rin...@apache.org wrote: Author: rinrab Revision: 1926515 Modified property:svn:log Modified:svn:log at Tue Jun 17 18:55:25 2025

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-06-19 Thread Branko Čibej
On 19. 6. 25 12:42, Joe Orton wrote: On Thu, Jun 19, 2025 at 10:26:43AM +0200, Branko Čibej wrote: On 19. 6. 25 10:22,jor...@apache.org wrote: Author: jorton Date: Thu Jun 19 08:22:56 2025 New Revision: 1926575 URL:http://svn.apache.org/viewvc?rev=1926575&view=rev Log: Fix SWIG test c

Re: svn commit: r1926575 - in /subversion/trunk/subversion/bindings/swig/python/tests: mergeinfo.py repository.py

2025-06-19 Thread Branko Čibej
On 19. 6. 25 10:22, jor...@apache.org wrote: Author: jorton Date: Thu Jun 19 08:22:56 2025 New Revision: 1926575 URL:http://svn.apache.org/viewvc?rev=1926575&view=rev Log: Fix SWIG test cases for Python 3.14. The interpreter internally avoids some reference count modifications when loading obje

Re: 'svn commit' without '-m' fails?

2025-06-18 Thread Branko Čibej
On 19. 6. 25 00:17, Branko Čibej wrote: On 18. 6. 25 23:20, C. Michael Pilato wrote: Disclaimer: I haven't looked at this codebase in a really long time.  But this code in cmdline.c reads differently than my now-naive eyes would expect:   /* If neither --non-interactive nor --

Re: 'svn commit' without '-m' fails?

2025-06-18 Thread Branko Čibej
  – it's already failing, I just have to adjust expected_stderr. And yeah, looking at that diff now, it's kind of obvious. 🙄 Thanks! -- Brane On Wed, Jun 18, 2025 at 4:59 PM Branko Čibej wrote: On 18. 6. 25 22:40, Branko Čibej wrote: This is with a fresh build of today's

Re: 'svn commit' without '-m' fails?

2025-06-18 Thread Branko Čibej
On 18. 6. 25 22:40, Branko Čibej wrote: This is with a fresh build of today's trunk: $ /Volumes/svn-test/trunk/subversion/svn/svn commit /Users/brane/src/svn/repos/trunk/subversion/svn/svn.c:3373: (apr_err=SVN_ERR_CL_INSUFFICIENT_ARGS) svn: E205001: Try 'svn help commit' for m

'svn commit' without '-m' fails?

2025-06-18 Thread Branko Čibej
This is with a fresh build of today's trunk: $ /Volumes/svn-test/trunk/subversion/svn/svn commit /Users/brane/src/svn/repos/trunk/subversion/svn/svn.c:3373: (apr_err=SVN_ERR_CL_INSUFFICIENT_ARGS) svn: E205001: Try 'svn help commit' for more information /Users/brane/src/svn/repos/trunk/subversion

Re: svn commit: r1926510 - in /subversion/branches/utf8-cmdline-prototype/subversion/tests/cmdline: basic_tests.py svntest/testcase.py

2025-06-17 Thread Branko Čibej
On 18. 6. 25 03:29, Jun Omae wrote: On 2025/06/18 9:19, Branko Čibej wrote: On 17. 6. 25 20:31, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 17 18:31:22 2025 New Revision: 1926510 URL:http://svn.apache.org/viewvc?rev=1926510&view=rev Log: On the 'utf8-cmdline-prototype

Re: svn commit: r1926510 - in /subversion/branches/utf8-cmdline-prototype/subversion/tests/cmdline: basic_tests.py svntest/testcase.py

2025-06-17 Thread Branko Čibej
On 17. 6. 25 20:31, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 17 18:31:22 2025 New Revision: 1926510 URL:http://svn.apache.org/viewvc?rev=1926510&view=rev Log: On the 'utf8-cmdline-prototype' branch: Add RequireUtf8 decorator and run the basic_tests#unicode_arguments_test test in UTF

Re: svn propchange: r1926515 - svn:log

2025-06-17 Thread Branko Čibej
On 17. 6. 25 20:55, rin...@apache.org wrote: Author: rinrab Revision: 1926515 Modified property:svn:log Modified:svn:log at Tue Jun 17 18:55:25 2025 -- ---svn:log (original) +++svn:log Tue Jun 17 18:55:25 2025 @@ -1,2

Re: Deprecation warnings on trunk

2025-06-16 Thread Branko Čibej
On 17. 6. 25 04:24, Nathan Hartman wrote: On Mon, Jun 16, 2025 at 10:17 PM Branko Čibej wrote: On 17. 6. 25 03:29, Nathan Hartman wrote: On Mon, Jun 16, 2025 at 4:23 PM Branko Čibej wrote: When building trunk (with autotools and maintainer-mode; to test with serf

Re: Deprecation warnings on trunk

2025-06-16 Thread Branko Čibej
On 17. 6. 25 03:29, Nathan Hartman wrote: On Mon, Jun 16, 2025 at 4:23 PM Branko Čibej wrote: When building trunk (with autotools and maintainer-mode; to test with serf-2), I get a lot of warnings like this one: .../subversion/svnadmin/svnadmin.c:2598:11: warning

Re: Deprecation warnings on trunk

2025-06-16 Thread Branko Čibej
On 17. 6. 25 00:45, Timofei Zhakov wrote: On Mon, Jun 16, 2025 at 10:23 PM Branko Čibej wrote: When building trunk (with autotools and maintainer-mode; to test with serf-2), I get a lot of warnings like this one: .../subversion/svnadmin/svnadmin.c:2598:11: warning

Deprecation warnings on trunk

2025-06-16 Thread Branko Čibej
When building trunk (with autotools and maintainer-mode; to test with serf-2), I get a lot of warnings like this one: .../subversion/svnadmin/svnadmin.c:2598:11: warning: 'svn_opt_args_to_target_array3' is deprecated [-Wdeprecated-declarations] 2598 | SVN_ERR(svn_opt_args_to_target_array3(&t

Re: svn client: Native support for Windows, native support for MacOS

2025-06-14 Thread Branko Čibej
On 14. 6. 25 17:58, Graham Leggett via dev wrote: Hi all, I am having a torrid time trying to get the svn client to work on Windows. In short, every attempt to connect results in "An error occurred during SSL communication". One archeological dig later, it appears that when neon was replaced

Re: [GH] (subversion/trunk): Workflow run "CMake" failed!

2025-06-13 Thread Branko Čibej
On 13. 6. 25 16:40, Branko Čibej wrote: On 13. 6. 25 16:27, Timofei Zhakov wrote: On Fri, Jun 13, 2025 at 4:10 PM GitBox wrote: The GitHub Actions job "CMake" on subversion.git/trunk has failed. Run started by GitHub user asfgit (triggered by asfgit). Head comm

Re: [GH] (subversion/trunk): Workflow run "CMake" failed!

2025-06-13 Thread Branko Čibej
On 13. 6. 25 16:27, Timofei Zhakov wrote: On Fri, Jun 13, 2025 at 4:10 PM GitBox wrote: The GitHub Actions job "CMake" on subversion.git/trunk has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: d510c071272942161ccaf298bd2aef9cdcaade62 / T

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-12 Thread Branko Čibej
On 13. 6. 25 01:14, Timofei Zhakov wrote: (...cut...) Thanks for your explanation! I'd add a few points from myself. When a library is linked into another target through target_link_libraries(), it can be either PUBLIC, PRIVATE, or INTERFACE: - PRIVATE means that the

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-12 Thread Branko Čibej
On 12. 6. 25 22:36, Timofei Zhakov wrote: On Thu, Jun 12, 2025 at 7:51 PM Branko Čibej wrote: On 12. 6. 25 19:10, Daniel Sahlberg wrote: Den tors 12 juni 2025 kl 00:34 skrev Timofei Zhakov : Revert most of the changes in svn_utf.h from r1926293. Instead

Re: svn commit: r1926350 - /subversion/trunk/CMakeLists.txt

2025-06-12 Thread Branko Čibej
On 12. 6. 25 19:30, Daniel Sahlberg wrote: Den ons 11 juni 2025 kl 17:12 skrev Branko Čibej : On 11. 6. 25 00:07, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 10 22:07:50 2025 New Revision: 1926350 URL:http://svn.apache.org/viewvc?rev=1926350&view=rev &

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-12 Thread Branko Čibej
On 12. 6. 25 19:10, Daniel Sahlberg wrote: Den tors 12 juni 2025 kl 00:34 skrev Timofei Zhakov : Revert most of the changes in svn_utf.h from r1926293. Instead, tell the CMake build to expose APR and APR-Util include paths everywhere. (...) * CMakeLists.txt

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-11 Thread Branko Čibej
On 12. 6. 25 00:30, Timofei Zhakov wrote: Revert most of the changes in svn_utf.h from r1926293. Instead, tell the CMake build to expose APR and APR-Util include paths everywhere. (...) * CMakeLists.txt: Add APR and APR-Util include paths to the top-level    directory prop

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 11. 6. 25 06:21, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 8:00 PM Branko Čibej wrote: The CMake build is broken with regard to include directories, that's a given, and it's easy to fix. Perhaps not in such a cmake-purist way that some people around here appear t

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 9. 6. 25 19:26, Branko Čibej wrote: On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 16:31:15 2025 New Revision: 1926293 URL:http://svn.apache.org/viewvc?rev=1926293&view=rev Log: Do not include apr_xlate.h into svn_utf.h, but manually wrap the SVN_APR_*_CHA

Re: svn commit: r1926350 - /subversion/trunk/CMakeLists.txt

2025-06-11 Thread Branko Čibej
On 11. 6. 25 00:07, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 10 22:07:50 2025 New Revision: 1926350 URL:http://svn.apache.org/viewvc?rev=1926350&view=rev Log: cmake: Prevent re-definition of APR and Serf targets by using different prefixes for version '1' and '2'. * CMakeLists.txt

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 11. 6. 25 06:21, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 8:00 PM Branko Čibej wrote: On 11. 6. 25 01:19, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 12:26 PM Branko Čibej wrote: On 10. 6. 25 17:32, Timofei Zhakov wrote: On Tue, Jun 10, 2025 at 5:24 PM

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-10 Thread Branko Čibej
On 11. 6. 25 01:19, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 12:26 PM Branko Čibej wrote: On 10. 6. 25 17:32, Timofei Zhakov wrote: On Tue, Jun 10, 2025 at 5:24 PM Branko Čibej wrote: On 10. 6. 25 16:01, Timofei Zhakov wrote: On Mon, Jun 9, 2025 at 7:26 PM

Re: svn commit: r1926344 - /subversion/trunk/CMakeLists.txt

2025-06-10 Thread Branko Čibej
On 10. 6. 25 17:46, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 10 15:46:58 2025 New Revision: 1926344 URL:http://svn.apache.org/viewvc?rev=1926344&view=rev Log: cmake: Support pkg-config library search. - We are relying on the FindPkgConfig module which does all work of invoking p

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-10 Thread Branko Čibej
On 10. 6. 25 17:32, Timofei Zhakov wrote: On Tue, Jun 10, 2025 at 5:24 PM Branko Čibej wrote: On 10. 6. 25 16:01, Timofei Zhakov wrote: On Mon, Jun 9, 2025 at 7:26 PM Branko Čibej wrote: On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-10 Thread Branko Čibej
On 10. 6. 25 17:26, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 10:07 AM Timofei Zhakov wrote: On Mon, Jun 9, 2025 at 7:26 PM Branko Čibej wrote: On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 16:31:15 2025 New Revision

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-10 Thread Branko Čibej
On 10. 6. 25 16:01, Timofei Zhakov wrote: On Mon, Jun 9, 2025 at 7:26 PM Branko Čibej wrote: On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 16:31:15 2025 New Revision: 1926293 URL:http://svn.apache.org/viewvc?rev=1926293&view=rev &

Re: svn commit: r1926244 - /subversion/trunk/build/cmake/FindSerf.cmake

2025-06-09 Thread Branko Čibej
On 9. 6. 25 18:43, Timofei Zhakov wrote: We're including apr_xlate.h for a couple of macros in subversion/include/svn_utf.h, we need /only/ the header, not the whole library. But CMake in its wisdom doesn't make the include path available unless the target its building /links/ wi

Re: svn commit: r1926244 - /subversion/trunk/build/cmake/FindSerf.cmake

2025-06-09 Thread Branko Čibej
On 9. 6. 25 18:39, Timofei Zhakov wrote: On Sun, Jun 8, 2025 at 10:26 AM wrote: Author: brane Date: Sun Jun  8 08:26:12 2025 New Revision: 1926244 URL: http://svn.apache.org/viewvc?rev=1926244&view=rev Log: Teach t

Re: svn commit: r1926286 - in /subversion/trunk: CMakeLists.txt build/cmake/extractor.cmake

2025-06-09 Thread Branko Čibej
On 9. 6. 25 19:26, Timofei Zhakov wrote: On Mon, Jun 9, 2025 at 7:23 PM Branko Čibej wrote: On 9. 6. 25 15:41, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 13:41:13 2025 New Revision: 1926286 URL:http://svn.apache.org/viewvc?rev=1926286&view=rev &

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-09 Thread Branko Čibej
On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 16:31:15 2025 New Revision: 1926293 URL:http://svn.apache.org/viewvc?rev=1926293&view=rev Log: Do not include apr_xlate.h into svn_utf.h, but manually wrap the SVN_APR_*_CHARSET constants into APR_*_CHARSET. -1. You c

Re: svn commit: r1926286 - in /subversion/trunk: CMakeLists.txt build/cmake/extractor.cmake

2025-06-09 Thread Branko Čibej
On 9. 6. 25 15:41, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 13:41:13 2025 New Revision: 1926286 URL:http://svn.apache.org/viewvc?rev=1926286&view=rev Log: cmake: Generate def files in build time using an external script extractor.cmake script (similarly to extractor.py). * build

Re: Binary Patch (xpatch)

2025-06-08 Thread Branko Čibej
On 8. 6. 25 20:55, Nathan Hartman wrote: On Tue, May 20, 2025 at 2:07 PM Branko Čibej wrote: On 18. 5. 25 21:48, Branko Čibej wrote: XML has the unenviable distinction of being *both* almost unreadable for humans *and* very finicky to parse for machines. There's one

Re: Drop support for Python 2.7?

2025-06-08 Thread Branko Čibej
On 8. 6. 25 16:45, Nathan Hartman wrote: On Tue, May 20, 2025 at 8:32 AM wrote: Author: brane Date: Tue May 20 12:32:49 2025 New Revision: 1925717 URL: http://svn.apache.org/viewvc?rev=1925717&view=rev Log: Add sup

Re: [PATCH] Print locale the name of the current locale character set in `svn --version --verbose`

2025-06-08 Thread Branko Čibej
On 8. 6. 25 12:51, Timofei Zhakov wrote: On Sun, Jun 8, 2025 at 4:08 AM Branko Čibej wrote: On 6. 6. 25 22:16, Timofei Zhakov wrote: Hi, I would like to suggest adding a line to svn --version command to display the current locale name. This could be helpful for us

Re: svn commit: r1926244 - /subversion/trunk/build/cmake/FindSerf.cmake

2025-06-08 Thread Branko Čibej
On 8. 6. 25 10:26, br...@apache.org wrote: Author: brane Date: Sun Jun 8 08:26:12 2025 New Revision: 1926244 URL:http://svn.apache.org/viewvc?rev=1926244&view=rev Log: Teach the CMake build to find serf-2, and use the paths defined in the GNUInstallDirs module, because that's where Serf's CMake

Re: [PATCH] Print locale the name of the current locale character set in `svn --version --verbose`

2025-06-07 Thread Branko Čibej
On 6. 6. 25 22:16, Timofei Zhakov wrote: Hi, I would like to suggest adding a line to svn --version command to display the current locale name. This could be helpful for us receiving or investigating any encoding-related bugs, and seems generally useful to a part of platform information.

Re: svn commit: r1926218 - in /subversion/trunk: ./ subversion/include/private/svn_cmdline_private.h subversion/libsvn_subr/cmdline.c

2025-06-07 Thread Branko Čibej
On 7. 6. 25 19:41, rin...@apache.org wrote: Author: rinrab Date: Sat Jun 7 17:41:22 2025 New Revision: 1926218 URL:http://svn.apache.org/viewvc?rev=1926218&view=rev Log: In the trunk: Add svn_cmdline__get_utf8_argv() function and platform-specific implementations. You don't need to say "in th

Re: utf8 cmdline

2025-06-06 Thread Branko Čibej
On 7. 6. 25 03:11, Jun Omae wrote: On 2025/06/07 1:22, Timofei Zhakov wrote: Yay! It makes sense. Thank you so much for pointing me out. Is it worthed to change the locale to utf8 for all tests? However, if not, I think I could temporarily modify it, and set it back to C after the test body.

Re: Building Subversion with CMake

2025-05-30 Thread Branko Čibej
Hi, Thanks for a great write-up. :) In light of which you'll be happy to know that Subversion's autotools build isn't going anywhere and will remain the preferred build system for Unix-like platforms. For Windows, we have our own build generator (that we use to generate the Makefile targets

Re: svn commit: r1925902 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

2025-05-28 Thread Branko Čibej
On 28. 5. 25 14:31, rin...@apache.org wrote: Author: rinrab Date: Wed May 28 12:31:55 2025 New Revision: 1925902 URL:http://svn.apache.org/viewvc?rev=1925902&view=rev Log: On the 'utf8-cmdline-prototype' branch: avoid double coping of arguments after encoding conversion. This is a follow-up to

Re: CMake, FindAPR and FindAPRUtil

2025-05-28 Thread Branko Čibej
On 28. 5. 25 14:35, Daniel Sahlberg wrote: Den ons 28 maj 2025 kl 14:29 skrev Timofei Zhakov : ... So, it would be great if serf starts using svn's modules. I can try to support pkgconfig in them if needed. Thoughts? Outside of my area of expertise but doesn't this concern the bui

Re: CMake, FindAPR and FindAPRUtil

2025-05-28 Thread Branko Čibej
On 28. 5. 25 14:27, Timofei Zhakov wrote: On Wed, May 28, 2025 at 2:14 PM Branko Čibej wrote: So I was fiddling with Serf's CMake build recently, and just now I noticed (again) that Serf has FindAPR.cmake and FindAPRUtil.cmake as well, and they're almost entirely

CMake, FindAPR and FindAPRUtil

2025-05-28 Thread Branko Čibej
So I was fiddling with Serf's CMake build recently, and just now I noticed (again) that Serf has FindAPR.cmake and FindAPRUtil.cmake as well, and they're almost entirely completely different from Subversion's. Not only completely different but far more complete, IMO. I'd like to merge the two

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

2025-05-28 Thread Branko Čibej
On 28. 5. 25 13:56, Timofei Zhakov wrote: You changed that opt_state.encoding to be in UTF-8 (a change that, by the way, I'm not sure about. That value is a parameter for the xlate functions, which may require the original native-encoded name). Yup. I think I clarified this in the

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

2025-05-28 Thread Branko Čibej
On 28. 5. 25 13:28, Timofei Zhakov wrote: On Wed, May 28, 2025 at 12:51 PM Branko Čibej wrote: On 26. 5. 25 16:58, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 14:58:30 2025 New Revision: 1925827 URL:http://svn.apache.org/viewvc?rev=1925827&view=rev &

Re: svn commit: r1925841 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

2025-05-28 Thread Branko Čibej
On 26. 5. 25 21:55, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 19:55:30 2025 New Revision: 1925841 URL:http://svn.apache.org/viewvc?rev=1925841&view=rev Log: On the 'utf8-cmdline-prototype' branch: follow-up to r1925834: prevent 'log message is pathname' warning from showing when t

Re: svn commit: r1925834 - in /subversion/branches/utf8-cmdline-prototype/subversion/svn: cl.h svn.c util.c

2025-05-28 Thread Branko Čibej
On 26. 5. 25 19:24, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 17:24:16 2025 New Revision: 1925834 URL:http://svn.apache.org/viewvc?rev=1925834&view=rev Log: On the 'utf8-cmdline-prototype' branch: Store utf8-ized message in opt_state. The reason this is stored unchanged is so t

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

2025-05-28 Thread Branko Čibej
On 26. 5. 25 16:58, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 14:58:30 2025 New Revision: 1925827 URL:http://svn.apache.org/viewvc?rev=1925827&view=rev Log: On the 'utf8-cmdline-prototype' branch: convert opt_arg to utf8 once in the beginning of argument handling loop instead of d

Re: svn commit: r1925899 - in /subversion/trunk: CMakeLists.txt build/run_tests.py subversion/tests/cmdline/prop_tests.py subversion/tests/cmdline/svntest/main.py subversion/tests/cmdline/svntest/veri

2025-05-28 Thread Branko Čibej
On 28. 5. 25 11:36, br...@apache.org wrote: Author: brane Date: Wed May 28 09:36:46 2025 New Revision: 1925899 URL:http://svn.apache.org/viewvc?rev=1925899&view=rev Log: Improve the XML validation support in the test suite by making it optional and adding some tooling for different ways to insta

Re: svn commit: r1925822 - /subversion/trunk/CMakeLists.txt

2025-05-28 Thread Branko Čibej
On 26. 5. 25 15:38, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 13:38:39 2025 New Revision: 1925822 URL:http://svn.apache.org/viewvc?rev=1925822&view=rev Log: cmake: Add SVN_TEST_COMMAND_ARGUMENTS option that can configure additional command line arguments to pass to our test-suite.

Re: libsvn_cmdline

2025-05-28 Thread Branko Čibej
On 28. 5. 25 00:11, Timofei Zhakov wrote: See? SEE!!?? I *told* you it was a mess. :D This stuff should all be in libsvn_subr/cmdline.c. I don't even remember any more how this happened. I think that at one point I was even considering creating a new library that would contain

Re: svn_opt_args_to_target_array/svn_client_args_to_target_array issue

2025-05-27 Thread Branko Čibej
On 27. 5. 25 18:06, Timofei Zhakov wrote: On Tue, May 27, 2025 at 5:32 PM Timofei Zhakov wrote: Hi, I noticed that there are two different functions in different libraries (libsvn_subr and libsvn_client) which are doing almost the same thing. But, one in subr is permanently dep

Re: svn commit: r1925722 - in /subversion/branches/utf8-cmdline-prototype/subversion: include/svn_client.h libsvn_client/cmdline.c

2025-05-27 Thread Branko Čibej
On 26. 5. 25 23:15, Timofei Zhakov wrote: On Mon, May 26, 2025 at 10:07 PM Branko Čibej wrote: On 26. 5. 25 21:25, Timofei Zhakov wrote: On Mon, May 26, 2025 at 8:29 PM Branko Čibej wrote: On 26. 5. 25 14:07, Timofei Zhakov wrote: This is exactly what happened with

Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/

2025-05-26 Thread Branko Čibej
On 26. 5. 25 22:08, Branko Čibej wrote: Anyway, I'll have to see what's happening in the CMake build, it's refreshing the venv far too often. Ah, I see what's going on: CMake runs each Python test file separately (through run_tests.py), whereas the Makefile build does n

Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/

2025-05-26 Thread Branko Čibej
On 26. 5. 25 22:08, Branko Čibej wrote: On 26. 5. 25 21:12, Timofei Zhakov wrote: The first issue is that the CMake build does not not set PYTHONPATH the way run_tests.py does, but that's not causing the failures, either. I think it does. According to the documentation &

Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/

2025-05-26 Thread Branko Čibej
On 26. 5. 25 21:12, Timofei Zhakov wrote: On Mon, May 26, 2025 at 8:54 PM Branko Čibej wrote: On 26. 5. 25 15:40, Timofei Zhakov wrote: Would this be helpful? (see the patch in the attachments) This just throws out all the dependency setup and special-cases schema

Re: svn commit: r1925722 - in /subversion/branches/utf8-cmdline-prototype/subversion: include/svn_client.h libsvn_client/cmdline.c

2025-05-26 Thread Branko Čibej
On 26. 5. 25 21:25, Timofei Zhakov wrote: On Mon, May 26, 2025 at 8:29 PM Branko Čibej wrote: On 26. 5. 25 14:07, Timofei Zhakov wrote: On Tue, May 20, 2025 at 9:29 PM Branko Čibej wrote: On 20. 5. 25 20:31, rin...@apache.org wrote: Author: rinrab Date

Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/

2025-05-26 Thread Branko Čibej
On 26. 5. 25 15:40, Timofei Zhakov wrote: Would this be helpful? (see the patch in the attachments) This just throws out all the dependency setup and special-cases schema verification, it doesn't actually solve the underlying problem. You'll notice from the logs that creating and using the

Re: Adressing of below repository root in command line?

2025-05-26 Thread Branko Čibej
On 26. 5. 25 15:32, Dr. Thomas Orgis wrote: Am Fri, 23 May 2025 14:02:46 +0200 schrieb Branko Čibej: And of course, if we support "^.", we obviously have to support "^./any/relative/wc/path" in the same way. Not sure what you mean. ^/ is the repo root. ^./ is the repo

Re: 2FA prototype

2025-05-24 Thread Branko Čibej
sending the same token with a set cookie, that serf and svn can ignore to make browsers work Good idea. Best regards, Peter On 2025. 05. 24. 14:01, Branko Čibej wrote: On 23. 5. 25 23:48, Peter Balogh wrote: Hi, The reason I choose the 499 status code, that it was the cleanest way to

Re: 2FA prototype

2025-05-24 Thread Branko Čibej
On 24. 5. 25 14:12, Daniel Sahlberg wrote: As I understand WWW-Authenticate, it is possible to add multiple authentications at the same time. If we would have a server-wide 2FA setting (ie, all users are required ot use 2FA), we could possibly combine steps 2 and 4 into a single step, saving a ro

Re: 2FA prototype

2025-05-24 Thread Branko Čibej
e Subversion client side, libsvn_ra_serf might have to grow another hook for multi-factor callbacks, and we'd need another authentication provider that would store the shared-secret per realm, similar to what the username provider does now. Best regards, Peter On 2025. 05. 23. 17:28,

Re: Adressing of below repository root in command line?

2025-05-23 Thread Branko Čibej
On 22. 5. 25 13:38, Dr. Thomas Orgis via dev wrote: Am Tue, 20 May 2025 17:08:21 +0200 schrieb Branko Čibej: So, no, we don't currently have a syntax for relative URLs that would do what you propose. I don't know offhand what all the ramifications would be (other than, well, writin

Re: svn commit: r1925722 - in /subversion/branches/utf8-cmdline-prototype/subversion: include/svn_client.h libsvn_client/cmdline.c

2025-05-20 Thread Branko Čibej
On 20. 5. 25 20:31, rin...@apache.org wrote: Author: rinrab Date: Tue May 20 18:31:35 2025 New Revision: 1925722 URL:http://svn.apache.org/viewvc?rev=1925722&view=rev Log: On the 'utf8-cmdline-prototype' branch: add a new function that retrieves target list from args, instead of converting the e

Re: svn commit: r1925717 - in /subversion/trunk: ./ build/ subversion/tests/cmdline/ subversion/tests/cmdline/svntest/

2025-05-20 Thread Branko Čibej
On 20. 5. 25 20:19, Timofei Zhakov wrote: +def ensure_dependencies(): +  """Install the dependencies we need for running the tests. + +  NOTE: this function des not handle the case where the Python +        version has changed. In theory, we could automagically +        u

Re: Binary Patch (xpatch)

2025-05-20 Thread Branko Čibej
On 18. 5. 25 21:48, Branko Čibej wrote: XML has the unenviable distinction of being *both* almost unreadable for humans *and* very finicky to parse for machines. There's one other nasty problem with XML: it can't represent every character. There's a test for that, xml_unsa

Re: Adressing of below repository root in command line?

2025-05-20 Thread Branko Čibej
On 20. 5. 25 15:56, Dr. Thomas Orgis via dev wrote: Hi, this may be some thing already convered, but then it may be hidden … I work a lot in a repository with several levels of directories that have copy/merge relations to each other. Hence I often need to do something like $ cd /checkout/some/

Re: Binary Patch (xpatch)

2025-05-20 Thread Branko Čibej
On 18. 5. 25 21:48, Branko Čibej wrote: [1] We do have Relax-NG schemas for some of the --xml comand outputs, though I'm not sure how up-to-date they are; but I don't think we even use them for validation in the test suite. We do now, r1925717. Someone please test this on Windows

Re: 2FA prototype

2025-05-19 Thread Branko Čibej
On 19. 5. 25 21:30, Branko Čibej wrote: On 19. 5. 25 20:26, Peter Balogh wrote: Hi, So an OAuth based 2FA auth flow would result in a cookie in the browser Why don't we extend SVN to handle the same flow? No technical reason except that no-one sane wants to implement a real HTTP br

Re: 2FA prototype

2025-05-19 Thread Branko Čibej
On 19. 5. 25 20:26, Peter Balogh wrote: Hi, So an OAuth based 2FA auth flow would result in a cookie in the browser Why don't we extend SVN to handle the same flow? No technical reason except that no-one sane wants to implement a real HTTP browser in Subversion, with cookies and all that en

Re: 2FA prototype

2025-05-19 Thread Branko Čibej
On 19. 5. 25 19:33, Greg Stein wrote: [clarifying] On Mon, May 19, 2025 at 12:28 PM Greg Stein wrote: Using an OAuth-based workflow that incorporates 2FA. That is already possible. I've already seen this done. What is *really* hard is to incorporate 2FA into the svn client/l

Re: 2FA prototype

2025-05-19 Thread Branko Čibej
On 19. 5. 25 19:28, Greg Stein wrote: For svn+ssh, since we control both ends of that conversation, it would be possible to add an additional challenge/response for a 2FA (TOTP?) mechanism. I find this rather dubious, however, as SSH access already implies a very intimate level of access and ma

Re: Binary Patch (xpatch)

2025-05-18 Thread Branko Čibej
On 18. 5. 25 22:09, Timofei Zhakov wrote: On Sun, May 18, 2025 at 9:48 PM Branko Čibej wrote: On 23. 11. 24 11:26, Timofei Zhakov wrote: Hi! I am using patches frequently, however, 'svn diff' and 'svn patch' commands currently have several limitations:

Re: Binary Patch (xpatch)

2025-05-18 Thread Branko Čibej
On 23. 11. 24 11:26, Timofei Zhakov wrote: Hi! I am using patches frequently, however, 'svn diff' and 'svn patch' commands currently have several limitations: 1. They do not track tree changes (like copies and moves) 2. Binary file modifications are not tracked in plain-text patches 3. Unidiff

Re: svn commit: r1925671 - /subversion/trunk/subversion/libsvn_repos/config_file.c

2025-05-18 Thread Branko Čibej
On 18. 5. 25 16:13, br...@apache.org wrote: Author: brane Date: Sun May 18 14:13:28 2025 New Revision: 1925671 URL:http://svn.apache.org/viewvc?rev=1925671&view=rev Log: Remove a duplicated stream implementation from libsvn_repos and replace it with code that we already had in libsvn_subr when t

Re: svn propchange: r1925652 - svn:log

2025-05-18 Thread Branko Čibej
On 18. 5. 25 13:13, br...@apache.org wrote: Author: brane Revision: 1925652 Modified property:svn:log Modified:svn:log at Sun May 18 11:13:31 2025 -- ---svn:log (original) +++svn:log Sun May 18 11:13:31 2025 @@ -1,4 +

Re: svn commit: r1925565 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c tests/libsvn_client/client-test.c

2025-05-15 Thread Branko Čibej
On 15. 5. 25 18:30, rin...@apache.org wrote: Author: rinrab Date: Thu May 15 16:30:35 2025 New Revision: 1925565 [...] --- subversion/trunk/subversion/include/svn_client.h (original) +++ subversion/trunk/subversion/include/svn_client.h Thu May 15 16:30:35 2025 @@ -7771,6 +7771,28 @@ svn_clien

Re: svn commit: r1925463 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2025-05-08 Thread Branko Čibej
On 9. 5. 25 03:57, Branko Čibej wrote: The more I look at this change, the more I wonder if svn_client_patch() should be deprecated at all. It's clearly a useful bit of code, since we can use it in our command-line implementation. It's also far easier to use by third parties if t

  1   2   3   4   5   6   7   8   9   10   >