On 2. 7. 25 18:21, brainy (via GitHub) wrote:
brainy commented on code in PR #32: URL:https://github.com/apache/subversion/pull/32#discussion_r2180482516########## subversion/libsvn_ra_serf/util.c: ########## @@ -958,7 +982,14 @@ svn_ra_serf__context_run(svn_ra_serf__session_t *sess, _("Error running context")); }- return svn_ra_serf__wrap_err(status, _("Error running context"));+ if (sess->ssl_error) + { + return sess->ssl_error; + } + else + { + return svn_ra_serf__wrap_err(status, _("Error running context")); + } Review Comment: You're right. This can wait until after this PR is merged, and can happen on trunk in one commit. I suspect that when the proposal for `svn_ra_serf__wrap_err` gets reviewed in detail, it'll turn out that other call sites could make good use of a child error parameter.
The davautocheck builder failed in ra_tests when validating this PR, with an "Unknown test failure (-11)". I've seen this happen on macOS as well, where errno 11 is EDEADLK. But that's not the case on Linux.
-- Brane
