On 19. 6. 25 16:00, Branko Čibej wrote:
On 19. 6. 25 14:48, Graham Leggett via dev wrote:
Hi all,
Trying a routine build of subversion-trunk on EL9, and have added the
--with-serf=yes option expecting it to find the
/usr/lib64/pkgconfig/serf.pc
file.
No luck:
[minfrin@rocky9 subversion-trunk]$ ./configure --with-serf=yes
configure: Configuring Subversion 1.15.0
[snip]
configure: serf library configuration via pkg-config
checking for serf-2 library... no
checking for serf-1 library... no
checking was serf enabled... no
An appropriate version of serf could not be found, so libsvn_ra_serf
will not be built. If you want to build libsvn_ra_serf, please
install serf 1.3.4 or newer.
configure: error: Serf was explicitly enabled but an appropriate
version was not found.
This appears to have been broken for quite some time:
https://stackoverflow.com/questions/68725757/how-to-properly-configure-serf-during-subversion-compilation
This quick hack seems to fix it, can anyone confirm this is correct?
Index: build/ac-macros/serf.m4
===================================================================
--- build/ac-macros/serf.m4(revision 1926483)
+++ build/ac-macros/serf.m4(working copy)
@@ -140,7 +140,7 @@
[
AC_MSG_NOTICE([serf library configuration via pkg-config])
if test -n "$PKG_CONFIG"; then
- for serf_major in serf-2 serf-1; do
+ for serf_major in serf-2 serf-1 serf; do
AC_MSG_CHECKING([for $serf_major library])
if test -n "$serf_prefix" ; then
dnl User provided a prefix so we try to find the pc file under
No, it's not. Whoever installed serf.pc instead of serf-1.pc should be
summarily shot. Throwing away version discriminators is the root of
all evil (along with all the other roots of all evil).
Serf itself installs serf-1.pc since forever (and serf-2.pc from trunk.
FWIW: I build trunk Subversion with an installed Serf (either serf-2
built from trunk, or serf-1 from the 1.4.x or 1.3.x branch) and have no
problems. Serf's 'make install' works the way it's expected to.
-- Brane
