On 26. 5. 25 21:12, Timofei Zhakov wrote:
On Mon, May 26, 2025 at 8:54 PM Branko Čibej <br...@apache.org> wrote:
On 26. 5. 25 15:40, Timofei Zhakov wrote:
Would this be helpful?
(see the patch in the attachments)
This just throws out all the dependency setup and special-cases
schema verification, it doesn't actually solve the underlying
problem. You'll notice from the logs that creating and using the
virtual environment is *not* the reason for the test failures.
Yes, but this is the purpose of the patch. Since I want to avoid
downloading dependencies, I'm suggesting adding an option and asking
users to install it.
If I am not mistaken, it takes a single `pip install` invocation to
setup all dependencies, so what are the reasons to download them at
run-time?
It takes more than a single pip install to set up a virtual environment
so that you don't pollute your system. Like I said, enabling offline
testing is not my priority right now, there are other issues with the
XML output, and with the semantics of schema validation, that are more
important.
I wouldn't mind at all if you could be a little more patient and not
expect everything to be fixed right this second.
The first issue is that the CMake build does not not set
PYTHONPATH the way run_tests.py does, but that's not causing the
failures, either.
I think it does. According to the documentation
<https://cmake.org/cmake/help/latest/module/FindPython.html>, you just
need to set |Python_EXECUTABLE| option to the path to the correct program.
That's not the case at all and not what we're doing. You do not have to
use a different python in order to use packages installed in a virtual
environment. Setting PYTHONPATH is enough.
Anyway, I'll have to see what's happening in the CMake build, it's
refreshing the venv far too often.
-- Brane
