On 26. 5. 25 15:38, rin...@apache.org wrote:
Author: rinrab
Date: Mon May 26 13:38:39 2025
New Revision: 1925822
URL:http://svn.apache.org/viewvc?rev=1925822&view=rev
Log:
cmake: Add SVN_TEST_COMMAND_ARGUMENTS option that can configure additional
command line arguments to pass to our test-suite.
* CMakeLists.txt
(options): define SVN_TEST_COMMAND_ARGUMENTS
(tests): pass value of the option to add_test()
Modified:
subversion/trunk/CMakeLists.txt
Modified: subversion/trunk/CMakeLists.txt
URL:http://svn.apache.org/viewvc/subversion/trunk/CMakeLists.txt?rev=1925822&r1=1925821&r2=1925822&view=diff
==============================================================================
--- subversion/trunk/CMakeLists.txt (original)
+++ subversion/trunk/CMakeLists.txt Mon May 26 13:38:39 2025
@@ -83,6 +83,7 @@ cmake_dependent_option(SVN_ENABLE_TOOLS
option(SVN_ENABLE_TESTS "Build Subversion test-suite" OFF)
option(SVN_TEST_EXPAND "Expand tests; This will slow-down configuration, but you
will have an ability to run any subtest" OFF)
option(SVN_TEST_CONFIGURE_FOR_PARALLEL "Configures tests for parallel run
execution" OFF)
+set(SVN_TEST_COMMAND_ARGUMENTS "" CACHE STRING "Additional command line options to
be passed to run_tests.py")
option(SVN_ENABLE_APACHE_MODULES "Build modules for Apache HTTPD" OFF)
option(SVN_ENABLE_SWIG_PERL "Enable Subversion SWIG bindings for Perl" OFF)
@@ -798,6 +799,7 @@ if(SVN_ENABLE_TESTS)
--verbose
--log-to-stdout
--set-log-level=WARNING
+ ${SVN_TEST_COMMAND_ARGUMENTS}
${CMAKE_CURRENT_SOURCE_DIR}
${test_root}
"${prog}"
Shouldn't this be a list of strings? I'm worried about argument quoting
issues. Also for the path arguments, any spaces in the paths will give
interesting results. For example. "${prog}" is (correctly) quoted, even
though we control those paths and its always
"subversion/tests/something" with no spaces. But
${CMAKE_CURRENT_SOURCE_DIR} is not, and we have no control over that.
-- Brane
