On 19. 6. 25 14:45, Timofei Zhakov wrote:
On Wed, Jun 18, 2025 at 2:03 AM Branko Čibej <[email protected]> wrote:On 17. 6. 25 20:55, [email protected] wrote:Author: rinrab Revision: 1926515 Modified property:svn:log Modified:svn:log at Tue Jun 17 18:55:25 2025 ------------------------------------------------------------------------------ ---svn:log (original) +++svn:log Tue Jun 17 18:55:25 2025 @@ -1,2 +1,2 @@ -On the 'utf8-cmdline-prototype' branch: follow-up to r1925879: ensure we +On the 'utf8-cmdline-prototype' branch: follow-up to r1925879: ensure to convert the file content to utf8.Actually, the "to" was redundant, not the "we". ;) "Make sure that we convert the file contents to UTF-8", for example. But there's something missing in the log ... On the 'utf8-cmdline-prototype' branch: follow-up to r1925879. *subversion/svnadmin/svnadmin.c (subcommand_freeze): Convert file contents to UTF-8. -- Brane Okay, fixed!I agree that this log-message looks much better, but I think it should be fine to simplify them in such in-branch follow-ups, because it's like an addition to the base commit.
Or, we could follow the community guide, where it says how to write log messages. Instead of just everyone inventing their own rules (and coding styles and ...), y'know? It's only worked fine for 25 years, after all. Helped make the project so well structured, eh.
Dammit. Back to shutting up here, or my sarcasm will start throwing off fireballs. -- Brane
