Hi Ben,
> > From: rishibamba
> >
> > This patch enables a user to set importance for a new rule via
> > add-flow
> > OF1.1+ in the OVS and display the same via dump-flows command
> > OF1.1+ .
> > The changes are made in accordance with OpenFlow 1.4 specs to
> > implement
> > Eviction on the basi
From: rishibamba
This patch enables a user to set importance for a new rule via add-flow
OF1.4+ in the OVS and display the same via dump-flows command OF1.4+ .
The changes are made in accordance with OpenFlow 1.4 specs to implement
Eviction on the basis of "importance".This patch also enhances th
On Sun, Nov 02, 2014 at 08:17:31PM -0200, Ederval Pablo Ferreira wrote:
> Hi. I am trying to implement bitmap sketch in OvS. Whem I try to call the
> bitmap_allocation of the bitmap.h file in flow.c, during compilation I
> receive "implicit declaration of function bitmap_allocation"... Why such
> e
On Wed, Nov 05, 2014 at 10:46:06AM -0200, Flavio Leitner wrote:
> On Sun, Nov 02, 2014 at 08:17:31PM -0200, Ederval Pablo Ferreira wrote:
> > Hi. I am trying to implement bitmap sketch in OvS. Whem I try to call the
> > bitmap_allocation of the bitmap.h file in flow.c, during compilation I
> > rece
Hi Ben,
The second version of the "[PATCH] ovs-ofctl:To set importance of a rule for
eviction(OF14)" has been submitted today - 5 Nov,2014 for review.
We will also be submitting "[PATCH] ovs-ofctl: Implementation of eviction on
the basis of Importance" today - 5 Nov,2014 for review.
Kindly ap
From: Saloni Jain
This commit enables the eviction mechanism on the basis of importance as
per the openflow specification 1.4.
ovs-ofctl -O OpenFlow14 mod-table evict
Enable eviction on of . Eviction adds a mechanism
enabling the switch to automatically eliminate entries of lower
impo
On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component first is routing table which is configured by
> caching kernel routes and second is ARP cache which build automatically
> by snooping arp.
Hi flavio.
yeahI include bitmap.h in the flow.c fileThat's why I dont understand
such error
If you have some idea..
Thanks for the help
Best regards
Ederval Pablo Ferreira da Cruz
Professor de Informática (Instituto Federal do Espírito Santo (IFES) - Campus
Itapina)
MCP (Micr
On Wed, Nov 05, 2014 at 06:28:13PM +0530, Saloni Jain wrote:
> Hi Ben,
>
> The second version of the "[PATCH] ovs-ofctl:To set importance of a rule for
> eviction(OF14)" has been submitted today - 5 Nov,2014 for review.
>
> We will also be submitting "[PATCH] ovs-ofctl: Implementation of evicti
On Wed, Nov 05, 2014 at 01:39:20AM -0800, Eitan Eliahu wrote:
> Signed-off-by: Eitan Eliahu
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
---
lib/route-table-stub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/route-table-stub.c b/lib/route-table-stub.c
index 85c2583..5aedf5b 100644
--- a/lib/route-table-stub.c
+++ b/lib/route-table-stub.c
@@ -18,10 +
On Wed, Nov 05, 2014 at 03:54:47PM -0800, Eitan Eliahu wrote:
> Signed-off-by: Eitan Eliahu
> Acked-by: Nithin Raju
I already applied the first version.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
I missed a space between the first two parameters. I will add it in my next
change.
Thanks,
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Wednesday, November 05, 2014 8:30 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2] Fix compilat
I fixed that before I committed the original change.
On Wed, Nov 05, 2014 at 04:31:27PM +, Eitan Eliahu wrote:
> I missed a space between the first two parameters. I will add it in my next
> change.
> Thanks,
> Eitan
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
Reported-by: Martin Vizvary
Signed-off-by: Ben Pfaff
---
AUTHORS | 1 +
vswitchd/vswitch.xml | 18 ++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 1354703..2906708 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -257,6 +257,7 @@ Loga
On Fri, Oct 31, 2014 at 04:55:43PM -0700, Joe Stringer wrote:
> If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an
> additional table_instance is added to the flow_table, which is indexed
> by unique identifiers ("UFID"). Userspace implementations can specify a
> UFID of up to 1
On Wed, Nov 05, 2014 at 02:24:58PM +, Ederval Pablo Ferreira da Cruz wrote:
> Hi flavio.
>
> yeahI include bitmap.h in the flow.c fileThat's why I dont understand
> such error
>
> If you have some idea..
>
> Thanks for the help
Works for me with this small patch.
diff --gi
On Fri, Oct 31, 2014 at 04:55:39PM -0700, Joe Stringer wrote:
> Currently, when a revalidator thread first dumps a flow, it creates a
> 'udpif_key' object and caches a copy of a kernel flow key. This allows
> us to perform lookups in the classifier to attribute stats and validate
> the correctness
On 5 November 2014 08:58, Ben Pfaff wrote:
> On Fri, Oct 31, 2014 at 04:55:43PM -0700, Joe Stringer wrote:
> > If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an
> > additional table_instance is added to the flow_table, which is indexed
> > by unique identifiers ("UFID"). User
On 5 November 2014 09:06, Ben Pfaff wrote:
> On Fri, Oct 31, 2014 at 04:55:39PM -0700, Joe Stringer wrote:
> > Currently, when a revalidator thread first dumps a flow, it creates a
> > 'udpif_key' object and caches a copy of a kernel flow key. This allows
> > us to perform lookups in the classifi
On Nov 4, 2014, at 12:52 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:41PM -0700, Jarno Rajahalme wrote:
>> Some struct cls_subtable fields were documented of being const. Make
>> them const and use CONST_CAST where appropriate to initialize them.
>>
>> This will help catch future erro
Thanks for reviewing Pravin.
On 11/5/14 12:16 AM, Pravin Shelar wrote:
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
Implementation of the pop_eth and push_eth actions in the kernel, and
layer 3 flow support.
Signed-off-by: Lorand Jakab
---
datapath/actions.c| 85
Added a function Set-VMNetworkAdapterOVSPortDirect() to be called from
NOVA driver to set a name on the port of the first VNIC for the specified VM.
Usage example:
Set-VMNetworkAdapterOVSPortDirect -OVSPortName ovs-port-5 -VMName NoOS
To confirm that the name was set:
Get-VMNetworkAdapterByOVSPor
Packets with 'LATER' fragment do not have a transport header, so it is
not possible to either match on or set transport ports on such
packets. Matching is prevented by augmenting mf_are_prereqs_ok() with
a nw_frag 'LATER' bit check. Setting the transport headers on such
packets is prevented in th
Ethernet frames may contain padding after the IP payload. When
parsing IP packets, check the IP total size (IPv4) or IP payload size
(IPv6) to detect the size of l2 padding. The l2 padding size is
stored in the ofpbuf to prevent ofpbuf_pull from entering the padding,
as well as to allow ofpbuf_l4
Hi Flavio
I will try to compile such code and give you a feedback...
Thanks a lot for the help
Best regards
Ederval Pablo Ferreira da Cruz
Professor de Informática (Instituto Federal do Espírito Santo (IFES) - Campus
Itapina)
MCP (Microsoft Certified Professional) - Windows Server 2003 /
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 14c3072..d2d0ae5 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -1184,8 +1
Hello,
I am trying to run the command add-meter on ova but it is showing me some
errors and I am not able to add meter in the switch! Kindly let me know the
proper method so that I can add meter in a switch.
Kindly let me know as soon as possible. I have attached a screenshot for my ova
versi
On 5 November 2014 12:30, Harsh Gmail wrote:
> Hello,
>
>
> I am trying to run the command add-meter on ova but it is showing me some
> errors and I am not able to add meter in the switch! Kindly let me know the
> proper method so that I can add meter in a switch.
>
> Kindly let me know as soon a
> +case OID_SWITCH_PORT_UPDATED:
> +HvDeletePort(switchObject, portParam);
> +status = HvCreatePort(switchObject, portParam);
> + break;
hi Eitan,
While this change is ok in general, can you pls. comment on how this code will
work if the port is in CONNECTED state, and
On Nov 5, 2014, at 9:12 PM, Ankur Sharma
wrote:
> Signed-off-by: Ankur Sharma
> ---
> datapath-windows/ovsext/Flow.c | 2 --
> 1 file changed, 2 deletions(-)
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailma
On Tue, Nov 4, 2014 at 12:48 PM, Ben Pfaff wrote:
> On Thu, Oct 23, 2014 at 03:52:33PM -0700, Andy Zhou wrote:
>> OVS userspace are backward compatible with older Linux kernel modules.
>> However, not having the most up-to-date datapath kernel modules can
>> some times lead to user confusion. Stor
OVS userspace are backward compatible with older Linux kernel modules.
However, not having the most up-to-date datapath kernel modules can
some times lead to user confusion. Storing the datapath version in
OVSDB allows management software to check and optionally provide
notifications to users.
Sig
On Fri, Oct 31, 2014 at 04:55:39PM -0700, Joe Stringer wrote:
> Currently, when a revalidator thread first dumps a flow, it creates a
> 'udpif_key' object and caches a copy of a kernel flow key. This allows
> us to perform lookups in the classifier to attribute stats and validate
> the correctness
On 5 November 2014 13:31, Ben Pfaff wrote:
> On Fri, Oct 31, 2014 at 04:55:39PM -0700, Joe Stringer wrote:
> > Currently, when a revalidator thread first dumps a flow, it creates a
> > 'udpif_key' object and caches a copy of a kernel flow key. This allows
> > us to perform lookups in the classifi
On Wed, Nov 05, 2014 at 01:32:32PM -0800, Andy Zhou wrote:
> OVS userspace are backward compatible with older Linux kernel modules.
> However, not having the most up-to-date datapath kernel modules can
> some times lead to user confusion. Storing the datapath version in
> OVSDB allows management so
On Wed, Nov 05, 2014 at 01:32:32PM -0800, Andy Zhou wrote:
> OVS userspace are backward compatible with older Linux kernel modules.
> However, not having the most up-to-date datapath kernel modules can
> some times lead to user confusion. Storing the datapath version in
> OVSDB allows management so
Hi Nithin,
Actually ovsState will get updated from portParam->PortState in
OvsInitVportWithPortParam() so this should not be an issue.
But, there may be an issue with the nic parameters stored in the voprt.
Even when the documentation reads that only "currently" the port friendly name
could get
On Wed, Nov 05, 2014 at 08:04:29PM -0200, Flavio Leitner wrote:
> The above is not available in Fedora 20.
> # stat /sys/module/openvswitch/version
> stat: cannot stat ???/sys/module/openvswitch/version???: No such file or
> directory
> # uname -r
> 3.16.7-200.fc20.x86_64
You only get it with the
On Nov 5, 2014, at 11:06 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> Actually ovsState will get updated from portParam->PortState in
> OvsInitVportWithPortParam() so this should not be an issue.
> But, there may be an issue with the nic parameters stored in the voprt.
> Even when the documentation r
On Wed, Nov 05, 2014 at 06:09:19PM -0800, Eitan Eliahu wrote:
> Added a function Set-VMNetworkAdapterOVSPortDirect() to be called from
> NOVA driver to set a name on the port of the first VNIC for the specified VM.
>
> Usage example:
> Set-VMNetworkAdapterOVSPortDirect -OVSPortName ovs-port-5 -VMN
Series of 2 patches to enable quick flow lookup for a specific pattern of flows
in the datapath.
Michio Honda (2):
datapath: framework for quick flow key extraction and lookup
datapath: quick flow lookup for source and destination MAC addresses
datapath/actions.c | 20 --
datapath
This patch implements a least-possible flow extraction
and lookup for L2 source and destination MAC address,
which is activated when all the flows in the datapath
involve in only source and destination MAC addresses
(i.e, the other fields are wildcarded).
This code improves forwarding rate between
Parsing packets against all the flow-key fields and lookup
is expensive.
This patch enables to implement least-possible flow
key extraction and/or packet lookup for a specific pattern
of flows installed in the datapath (e.g., all the flows
are interested in only source and destination MAC addresses
On Mon, Nov 03, 2014 at 11:36:29PM +0200, Lorand Jakab wrote:
> These actions will allow L2->L3 and L3->L2 switching, and are supposed
> to be added to flows installed in the datapath transparently by
> ovs-vswitchd.
>
> Signed-off-by: Lorand Jakab
Acked-by: Ben Pfaff
__
This would be the easiest but I have concerns that some other parameters would
be updated as well in new versions of NDIS.
I am checking into it.
Thank you,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, November 05, 2014 2:15 PM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subj
On Mon, Nov 03, 2014 at 11:36:30PM +0200, Lorand Jakab wrote:
> This commit relaxes the assumption that all packets have an Ethernet
> header, and adds support for layer 3 flows. For each packet received on
> the Linux kernel datapath the l2 and l3 members of struct ofpbuf are
> intialized appropr
It it no longer used, so better remove it.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c | 12 +---
ofproto/ofproto-dpif-xlate.h |2 +-
ofproto/ofproto-dpif.c |2 +-
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlat
Move the frags handling check up in the call chain, so that it is done
once for each rule_dpif_lookup_from_table() call.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c |4 +-
ofproto/ofproto-dpif.c | 103 +-
ofproto/ofproto-dpif
Keep knowledge about ofproto-dpif internal rules within ofproto-dpif.
This removes duplication of code (accross multiple files), and allows
making the ofproto-dpif-xlate interface a bit smaller.
'may_packet_in' was previously not honored for the
'LOOKUP_VERDICT_DEFAULT' case. Now it is, but this
On Wed, Nov 05, 2014 at 02:07:08PM -0800, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 08:04:29PM -0200, Flavio Leitner wrote:
> > The above is not available in Fedora 20.
> > # stat /sys/module/openvswitch/version
> > stat: cannot stat ???/sys/module/openvswitch/version???: No such file or
> > direc
On Wed, Nov 5, 2014 at 5:59 AM, Flavio Leitner wrote:
> On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote:
>> Following patch adds support for userspace tunneling. Tunneling
>> needs three more component first is routing table which is configured by
>> caching kernel routes and secon
ovs_router_unixctl_register() is called from ofproto layer.
But is not defined for all platform. Following patch define
stub to fix compilation error.
Reported-by: Eitan Eliahu
Signed-off-by: Pravin B Shelar
---
lib/route-table-bsd.c |5 +
lib/route-table-stub.c |5 +
2 files c
On Wed, Nov 5, 2014 at 2:56 PM, Flavio Leitner wrote:
> On Wed, Nov 05, 2014 at 02:07:08PM -0800, Ben Pfaff wrote:
>> On Wed, Nov 05, 2014 at 08:04:29PM -0200, Flavio Leitner wrote:
>> > The above is not available in Fedora 20.
>> > # stat /sys/module/openvswitch/version
>> > stat: cannot stat ???
Pushed with the xml updates. Ben, Thanks for the wirte-up and review!
On Wed, Nov 5, 2014 at 1:59 PM, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 01:32:32PM -0800, Andy Zhou wrote:
>> OVS userspace are backward compatible with older Linux kernel modules.
>> However, not having the most up-to-date
The original code should work even when the port is connected. The port
structure is not being reallocated rather just marked as deleted.
The issue is with create port function which insert the port to do the port
list even when it is already created.
This should be handled in a spate change.
Th
On Wed, Nov 05, 2014 at 03:23:24PM -0800, Andy Zhou wrote:
> On Wed, Nov 5, 2014 at 2:56 PM, Flavio Leitner wrote:
> > On Wed, Nov 05, 2014 at 02:07:08PM -0800, Ben Pfaff wrote:
> >> On Wed, Nov 05, 2014 at 08:04:29PM -0200, Flavio Leitner wrote:
> >> > The above is not available in Fedora 20.
> >
> The original code should work even when the port is connected.
> The port structure is not being reallocated rather just marked as deleted.
> The issue is with create port function which insert the port to do the port
> list even when it is already created.
This is true only if that port has b
On Wed, Nov 5, 2014 at 3:47 PM, Flavio Leitner wrote:
> On Wed, Nov 05, 2014 at 03:23:24PM -0800, Andy Zhou wrote:
>> On Wed, Nov 5, 2014 at 2:56 PM, Flavio Leitner wrote:
>> > On Wed, Nov 05, 2014 at 02:07:08PM -0800, Ben Pfaff wrote:
>> >> On Wed, Nov 05, 2014 at 08:04:29PM -0200, Flavio Leitne
Correct, we need to mark is as deleted even if it was not added from user mode
(so memory won't be released). If it gets too complex I will just update the
port parameters.
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, November 05, 2014 3:50 PM
To: Eitan Eliahu
Cc:
On Wed, Nov 05, 2014 at 03:51:30PM -0800, Andy Zhou wrote:
> On Wed, Nov 5, 2014 at 3:47 PM, Flavio Leitner wrote:
> > On Wed, Nov 05, 2014 at 03:23:24PM -0800, Andy Zhou wrote:
> >> On Wed, Nov 5, 2014 at 2:56 PM, Flavio Leitner wrote:
> >> > On Wed, Nov 05, 2014 at 02:07:08PM -0800, Ben Pfaff w
Thanks, Simon!
Acked-by: Jarno Rajahalme
Pushed to master,
Jarno
On Nov 4, 2014, at 8:57 PM, Simon Horman wrote:
> parse_ofp_group_mod_str() may limit the usable protocols according
> to the group and in particular its actions. However, without this
> change ovs-ofctl ignores this c
On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component first is routing table which is configured by
> caching kernel routes and second is ARP cache which build automatically
> by snooping arp.
Acked-by: Jarno Rajahalme -
On Nov 5, 2014, at 3:21 PM, Pravin B Shelar wrote:
> ovs_router_unixctl_register() is called from ofproto layer.
> But is not defined for all platform. Following patch define
> stub to fix compilation error.
>
> Reported-by: Eitan Eliahu
> Signed-off-by: Pravin B Sh
On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
> Thanks for reviewing Pravin.
>
>
> On 11/5/14 12:16 AM, Pravin Shelar wrote:
>>
>> On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
>>>
>>> Implementation of the pop_eth and push_eth actions in the kernel, and
>>> layer 3 flow support.
>>>
>
On 11/6/14 12:36 AM, Ben Pfaff wrote:
On Mon, Nov 03, 2014 at 11:36:30PM +0200, Lorand Jakab wrote:
This commit relaxes the assumption that all packets have an Ethernet
header, and adds support for layer 3 flows. For each packet received on
the Linux kernel datapath the l2 and l3 members of str
66 matches
Mail list logo
