On Fri, Oct 31, 2014 at 04:55:39PM -0700, Joe Stringer wrote: > Currently, when a revalidator thread first dumps a flow, it creates a > 'udpif_key' object and caches a copy of a kernel flow key. This allows > us to perform lookups in the classifier to attribute stats and validate > the correctness of the datapath flow. > > This patch sets up this cache from the handler threads, during flow > setup. While this patch alone causes a decrease in revalidation > performance, it allows future patches increase performance by reducing > the cost of flow dumping. > > Revalidators will continue to create ukeys if a flow is dumped that has > no corresponding ukey. This may happen in corner cases such as when > ovs-vswitchd is restarted (and flows remain in the datapath) or a user > installs a flow using ovs-dpctl. > > Signed-off-by: Joe Stringer <joestrin...@nicira.com> > Acked-by: Ben Pfaff <b...@nicira.com>
It looks like ukey_install_start() adds a new VLOG_WARN that could flood the logs if something is going badly wrong in an unexpected way. Will you consider rate-limiting it? I'm still looking at this patch. (Unless you want me to look at more of them, I think it's the only one that I want to look at in this version. I think at this point you mostly need datapath review?) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
