> +    case OID_SWITCH_PORT_UPDATED:
> +        HvDeletePort(switchObject, portParam);
> +        status = HvCreatePort(switchObject, portParam);
> +       break;

hi Eitan,
While this change is ok in general, can you pls. comment on how this code will 
work if the port is in CONNECTED state, and we get a SWITCH_PORT_UPDATED oid? 
HvDeletePort() might free up the vport completely, and if HvCreatePort() will 
render the vport->ovsState in OVS_STATE_PORT_CREATED rather than 
OVS_STATE_CONNECTED. Some more fixes might need to be done for this code to 
work. Did you get a chance to test this code on a NIC that is already connected?

thanks,
Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to