On 5 November 2014 08:58, Ben Pfaff <b...@nicira.com> wrote:
> On Fri, Oct 31, 2014 at 04:55:43PM -0700, Joe Stringer wrote:
> > If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an
> > additional table_instance is added to the flow_table, which is indexed
> > by unique identifiers ("UFID"). Userspace implementations can specify a
> > UFID of up to 128 bits along with a flow operation as shorthand for the
> > key. This allows revalidation performance improvements of up to 50%.
> >
> > If a datapath is created using OVS_DP_F_INDEX_BY_UFID and a UFID is not
> > specified at flow setup time, then that operation will fail. If
> > OVS_UFID_F_* flags are specified for an operation, then they will modify
> > what is returned through the operation. For instance, OVS_UFID_F_SKIP_KEY
> > allows the datapath to skip returning the key (eg, during dump to reduce
> > memory copy).
> >
> > Signed-off-by: Joe Stringer <joestrin...@nicira.com>
>
> As purely a naming issue, I believe that the UFID attributes with "skip"
> in their names in this patch ask the kernel to leave things out of its
> replies. If so, to me, "omit" reads as a better term than "skip".
>
Sure, I'm happy to roll in this change with any other feedback I get on
this patch.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
