On 04/09/2014 01:10 AM, Pritesh Kothari wrote:
Signed-off-by: Pritesh Kothari
---
v2: Use OVS_GREP_IFELSE instead of upstream kernel versions as Thomas suggested.
---
FAQ |2 +-
NEWS |2 +-
ac
On 04/09/2014 01:38 AM, Jarno Rajahalme wrote:
Key attributes relating to actual packet headers are ignored for
OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
from the packet itself.
Signed-off-by: Jarno Rajahalme
LGTM
Acked-by: Thomas Graf
__
On 04/09/2014 01:38 AM, Jarno Rajahalme wrote:
Masked set actions allow more megaflow wildcarding. All other key
types than the tunnel key that can be set, can now be set with a mask.
It is not clear wether masked set is useful for skb_priority.
However, we already use the LSB of pkt_mark for I
On 04/08/2014 12:00 AM, Pravin wrote:
From: Pravin Shelar
On every packet OVS needs to lookup flow-table with every mask.
the packet flow-key is first masked with mask in the list and
then the masked key is looked up in flow-table. Therefore number
of masks can affect packet processing perform
On 04/08/2014 12:00 AM, Pravin wrote:
+struct sw_flow *ovs_flow_tbl_lookup_stats(struct flow_table *tbl,
+ const struct sw_flow_key *key,
+ u32 skb_hash,
+ u32 *n_mask_hit)
+{
+
2014-04-08 18:51 GMT-04:00 Nicholas Bastin :
> There are two variants of this device - one with an AR9132 (boring white
> case), and one with a QCA9558 (blue spaceship-looking thing). The AR9132
> version uses a separate switch ASIC (AR8316 - I have one of these), so your
> max throughput through
*Life Insurance policy can last a lifetime, as long as premiums are
paid. Coverage doubles during the year your child is 18, with no
increase in premium. For children 14 days to 14 years old.
Gerber Life ?? Continuing the long Gerber tradition of helping
parents care for their children since
Inform about fallback to trunk mode and convert errors to warnings
when we are not failing.
Signed-off-by: Thomas Graf
---
vswitchd/bridge.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 24b3602..c6095b2 100644
--- a/vswitchd
Does this mean we send in pull requests from github and no more patches on
mailing lists?
Regards,
Pritesh
On Apr 8, 2014, at 5:04 PM, Ben Pfaff wrote:
> Applied to master, thanks!
>
> On Tue, Apr 08, 2014 at 04:46:19PM -0700, Justin Pettit wrote:
>> Acked-by: Justin Pettit
>>
>>
>>
>> On
This is the ported version of commit 36d5fe6a with the same name from net-next.
Apart from the small datapath.c changes it adjust the compat layer files as
well. This is the original commit message:
"skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also,
I don't know if Kyle posted this already, but I needed it anyway, so I
sent in my version.
Zoli
On 09/04/14 17:20, Zoltan Kiss wrote:
This is the ported version of commit 36d5fe6a with the same name from net-next.
Apart from the small datapath.c changes it adjust the compat layer files as
well
On Wed, Apr 09, 2014 at 03:57:45PM +, Pritesh Kothari (pritkoth) wrote:
> Does this mean we send in pull requests from github and no more
> patches on mailing lists?
It isn't clear yet how pull requests fit in with the Open vSwitch
workflow. If people start sending them, then we'll start revi
On Wed, Apr 09, 2014 at 09:37:24AM -0700, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 03:57:45PM +, Pritesh Kothari (pritkoth) wrote:
> > Does this mean we send in pull requests from github and no more
> > patches on mailing lists?
>
> It isn't clear yet how pull requests fit in with the Open v
On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote:
> Inform about fallback to trunk mode and convert errors to warnings
> when we are not failing.
>
> Signed-off-by: Thomas Graf
I'm pretty sure that the first one, as the comment says, really can't
happen. Have you been able to trigger
On Wed, Apr 09, 2014 at 09:52:03AM -0700, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote:
> > Inform about fallback to trunk mode and convert errors to warnings
> > when we are not failing.
> >
> > Signed-off-by: Thomas Graf
>
> I'm pretty sure that the first one,
On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote:
> Thanks Alex.
>
> There is also one minor fix to be rolled in:
>
> @@ -1403,8 +1416,8 @@ revalidate_ukey(struct udpif *udpif, struct udpif_key
> *ukey,
> compose_slow_path(udpif, &xout, odp_in_port, &xout_actions);
> }
>
On Tue, Apr 08, 2014 at 01:37:04PM -0700, Andy Zhou wrote:
> Packet metadata fields may be modified when execute post recirculation
> actions. Current implementation only preserves recirc_id and dp_hash,
> but not other fields. With this patch, a copy of metadata is supplied
> instead of the origin
Needs a sign-off.
Does this visibly change any behavior? If not:
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Apr 08, 2014 at 04:38:43PM -0700, Jarno Rajahalme wrote:
> It is better to not abort().
>
> Signed-off-by: Jarno Rajahalme
Please backport as far as necessary.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On Tue, Apr 08, 2014 at 04:38:44PM -0700, Jarno Rajahalme wrote:
> Later patches rely on the DSCP and ECN masks to be properly set when
> the fields are read. Also, avoid reading nw_tos if tunnel's inner
> packet is not IP.
>
> Signed-off-by: Jarno Rajahalme
I guess that these don't really caus
On Tue, Apr 08, 2014 at 04:38:45PM -0700, Jarno Rajahalme wrote:
> ofproto/trace incorrectly reported the megaflow based on the modified
> flow, rather than the original flow key. Now the original flow key is
> stored before any modifications and is used for reporting the megaflow.
>
> Also, flow
On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote:
> If the field does not exist, nothing is set. However, we must
> unwildcard the bits we used to make the decision, and we need not
> unwildcard the field and it's prerequisities, if nothing is set.
>
> Signed-off-by: Jarno Rajahalm
On Wed, Apr 9, 2014 at 10:11 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 01:37:04PM -0700, Andy Zhou wrote:
>> Packet metadata fields may be modified when execute post recirculation
>> actions. Current implementation only preserves recirc_id and dp_hash,
>> but not other fields. With this patch
On Wed, Apr 9, 2014 at 10:12 AM, Ben Pfaff wrote:
> Needs a sign-off.
>
will fix
> Does this visibly change any behavior? If not:
No.
> Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Apr 9, 2014 at 9:48 AM, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 09:37:24AM -0700, Ben Pfaff wrote:
>> On Wed, Apr 09, 2014 at 03:57:45PM +, Pritesh Kothari (pritkoth) wrote:
>> > Does this mean we send in pull requests from github and no more
>> > patches on mailing lists?
>>
>> It
On Tue, Apr 08, 2014 at 04:38:47PM -0700, Jarno Rajahalme wrote:
> Masked set actions add a mask, immediately following the netlink
> attribute data, within the netlink attribute itself. Thus the key
> attribute size for a masked set action is exactly double of the
> non-masked set action.
>
> Si
On Wed, Apr 09, 2014 at 10:39:31AM -0700, Gurucharan Shetty wrote:
> On Wed, Apr 9, 2014 at 9:48 AM, Ben Pfaff wrote:
> > On Wed, Apr 09, 2014 at 09:37:24AM -0700, Ben Pfaff wrote:
> >> On Wed, Apr 09, 2014 at 03:57:45PM +, Pritesh Kothari (pritkoth) wrote:
> >> > Does this mean we send in pul
On Tue, Apr 08, 2014 at 04:38:48PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Does the masked set action cause EINVAL or ERANGE on older kernels.
Comments say EINVAL in two places, ERANGE in one, and the code
actually looks for EINVAL.
_
Pushed, I hope it applies now!
Jarno
On Apr 9, 2014, at 10:22 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:45PM -0700, Jarno Rajahalme wrote:
>> ofproto/trace incorrectly reported the megaflow based on the modified
>> flow, rather than the original flow key. Now the original flow key
On Apr 9, 2014, at 10:19 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:44PM -0700, Jarno Rajahalme wrote:
>> Later patches rely on the DSCP and ECN masks to be properly set when
>> the fields are read. Also, avoid reading nw_tos if tunnel's inner
>> packet is not IP.
>>
>> Signed-off-by
Pushed to master and branch-2.1,
Thanks,
Jarno
On Apr 9, 2014, at 10:14 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:43PM -0700, Jarno Rajahalme wrote:
>> It is better to not abort().
>>
>> Signed-off-by: Jarno Rajahalme
>
> Please backport as far as necessary.
>
> Acked-by: Ben
Pushed. Thanks.
On Wed, Apr 9, 2014 at 10:34 AM, Andy Zhou wrote:
> On Wed, Apr 9, 2014 at 10:11 AM, Ben Pfaff wrote:
>> On Tue, Apr 08, 2014 at 01:37:04PM -0700, Andy Zhou wrote:
>>> Packet metadata fields may be modified when execute post recirculation
>>> actions. Current implementation only
Pushed. Thanks.
On Wed, Apr 9, 2014 at 10:35 AM, Andy Zhou wrote:
> On Wed, Apr 9, 2014 at 10:12 AM, Ben Pfaff wrote:
>> Needs a sign-off.
>>
> will fix
>> Does this visibly change any behavior? If not:
> No.
>> Acked-by: Ben Pfaff
___
dev mailing li
Thanks for the review, pushed to master and branch-2.1
Jarno
On Apr 9, 2014, at 10:25 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote:
>> If the field does not exist, nothing is set. However, we must
>> unwildcard the bits we used to make the decision,
On Apr 9, 2014, at 10:51 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:47PM -0700, Jarno Rajahalme wrote:
>> Masked set actions add a mask, immediately following the netlink
>> attribute data, within the netlink attribute itself. Thus the key
>> attribute size for a masked set action is
On Tue, Apr 08, 2014 at 04:38:49PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Consider this code from commit_set_ether_addr_action():
bool have_mask_src = !eth_addr_is_zero(wc->masks.dl_src);
bool have_mask_dst = !eth_addr_is_zero(wc->masks.dl_dst);
...
memcpy(b
On Apr 9, 2014, at 11:03 AM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:48PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Does the masked set action cause EINVAL or ERANGE on older kernels.
> Comments say EINVAL in two places, ERANGE in one, and the code
> actually
On Wed, Apr 09, 2014 at 01:11:40PM -0700, Jarno Rajahalme wrote:
> On Apr 9, 2014, at 10:25 AM, Ben Pfaff wrote:
>
> > On Tue, Apr 08, 2014 at 04:38:46PM -0700, Jarno Rajahalme wrote:
> >> If the field does not exist, nothing is set. However, we must
> >> unwildcard the bits we used to make the
On Wed, Apr 09, 2014 at 01:24:07PM -0700, Jarno Rajahalme wrote:
>
> On Apr 9, 2014, at 10:51 AM, Ben Pfaff wrote:
>
> > On Tue, Apr 08, 2014 at 04:38:47PM -0700, Jarno Rajahalme wrote:
> >> Masked set actions add a mask, immediately following the netlink
> >> attribute data, within the netlink
On Tue, Apr 08, 2014 at 04:38:50PM -0700, Jarno Rajahalme wrote:
> Key attributes relating to actual packet headers are ignored for
> OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
> from the packet itself.
>
> Signed-off-by: Jarno Rajahalme
There is a typo in the subject.
-
On Tue, Apr 08, 2014 at 04:38:51PM -0700, Jarno Rajahalme wrote:
> Masked set actions allow more megaflow wildcarding. All other key
> types than the tunnel key that can be set, can now be set with a mask.
>
> It is not clear wether masked set is useful for skb_priority.
> However, we already use
On Tue, Apr 08, 2014 at 04:38:52PM -0700, Jarno Rajahalme wrote:
> It would seem that we should set the 'tun_dst' in 'wc' when calling
> tnl_port_should_receive(), as it is reading that flow field.
>
> However, tnl_port_should_receive() returns true, if the flow has
> tunnel metadata. If there is
Ben,
Thanks for your review. Some comments below,
Jarno
On Apr 9, 2014, at 1:19 PM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:49PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Consider this code from commit_set_ether_addr_action():
>
>bool have_mask_src
On Apr 9, 2014, at 1:26 PM, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 01:24:07PM -0700, Jarno Rajahalme wrote:
>>
>> On Apr 9, 2014, at 10:51 AM, Ben Pfaff wrote:
>>
>>> On Tue, Apr 08, 2014 at 04:38:47PM -0700, Jarno Rajahalme wrote:
Masked set actions add a mask, immediately following
On Wed, Apr 9, 2014 at 1:51 PM, Jarno Rajahalme wrote:
>
> On Apr 9, 2014, at 1:26 PM, Ben Pfaff wrote:
>
> On Wed, Apr 09, 2014 at 01:24:07PM -0700, Jarno Rajahalme wrote:
>
>
> On Apr 9, 2014, at 10:51 AM, Ben Pfaff wrote:
>
> On Tue, Apr 08, 2014 at 04:38:47PM -0700, Jarno Rajahalme wrote:
>
On 04/09/2014 06:57 PM, Ben Pfaff wrote:
On Wed, Apr 09, 2014 at 09:52:03AM -0700, Ben Pfaff wrote:
On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote:
Inform about fallback to trunk mode and convert errors to warnings
when we are not failing.
Signed-off-by: Thomas Graf
I'm pretty
On Wed, Apr 09, 2014 at 01:46:48PM -0700, Jarno Rajahalme wrote:
> > There is a doubled ';' in commit_set_ipv4_action():
> > +key.ipv4_src = base->nw_src & wc->masks.nw_src;;
> >
> > The beginning of commit_set_ipv4_action() first asserts:
> >!((a ^ b) & ~c)
> > and then checks
OK, sure.
On 10 April 2014 04:59, Ben Pfaff wrote:
> On Wed, Apr 09, 2014 at 04:36:50PM +1200, Joe Stringer wrote:
> > Thanks Alex.
> >
> > There is also one minor fix to be rolled in:
> >
> > @@ -1403,8 +1416,8 @@ revalidate_ukey(struct udpif *udpif, struct
> udpif_key
> > *ukey,
> >
On Wed, Apr 9, 2014 at 9:20 AM, Zoltan Kiss wrote:
> This is the ported version of commit 36d5fe6a with the same name from
> net-next.
> Apart from the small datapath.c changes it adjust the compat layer files as
> well. This is the original commit message:
>
> "skb_zerocopy can copy elements of
On Fri, Apr 04, 2014 at 03:00:39PM -0700, Alex Wang wrote:
> This commit adds call-back function to the tunnel monitoring protocal
> bfd/cfm to allow the session to notify the ofproto-dpif whenever its
> status changes. This helps eliminate the overhead of updating unchanged
> session status to th
On Wed, Apr 9, 2014 at 4:00 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 03:00:39PM -0700, Alex Wang wrote:
> > This commit adds call-back function to the tunnel monitoring protocal
> > bfd/cfm to allow the session to notify the ofproto-dpif whenever its
> > status changes. This helps eliminat
On Fri, Apr 04, 2014 at 03:00:40PM -0700, Alex Wang wrote:
> This commit removes the "Instant" stats related logic in bridge.c
> by moving the logic into iface_refresh_ofproto_status() and using
> the global sequence number to check whether or not to call it.
>
> Also, the 'netdev''s 'change_seq'
From: Ethan Jackson
Previously, we had a separate flow_dumper thread that fetched flows from
the datapath to distribute to revalidator threads. This patch takes the
logic for dumping and pushes it into the revalidator threads, resulting
in simpler code with similar performance to the current code
From: Joe Stringer
Previously we made heavy use of the 'ovs-appctl dpif/dump-flows' command
to verify that flows were being installed into the datapath correctly.
However this is sensitive to timing, particularly when the behaviour of
revalidator threads is modified. A common race condition invol
On Fri, Apr 04, 2014 at 03:00:41PM -0700, Alex Wang wrote:
> This commit adds a new configuration "disable-stats-update" in
> "other_config" of Open_Vswitch table. When set, it allows user
> to disable the statistics update to OVSDB. This can greatly reduce
> the cpu consumption when statistics i
On Fri, Apr 04, 2014 at 03:00:42PM -0700, Alex Wang wrote:
> This command adds a new appctl sub-command "stats/require_update", which
> allows users to force statistics update to the database when the
> 'disable-stats-update' is set.
>
> Signed-off-by: Alex Wang
Do we expect this to actually get
On Fri, Apr 04, 2014 at 03:00:43PM -0700, Alex Wang wrote:
> This commit adds a unit test for the 'ovs-appctl stats/require-update'.
>
> Signed-off-by: Alex Wang
If we really need this command at all, then I would probably fold this
patch in with the patch that adds the command.
On Fri, Apr 04, 2014 at 03:00:36PM -0700, Alex Wang wrote:
> This commit can be seen as a partial revert of commit
> da4a619179d (netdev: Globally track port status changes)
> by adding the 'change_seq' to 'struct netdev'.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
On Fri, Apr 04, 2014 at 03:00:37PM -0700, Alex Wang wrote:
> This commit makes the netdev-dpdk module signal the change of
> etheraddr and mtu by changing the global sequence number and
> incrementing its 'change_seq'.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
On Fri, Apr 04, 2014 at 03:00:38PM -0700, Alex Wang wrote:
> This commit uses the 'change_seq' in 'struct netdev' to determine
> whether to update the 'ofport'. This helps eliminate unnecessary
> update.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
_
Thx for the review Ben, please see my reply inline
On Wed, Apr 9, 2014 at 4:13 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 03:00:40PM -0700, Alex Wang wrote:
> > This commit removes the "Instant" stats related logic in bridge.c
> > by moving the logic into iface_refresh_ofproto_status() and
On Tue, Apr 01, 2014 at 12:46:20PM +0900, Simon Horman wrote:
> Hi Jesse, Hi Pravin, Hi All,
>
> This patchset makes use of a whitelist to only allow mpls_push actions to
> be applied to packets with an ethertype where the tag order is well defined
> and implemented. This avoids the problem of whe
On Wed, Apr 09, 2014 at 04:31:46PM -0700, Alex Wang wrote:
> On Wed, Apr 9, 2014 at 4:13 PM, Ben Pfaff wrote:
> > I also don't quite follow this comment in
> > iface_refresh_ofproto_status(), because it talks about a change to
> > status but actually checks for an error fetching status:
> >
> >
>
On Sat, Mar 29, 2014 at 04:01:35PM -0700, Simon Horman wrote:
> On Thu, Mar 20, 2014 at 09:37:14AM -0700, Ben Pfaff wrote:
> > On Thu, Mar 20, 2014 at 05:34:23PM +0900, Simon Horman wrote:
> > > When revalidating a flow convert xout.wc.masks, the mask calculated by
> > > translation, to a key that
On Thu, Apr 10, 2014 at 11:14:07AM +1200, Joe Stringer wrote:
> From: Joe Stringer
>
> Previously we made heavy use of the 'ovs-appctl dpif/dump-flows' command
> to verify that flows were being installed into the datapath correctly.
> However this is sensitive to timing, particularly when the beh
On Wed, Apr 9, 2014 at 4:23 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 03:00:43PM -0700, Alex Wang wrote:
> > This commit adds a unit test for the 'ovs-appctl stats/require-update'.
> >
> > Signed-off-by: Alex Wang
>
> If we really need this command at all, then I would probably fold this
>
On Tue, Apr 01, 2014 at 12:21:03PM +0900, Simon Horman wrote:
> On Thu, Mar 20, 2014 at 10:05:44AM -0700, Ben Pfaff wrote:
> > On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
> > > When creating a flow in the datapath as the result of an upcall
> > > the match itself is the match supp
Fix a bug in Openflow group implementation that neither group stats
nor per bucket stats are properly updated.
Reported-by: Marco Canini
Signed-off-by: Andy Zhou
---
AUTHORS |1 +
ofproto/ofproto-dpif-xlate.c | 22 --
ofproto/ofproto-dpif-xlate.h |
Signed-off-by: Andy Zhou
---
tests/ofproto-dpif.at | 44
1 file changed, 44 insertions(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 064407a..769df2d 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -369,6 +369
Forgot to add marco.can...@acm.org to CC
On Wed, Apr 9, 2014 at 4:43 PM, Andy Zhou wrote:
> Fix a bug in Openflow group implementation that neither group stats
> nor per bucket stats are properly updated.
>
> Reported-by: Marco Canini
> Signed-off-by: Andy Zhou
> ---
> AUTHORS
Dear Friends,
This is the Mars here. I would like to introduce the hot sales of Retro
lighting fixture for you.
If you have any plan and interest, please let me know.
Hear from your business and reply soon
Please see the photo as follow:
Best Regards
Mars
International Business De
Fix a botch in commit 7f12bdcc.
("learn.at: Fix a race in "self-modifying flow with idle_timeout" test")
Signed-off-by: YAMAMOTO Takashi
---
tests/learn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/learn.at b/tests/learn.at
index 42dd363..7245295 100644
--- a/test
Looks good, thanks!
On Apr 9, 2014 5:42 PM, "YAMAMOTO Takashi" wrote:
> Fix a botch in commit 7f12bdcc.
> ("learn.at: Fix a race in "self-modifying flow with idle_timeout" test")
>
> Signed-off-by: YAMAMOTO Takashi
> ---
> tests/learn.at | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
It had occurred to me at the time, that this was a possible middle ground
between making netdev change_seq completely global or retaining this
per-netdev seq as well as having a global seq. When I looked at perf when
many ports are configured, a majority of the cost seemed to be just in just
iterat
Hey Joe,
On Wed, Apr 9, 2014 at 6:16 PM, Joe Stringer wrote:
> It had occurred to me at the time, that this was a possible middle ground
> between making netdev change_seq completely global or retaining this
> per-netdev seq as well as having a global seq. When I looked at perf when
> many port
> @@ -3702,6 +3710,7 @@ AT_SETUP([ofproto-dpif - ovs-appctl dpif/dump-flows -
> MPLS actions that result i
can you update test titles?
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Ethan Jackson
Previously, we had a separate flow_dumper thread that fetched flows from
the datapath to distribute to revalidator threads. This patch takes the
logic for dumping and pushes it into the revalidator threads, resulting
in simpler code with similar performance to the current code
From: Joe Stringer
This makes the GitHub interface aware of the contribution guidelines,
so it will be displayed to contributors when they submit issues or pull
requests.
Signed-off-by: Joe Stringer
---
CONTRIBUTING | 211 +
SubmittingP
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 2537d30..dbf68b0 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -3678,14 +3678,15 @@ AT_CLEANUP
Leftover of commit 0c473314.
("ofproto-dpif.at: Wait for the monitor's pidfile disappears where necessary")
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 3018a84..2
These races were exposed on my environment by commit c2a77f33.
("tests/ofproto-dpif: Use vlog to test dpif behaviour.")
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto
From: Joe Stringer
Signed-off-by: Joe Stringer
---
tests/ofproto-dpif.at |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 93add7f..b12b4fe 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -3706,7 +370
From: Joe Stringer
This makes the GitHub interface aware of the contribution guidelines,
so it will be displayed to contributors when they submit issues or pull
requests.
Signed-off-by: Joe Stringer
---
v2: Update Makefile.am and OPENFLOW-1.1+.
---
CONTRIBUTING | 211
Woops, I posted a patch to do so here:
http://openvswitch.org/pipermail/dev/2014-April/038737.html
On 10 April 2014 16:24, YAMAMOTO Takashi wrote:
> > @@ -3702,6 +3710,7 @@ AT_SETUP([ofproto-dpif - ovs-appctl
> dpif/dump-flows - MPLS actions that result i
>
> can you update test titles?
>
> YA
Currently recirculation action can optionally compute hash. This patch
adds a hash action that is independent of the recirc action, which
no longer computes hash. For megaflow bond with recirc, the output
to a bond port action will look like:
hash(hash_l4(0)), recric()
Obviously, when a reci
> From: Joe Stringer
thanks.
Acked-by: YAMAMOTO Takashi
>
> Signed-off-by: Joe Stringer
> ---
> tests/ofproto-dpif.at |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
> index 93add7f..b12b4fe 100644
> --- a/tests/
Thanks. I am not a committer, could you push this for me?
On 10 Apr 2014 17:32, "YAMAMOTO Takashi" wrote:
> > From: Joe Stringer
>
> thanks.
>
> Acked-by: YAMAMOTO Takashi
>
> >
> > Signed-off-by: Joe Stringer
> > ---
> > tests/ofproto-dpif.at |4 ++--
> > 1 file changed, 2 insertions(+),
87 matches
Mail list logo
