On Wed, Apr 9, 2014 at 10:11 AM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Apr 08, 2014 at 01:37:04PM -0700, Andy Zhou wrote: >> Packet metadata fields may be modified when execute post recirculation >> actions. Current implementation only preserves recirc_id and dp_hash, >> but not other fields. With this patch, a copy of metadata is supplied >> instead of the original metadata for recirculation to preserve >> the original value. > > I think I understand the change here. Previously, if the actions > executed during recirculation changed metadata fields, then any > actions after the recirculation returns would see those new values. > Now, all metadata are saved and restored across a recirculation. > Right?
Correct. I will change the commit message to use your description above since it is clearer. > > Data fields are already saved and restored across recirculation, both > before and after this patch, correct? Yes, A flow will be constructed at the beginning of each recirculation, similar to a new packets received off the wire. The current flow starting the recirc action will continue to be used after recirculation. > > Needs a sign-off. > > I guess I would prefix the first line as "dpif-netdev:" not "recirc:". > Will fix both. > If I'm right about the above: > Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
