On Tue, Apr 08, 2014 at 04:38:50PM -0700, Jarno Rajahalme wrote:
> Key attributes relating to actual packet headers are ignored for
> OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
> from the packet itself.
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>

There is a typo in the subject.

- * flow key against the kernel's.
+ * flow key against the kernel's.  When used with %OVS_PACKET_CMD_EXECUTE,
+ * other than metadata key fields (e.g., priority, skb mark) are ignored as
+ * they are parsed from the packet instead.

I think that the new text actually adds to the confusion because it is
not obvious to the reader whether the parenthesized examples are
"metadata key fields" or "other than metadata key fields".  Perhaps:

    When used with %OVS_PACKET_CMD_EXECUTE, only metadata key fields
    (e.g. priority, skb mark) are honored.  All the fields that can be
    are instead parsed from the packet.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to