On Fri, Apr 04, 2014 at 03:00:41PM -0700, Alex Wang wrote: > This commit adds a new configuration "disable-stats-update" in > "other_config" of Open_Vswitch table. When set, it allows user > to disable the statistics update to OVSDB. This can greatly reduce > the cpu consumption when statistics is not used. > > Signed-off-by: Alex Wang <al...@nicira.com>
I don't like "negative" names, because they often lead to double negatives (e.g. "if (!disable_stats_update)") that can be hard to understand, especially when one reads quickly. Could we use a name like "enable-stats-update" instead? Actually, is the "update" part meaningful? One might simply say "enable-stats". I would expand the documentation to mention more specifically which stats are disabled. It might also be nice to update the description of each stats column to say that it is controlled by this new setting. When stats are disabled, the database might contain old stats that will quickly grow stale, which is not user friendly. It would be nice to clear the stats columns to avoid that. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
