On Wed, Apr 09, 2014 at 04:31:46PM -0700, Alex Wang wrote:
> On Wed, Apr 9, 2014 at 4:13 PM, Ben Pfaff <b...@nicira.com> wrote:
> > I also don't quite follow this comment in
> > iface_refresh_ofproto_status(), because it talks about a change to
> > status but actually checks for an error fetching status:
> >
> >
>
> I'll change the variable name.
But it's not the variable name that's the problem. I guess that
you're thinking about how ofproto_port_get_bfd_status() returns ENOENT
if there's no BFD configured on that port? But in that case we'd
still like to fill in the BFD status (as an empty map) because BFD
might have been configured previously and we don't want to leave stale
status information there.
>
>
> > + smap_init(&smap);
> > + error = ofproto_port_get_bfd_status(iface->port->bridge->ofproto,
> > + iface->ofp_port, &smap);
> > + /* No need to do the following work if there is no change to status.
> > */
> > + if (error < 0) {
> > + return;
> > + }
> > + ovsrec_interface_set_bfd_status(iface->cfg, &smap);
> > + smap_destroy(&smap);
> >
> >
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
