Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-21 Thread Simon Horman
On Wed, Mar 20, 2013 at 05:46:38PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 5:33 PM, Simon Horman wrote: > > On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: > >> On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > >> > Allow datapath to recognize and extract MPLS labels

[ovs-dev] [PATCH v2.23] datapath: Add basic MPLS support to kernel

2013-03-21 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- This is the remaining

[ovs-dev] [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Simon Horman
Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for an 802.3 frame. Frames with a lower value in the ethernet type field are Ethernet II. Also update all the users of this value that I could find to use the new constant. I anticipate adding some more users of this constant when addi

Re: [ovs-dev] [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Stefan Richter
On Mar 21 Simon Horman wrote: > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new constant. > > I anticipate add

Re: [ovs-dev] [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Mar 2013 17:29:28 +0900 Simon Horman escreveu: > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new c

Re: [ovs-dev] [PATCH] datapath: Preallocate reply skb in ovs_vport_cmd_set().

2013-03-21 Thread Kyle Mestery (kmestery)
On Mar 20, 2013, at 6:44 PM, Jesse Gross wrote: > Allocation of the Netlink notification skb can potentially fail > after changing vport configuration. In general, we try to avoid > this by undoing any change we made but that is difficult for existing > objects. This avoids the problem by preall

Re: [ovs-dev] [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread David Miller
From: Simon Horman Date: Thu, 21 Mar 2013 17:29:28 +0900 > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new co

[ovs-dev] [PATCH] ofproto-dpif: xlate actions once with subfacets.

2013-03-21 Thread Ethan Jackson
Before this patch, when ofproto-dpif decided that a particular flow miss needed a facet, it would do action translation multiple times. Once in subfacet_make_actions(), and once per packet in subfacet_update_stats(). In the common case (once per miss), this would double the amount of work required

[ovs-dev] [PATCH] nicira-ext: Fix comment on NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-21 Thread Andy Zhou
CC: Pankaj Thakkar Signed-off-by: Andy Zhou --- include/openflow/nicira-ext.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index e7e7264..54fc4f9 100644 --- a/include/openflow/nicira-ext.h +++ b/include/openf

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate actions once with subfacets.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 11:35:11AM -0700, Ethan Jackson wrote: > Before this patch, when ofproto-dpif decided that a particular flow > miss needed a facet, it would do action translation multiple times. > Once in subfacet_make_actions(), and once per packet in > subfacet_update_stats(). In the com

Re: [ovs-dev] [PATCH] nicira-ext: Fix comment on NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 11:37:32AM -0700, Andy Zhou wrote: > CC: Pankaj Thakkar > Signed-off-by: Andy Zhou Looks good, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto-dpif: xlate actions once with subfacets.

2013-03-21 Thread Ethan Jackson
Ooops, failed to run the unit tests. Here's a version that passes. --- Before this patch, when ofproto-dpif decided that a particular flow miss needed a facet, it would do action translation multiple times. Once in subfacet_make_actions(), and once per packet in subfacet_update_stats(). In the

Re: [ovs-dev] [PATCH] ofproto-dpif: xlate actions once with subfacets.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 12:10:08PM -0700, Ethan Jackson wrote: > Ooops, failed to run the unit tests. Here's a version that passes. This is fine with me too. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote: > On 03/20/2013 10:20 PM, Ben Pfaff wrote: > > Some more background: we don't require Python to build because very > > old versions of the XenServer DDK (under which we have to build OVS to > > produce XenServer binaries) did not i

Re: [ovs-dev] [bfd] bfd: Implement Bidirectional Forwarding Detection.

2013-03-21 Thread Ben Pfaff
On Tue, Mar 12, 2013 at 07:44:10PM -0700, Ethan Jackson wrote: > Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for > interface liveness detection. This has served us well until now, > but has several serious drawbacks which have steadily become more > inconvenient. First, the 80

[ovs-dev] [PATCH 1/2] ovs-bugtool: Remove calls of ovs-ofctl on ovs-system.

2013-03-21 Thread Gurucharan Shetty
With single datapath, making ovs-ofctl calls on ovs-system does not give the necessary o/p. This patch removes those calls. The next patch adds the correct commands to bugtool plugin scripts. Signed-off-by: Gurucharan Shetty --- utilities/bugtool/ovs-bugtool.in |2 -- 1 file changed, 2 dele

[ovs-dev] [PATCH 2/2] ovs-bugtool: Add ovs-ofctl commands to bugtool plugin scripts.

2013-03-21 Thread Gurucharan Shetty
This patch adds two new scripts that run "ovs-ofctl show" and "ovs-ofctl dump-flows" on each bridge. Signed-off-by: Gurucharan Shetty --- utilities/bugtool/automake.mk |2 ++ utilities/bugtool/ovs-bugtool-ovs-ofctl-dump-flows | 24 utilities/bugtoo

Re: [ovs-dev] [PATCH] nicira-ext: Fix comment on NXAST_STACK_PUSH and NXAST_STACK_POP.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 11:37:32AM -0700, Andy Zhou wrote: > CC: Pankaj Thakkar > Signed-off-by: Andy Zhou Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Remove calls of ovs-ofctl on ovs-system.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 02:07:38PM -0700, Gurucharan Shetty wrote: > With single datapath, making ovs-ofctl calls on ovs-system > does not give the necessary o/p. This patch removes those calls. > > The next patch adds the correct commands to bugtool plugin scripts. > > Signed-off-by: Gurucharan

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Add ovs-ofctl commands to bugtool plugin scripts.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 02:07:39PM -0700, Gurucharan Shetty wrote: > This patch adds two new scripts that run "ovs-ofctl show" and > "ovs-ofctl dump-flows" on each bridge. > > Signed-off-by: Gurucharan Shetty > +for bridge in `ovs-vsctl list-br` > +do The quoting here is really curious: > +

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Add ovs-ofctl commands to bugtool plugin scripts.

2013-03-21 Thread Gurucharan Shetty
On Thu, Mar 21, 2013 at 2:31 PM, Ben Pfaff wrote: > On Thu, Mar 21, 2013 at 02:07:39PM -0700, Gurucharan Shetty wrote: >> This patch adds two new scripts that run "ovs-ofctl show" and >> "ovs-ofctl dump-flows" on each bridge. >> >> Signed-off-by: Gurucharan Shetty > >> +for bridge in `ovs-vsctl l

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Add ovs-ofctl commands to bugtool plugin scripts.

2013-03-21 Thread Ben Pfaff
On Thu, Mar 21, 2013 at 02:38:44PM -0700, Gurucharan Shetty wrote: > Do you think we need a new script that does "ovs-appctl > dpif/dump-flows" on each bridge? I don't feel strongly either way. ___ dev mailing list dev@openvswitch.org http://openvswitch.

[ovs-dev] [PATCH] FAQ: Describe use of Linux bond devices with Open vSwitch.

2013-03-21 Thread Ben Pfaff
CC: Jesse Gross Signed-off-by: Ben Pfaff --- FAQ | 29 + 1 file changed, 29 insertions(+) diff --git a/FAQ b/FAQ index 1a2c4f8..90d0003 100644 --- a/FAQ +++ b/FAQ @@ -765,6 +765,35 @@ A: Do you have a controller configured on br0 (as the commands above can ref

[ovs-dev] [PATCH] FAQ: Explain why VMs on a VLAN can't access the Internet.

2013-03-21 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- FAQ | 14 ++ 1 file changed, 14 insertions(+) diff --git a/FAQ b/FAQ index 90d0003..d9224fa 100644 --- a/FAQ +++ b/FAQ @@ -714,6 +714,20 @@ A: It is to be expected that the VMs can't access each other. VLANs the machines you are trying to access a

Re: [ovs-dev] [PATCH] FAQ: Describe use of Linux bond devices with Open vSwitch.

2013-03-21 Thread Reid Price
One nit, there is only one line between the 'Bonds' section and 'Controllers' section. Everywhere else in the file you use 2 lines, with the (accidental) exception of between 'General' and 'Releases', which has 3. -Reid On Thu, Mar 21, 2013 at 3:22 PM, Ben Pfaff wrote: > CC: Jesse Gross > Si

Re: [ovs-dev] [PATCH] FAQ: Describe use of Linux bond devices with Open vSwitch.

2013-03-21 Thread Ben Pfaff
Fixed, thanks. On Thu, Mar 21, 2013 at 03:42:23PM -0700, Reid Price wrote: > One nit, there is only one line between the 'Bonds' section and 'Controllers' > section. Everywhere else in the file you use 2 lines, with the (accidental) > exception of between 'General' and 'Releases', which has 3. >

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-21 Thread Simon Horman
On Wed, Mar 20, 2013 at 03:31:51PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > > * Update the order in which actions are committed and thus > > appear in the datapath such that MPLS actions appear after > > l3 and l4 (nw and port) actions. > > > > In th

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-21 Thread Jesse Gross
On Thu, Mar 21, 2013 at 5:41 PM, Simon Horman wrote: > I think that the way that actions are marshalled by execute_* functions > and then turned into ODP actions using commit_* has worked well for now > and serves to provide a reasonably minimal set of ODP actions. However > it is difficult to mak

Re: [ovs-dev] [PATCH] datapath: Preallocate reply skb in ovs_vport_cmd_set().

2013-03-21 Thread Pravin Shelar
On Wed, Mar 20, 2013 at 4:44 PM, Jesse Gross wrote: > Allocation of the Netlink notification skb can potentially fail > after changing vport configuration. In general, we try to avoid > this by undoing any change we made but that is difficult for existing > objects. This avoids the problem by pr