From: Simon Horman <ho...@verge.net.au> Date: Thu, 21 Mar 2013 17:29:28 +0900
> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > an 802.3 frame. Frames with a lower value in the ethernet type field > are Ethernet II. > > Also update all the users of this value that I could find to use the > new constant. > > I anticipate adding some more users of this constant when > adding MPLS support to Open vSwtich. > > As suggested by Jesse Gross. > > Compile tested only. > > Signed-off-by: Simon Horman <ho...@verge.net.au> You missed a few cases: drivers/media/dvb-core/dvb_net.c: } while (p->ule_sndu_type < 1536); drivers/media/dvb-core/dvb_net.c: if (priv->ule_sndu_type < 1536) { net/atm/lec.h: * is less than 1536(0x0600) MUST be encoded by placing that length drivers/net/wireless/ray_cs.c: if (ntohs(proto) >= 1536) { /* DIX II ethernet frame */ net/bridge/netfilter/ebtables.c: if (FWINV2(ntohs(ethproto) >= 1536, EBT_IPROTO)) include/linux/if_vlan.h: if (ntohs(proto) >= 1536) { net/bluetooth/bnep/netdev.c: if (proto >= 1536) net/openvswitch/flow.c: if (ntohs(proto) >= 1536) net/mac80211/tx.c: } else if (ethertype >= 0x600) { net/wireless/util.c: } else if (ethertype > 0x600) { In fact, the last line looks like a bug, it should be >= not >. Could you take care of these bits and respin your patch? Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev