On Thu, Mar 21, 2013 at 02:07:39PM -0700, Gurucharan Shetty wrote:
> This patch adds two new scripts that run "ovs-ofctl show" and
> "ovs-ofctl dump-flows" on each bridge.
> 
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>

> +for bridge in `ovs-vsctl list-br`
> +do

The quoting here is really curious:

> +    echo "ovs-ofctl dump-flows "${bridge}""
> +    ovs-ofctl dump-flows "$bridge"
> +    echo ""
> +done

There is something similar in the other script.

Otherwise this looks good, thank you.

I guess that you will backport these patches to 1.10?

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to