On Thu, Mar 21, 2013 at 11:35:11AM -0700, Ethan Jackson wrote: > Before this patch, when ofproto-dpif decided that a particular flow > miss needed a facet, it would do action translation multiple times. > Once in subfacet_make_actions(), and once per packet in > subfacet_update_stats(). In the common case (once per miss), this > would double the amount of work required in xlate_actions(). > > The call to facet_push_stats() in subfacet_update_stats() is > unnecessary. If the packets are simply accounted to the facet, > they will eventually be pushed to the relevant rules in > update_stats() or when the facet is removed. Removing the > unnecessary step gives us a 20% improvement of the netperf TCP_CRR > benchmark with the complex flow tables installed by our controller. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
Good catch! Please apply. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
