On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote:
> On 03/20/2013 10:20 PM, Ben Pfaff wrote:
> > Some more background: we don't require Python to build because very
> > old versions of the XenServer DDK (under which we have to build OVS to
> > produce XenServer binaries) did not include a Python interpreter. I
> > was playing with a newer XenServer DDK the other day, though, and
> > noticed that it does include Python. So it might be possible to just
> > add Python as a build-time requirement these days, in which case we
> > could simplify the makefiles and make them much more straightforward.
>
> I agree with it. Actually to be able to do a "make dist", the ./boot.sh
> is not sufficient, I have to launch a configure first. But since I am
> cross compiling, it doesn't make that much sense to do "./boot.sh &&
> ./configure && make dist", then "${OVS_DIST}/configure --host=${TARGET}
> && make".
> Something more straight forward should be feasible.
The straightforward solution is to use a writable source directory.
Since you are not using the straightforward solution, you have to use
some other solution.
> From my understanding, my patch could be part of the solution. There
> could be an additional check on the presence of python during the
> configure step, and lib/ofp-errors.inc could be removed from the make dist.
> Is this what you mean ?
No. That would make everything more complicated. It would also make
the contents of the distribution tarball unpredictable: its contents
would depend on what software was installed on the computer that runs
"make dist", whereas it does not currently depend on that.
I am suggesting that we require the machine on which Open vSwitch is
built to have Python installed. Then we can always generate
ofp-errors.inc at build time, so there is no need to distribute it.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
